MediaRouterDesktopTest.EnableMdnsAfterEachRegister increased flakiness |
||||
Issue descriptionSeems to have increased in flakes recently, see https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=MediaRouterDesktopTest.EnableMdnsAfterEachRegister An example: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64445 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F64445%2F%2B%2Frecipes%2Fsteps%2Funit_tests%2F0%2Flogs%2FMediaRouterDesktopTest.EnableMdnsAfterEachRegister%2F0 Function call: EnableMdnsDiscovery() Expected: to be called once Actual: called twice - over-saturated and active https://chromium-review.googlesource.com/c/chromium/src/+/673705 seems suspicious, assigning to takumif@ to investigate. Please redirect if someone else would be better suited to this.
,
Nov 6 2017
This test is now failing on almost every build. I'm going to disable.
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e66db74af3c38cbcdc8a84388be1b5ca2b435bd commit 8e66db74af3c38cbcdc8a84388be1b5ca2b435bd Author: Scott Violet <sky@chromium.org> Date: Mon Nov 06 21:50:38 2017 Disable MediaRouterDesktopTest.EnableMdnsAfterEachRegister on windows This test is failing on almost every build now. I would attempt to revert the suspect patch, but it's now five days since committed. BUG= 781412 TEST=none TBR=takumif@chromium.org Change-Id: Ie0fe7a08afa582c418ac0e2fcaac874c46b2445a Reviewed-on: https://chromium-review.googlesource.com/755414 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#514250} [modify] https://crrev.com/8e66db74af3c38cbcdc8a84388be1b5ca2b435bd/chrome/browser/media/router/mojo/media_router_desktop_unittest.cc
,
Nov 8 2017
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/687b4385de466e7f3783d0f401f64d296551df94 commit 687b4385de466e7f3783d0f401f64d296551df94 Author: btolsch <btolsch@chromium.org> Date: Wed Nov 08 00:34:56 2017 Fix some Windows-disabled MediaRouterDesktop tests The MediaRouterDesktop refactoring dropped the FirewallCheck::SKIP_FOR_TESTING flag, which causes the firewall check to run, which runs outside of chrome's normally controlled message loops (in a COM STA thread) which leads to a race. The refactoring also dropped the is_mdns_enabled_ flag which changes the number/timing of EnableMdnsDiscovery() calls to expect. Bug: 752513 , 781412 Change-Id: I11c492f9a068c6c048dafd11ece5684b095ebef1 Reviewed-on: https://chromium-review.googlesource.com/756892 Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#514670} [modify] https://crrev.com/687b4385de466e7f3783d0f401f64d296551df94/chrome/browser/media/router/mojo/media_router_desktop_unittest.cc
,
Nov 8 2017
Removing Sheriff-Chromium now that the bug is assigned and being investigated.
,
Nov 9 2017
Thanks Brandon. The dashboard is looking much better and I believe this can be closed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by s...@chromium.org
, Nov 3 2017