[MD extensions] [errors console] improve UI of similar errors that occurred in different contexts |
|||||||
Issue descriptionInstall test extension "Content Script Log and Runtime Error" from chrome/test/data/extensions/error_console/ Then load a few websites. Then look at the errors page for that extension. There's a repeated set of (the same) error messages for each page loaded. Should we - de-dupe the errors - or clear the list of errors when we get new errors - or accumulate them as it does now
,
Nov 10 2017
,
Nov 10 2017
Ah, interesting. The C++ side does error de-duping already [1], but it considers the context in which an error occurred. If an error occurs on multiple sites, we consider them different. Ideally, we'd be able to surface this to the developer in such a way that we don't include a ton of duplicate errors, but do show the sites that it happened on. But I don't know if we can easily do that. For now, perhaps we should just collapse them. Separately: it looks like the context url is missing from the MD version - that will be important to have.
,
Nov 10 2017
,
Nov 15 2017
,
Dec 5 2017
Grouping all error-console related bugs into a hotlist, so that we can better keep track of them.
,
Dec 8 2017
They are considered different errors since the "view in developer mode" would show you a separate JS console within its context, so we should surface as separate entries instead of collapsing them, otherwise we wouldn't be able to "view in developer mode" in each of their contexts. I think this is working as intended. Thoughts?
,
Dec 8 2017
@7 Yeah, that makes some sense. It's not clear in the UI as-is. What can we do to clarify what's happening? Brain storming ideas: maybe have a way to select the context, then see the errors in that context? Or, maybe put headings or labels in the list so that the context is apparent there? I think the UI should be improved in some way, I don't think it's clear as-is.
,
Dec 8 2017
I think, from a developer standpoint, what would be most useful would be to be able to see the list of errors, and then all contexts in which those errors occurred. E.g., something like: "Some error happened!" (4 contexts) ^ and then selecting the error (to display it in the code view) would also expand to see the contexts, e.g.: "Some error happened!" (4 contexts) v example.com [open in devtools] google.com [open in devtools] chromium.org [open in devtools] gmail.com [open in devtools]
,
Dec 9 2017
I think for parity, to show the context url per error like the old UI, we could do something like this (see attached)? This would also address issue 783961 . I like what Devlin suggested, but I think that's a feature improvement we can work on in the near future, but in the meantime I think "Issues repeat" should not be considered a bug if we indicate that they have different context urls.
,
Dec 9 2017
@10 I believe the colon in "Context:" should not be in MD UI (based on prior discussions with UX). I expect the desire will be to remove the colon from "Context" and move the URL to the next line (put the URL on a line of its own). Of course bettes@ will have the authoritative answer, I'm just making a prediction on what bettes@ will say.
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5459ad664d6c6aa357c8440296ccd12435f81f90 commit 5459ad664d6c6aa357c8440296ccd12435f81f90 Author: Scott Chen <scottchen@chromium.org> Date: Tue Dec 19 01:56:41 2017 MD Extensions: show context url for stack trace Bug: 781410, 783961 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I097a787d2c0b973e5cc544e76ced6cead9bb32ca Reviewed-on: https://chromium-review.googlesource.com/823603 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524908} [modify] https://crrev.com/5459ad664d6c6aa357c8440296ccd12435f81f90/chrome/app/md_extensions_strings.grdp [modify] https://crrev.com/5459ad664d6c6aa357c8440296ccd12435f81f90/chrome/browser/resources/md_extensions/error_page.html [modify] https://crrev.com/5459ad664d6c6aa357c8440296ccd12435f81f90/chrome/browser/resources/md_extensions/error_page.js [modify] https://crrev.com/5459ad664d6c6aa357c8440296ccd12435f81f90/chrome/browser/ui/webui/extensions/extensions_ui.cc [modify] https://crrev.com/5459ad664d6c6aa357c8440296ccd12435f81f90/chrome/test/data/webui/extensions/extension_error_page_test.js
,
Jan 2 2018
As discussed offline, repurposing this bug to be a feature improvement task.
,
Mar 28 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dschuyler@chromium.org
, Nov 10 2017