New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781410 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Feature



Sign in to add a comment

[MD extensions] [errors console] improve UI of similar errors that occurred in different contexts

Project Member Reported by dschuyler@chromium.org, Nov 3 2017

Issue description

Install test extension "Content Script Log and Runtime Error" from chrome/test/data/extensions/error_console/
Then load a few websites.
Then look at the errors page for that extension.
There's a repeated set of (the same) error messages for each page loaded.

Should we 
- de-dupe the errors 
- or clear the list of errors when we get new errors
- or accumulate them as it does now
 
Screenshot from 2017-11-03 12:12:21.png
35.4 KB View Download
It looks like the prior error UI (seen using --enable-error-console) seems to act similarly.
Screenshot from 2017-11-10 14:03:04.png
74.0 KB View Download
Cc: rdevlin....@chromium.org
Ah, interesting.  The C++ side does error de-duping already [1], but it considers the context in which an error occurred.  If an error occurs on multiple sites, we consider them different.

Ideally, we'd be able to surface this to the developer in such a way that we don't include a ton of duplicate errors, but do show the sites that it happened on.  But I don't know if we can easily do that.  For now, perhaps we should just collapse them.

Separately: it looks like the context url is missing from the MD version - that will be important to have.
Labels: -Pri-1 Pri-2
Summary: [MD extensions] [errors console] issues repeat (was: [MD extensions] errors page, issues repeat)
Labels: Hotlist-MD-Extensions-ErrorConsole
Grouping all error-console related bugs into a hotlist, so that we can better keep track of them.
They are considered different errors since the "view in developer mode" would show you a separate JS console within its context, so we should surface as separate entries instead of collapsing them, otherwise we wouldn't be able to "view in developer mode" in each of their contexts.

I think this is working as intended. Thoughts?
@7 Yeah, that makes some sense. It's not clear in the UI as-is. What can we do to clarify what's happening?

Brain storming ideas: maybe have a way to select the context, then see the errors in that context? Or, maybe put headings or labels in the list so that the context is apparent there?

I think the UI should be improved in some way, I don't think it's clear as-is.
I think, from a developer standpoint, what would be most useful would be to be able to see the list of errors, and then all contexts in which those errors occurred.  E.g., something like:

"Some error happened!" (4 contexts) ^

and then selecting the error (to display it in the code view) would also expand to see the contexts, e.g.:


"Some error happened!" (4 contexts) v
  example.com  [open in devtools]
  google.com   [open in devtools]
  chromium.org [open in devtools]
  gmail.com    [open in devtools]
I think for parity, to show the context url per error like the old UI, we could do something like this (see attached)? This would also address  issue 783961 .

I like what Devlin suggested, but I think that's a feature improvement we can work on in the near future, but in the meantime I think "Issues repeat" should not be considered a bug if we indicate that they have different context urls.
Screenshot from 2017-12-08 16:59:23.png
36.9 KB View Download
@10 I believe the colon in "Context:" should not be in MD UI (based on prior discussions with UX). I expect the desire will be to remove the colon from "Context" and move the URL to the next line (put the URL on a line of its own). Of course bettes@ will have the authoritative answer, I'm just making a prediction on what bettes@ will say.
Summary: [MD extensions] [errors console] improve UI of similar errors that occurred in different contexts (was: [MD extensions] [errors console] issues repeat)
As discussed offline, repurposing this bug to be a feature improvement task.

Comment 14 by jawag@chromium.org, Mar 28 2018

Labels: -Type-Bug -Pri-2 Pri-3 Type-Feature

Sign in to add a comment