New issue
Advanced search Search tips

Issue 781409 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Integrate SoM Test Disabling with Telemetry

Project Member Reported by rnep...@chromium.org, Nov 3 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/42b64b98a2d0b7232eb336e8547073c01008e6c0

commit 42b64b98a2d0b7232eb336e8547073c01008e6c0
Author: rnephew <rnephew@chromium.org>
Date: Thu Nov 30 22:20:57 2017

[Telemetry] Add test Expectation file parser for TA/DA telemetry integration.

This uses the format for tagged tests described in go/chromium-test-list-format.
It parses the file and returns a list of dictionaries that contain:
{
  'reason': crbug.com123/Bug(),
  'test': test_name,
  'conditions': [list, of, conditions]
  'results': [list, of, results]
}

The only enteries that are guarenteed to not be empty by the defined grammar are
test and results. Reason and conditions will be None and [] if they are not
included in the expectation entry.

The next CL will use this list to create StoryExpectations that are already used
by telemetry for disabling stories.

Bug: chromium:781409
Change-Id: I1979fa19c56afd86924beb24daf9fa6eaca673f4
Reviewed-on: https://chromium-review.googlesource.com/772805
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>

[add] https://crrev.com/42b64b98a2d0b7232eb336e8547073c01008e6c0/common/py_utils/py_utils/expectations_parser_unittest.py
[add] https://crrev.com/42b64b98a2d0b7232eb336e8547073c01008e6c0/common/py_utils/py_utils/expectations_parser.py
[modify] https://crrev.com/42b64b98a2d0b7232eb336e8547073c01008e6c0/telemetry/telemetry/story/expectations.py

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/c796cbc3a6e6c45f95d9dd7bf8769f7407719dcf

commit c796cbc3a6e6c45f95d9dd7bf8769f7407719dcf
Author: rnephew <rnephew@chromium.org>
Date: Fri Dec 01 23:31:37 2017

[Telemetry/TADA] Make TADA parser return structured data instead of dictionary.

Bug: chromium:781409
Change-Id: I72d94beb9d8dc3fee1adead4313d21b88bbcb7a6
Reviewed-on: https://chromium-review.googlesource.com/804149
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/c796cbc3a6e6c45f95d9dd7bf8769f7407719dcf/common/py_utils/py_utils/expectations_parser_unittest.py
[modify] https://crrev.com/c796cbc3a6e6c45f95d9dd7bf8769f7407719dcf/common/py_utils/py_utils/expectations_parser.py

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/c41298929a2e751ecb8741af27a38a9fb8f5f6eb

commit c41298929a2e751ecb8741af27a38a9fb8f5f6eb
Author: rnephew <rnephew@chromium.org>
Date: Tue Dec 05 18:54:49 2017

[Telemetry/TADA] Fix bug where story name cannot be url.

Telemetry currently has test names that contain urls. This was not properly
being parsed before.

Bug: chromium:781409
Change-Id: I827589b7fbb64173cf1a88978a3a820ebdc2db9c
Reviewed-on: https://chromium-review.googlesource.com/809385
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>

[modify] https://crrev.com/c41298929a2e751ecb8741af27a38a9fb8f5f6eb/common/py_utils/py_utils/expectations_parser_unittest.py
[modify] https://crrev.com/c41298929a2e751ecb8741af27a38a9fb8f5f6eb/common/py_utils/py_utils/expectations_parser.py

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/4b9e49a8819b43f0fa5a80d7649a3b13118d6df6

commit 4b9e49a8819b43f0fa5a80d7649a3b13118d6df6
Author: rnephew <rnephew@chromium.org>
Date: Tue Dec 05 20:05:39 2017

[Telemetry] Add expectations path to telemetry config object.

Bug: chromium:781409
Change-Id: Id9e73a0a97adf3c556a5f39679e8c96d35acabf9
Reviewed-on: https://chromium-review.googlesource.com/809387
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>

[modify] https://crrev.com/4b9e49a8819b43f0fa5a80d7649a3b13118d6df6/telemetry/telemetry/project_config.py

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/09fc536c66c644ad0ec55b8048d5efe11e4af7c7

commit 09fc536c66c644ad0ec55b8048d5efe11e4af7c7
Author: rnephew <rnephew@chromium.org>
Date: Tue Dec 05 20:34:29 2017

[Telemetry/TADA] Give StoryExpectations the ability to decode TADA expectation files

Bug: chromium:781409
Change-Id: I22c25dd725eb04beb2d6bd2a56f7506fc3ce32f7
Reviewed-on: https://chromium-review.googlesource.com/802242
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/09fc536c66c644ad0ec55b8048d5efe11e4af7c7/telemetry/telemetry/story/expectations_unittest.py
[modify] https://crrev.com/09fc536c66c644ad0ec55b8048d5efe11e4af7c7/telemetry/telemetry/story/expectations.py

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/26ffbad1dccf66efe1a5296669b357a69b907012

commit 26ffbad1dccf66efe1a5296669b357a69b907012
Author: rnephew <rnephew@chromium.org>
Date: Wed Dec 06 17:23:42 2017

[Telemetry/TADA] Make expectation parser only support raw data and not file path.

We decided it added a lot of complexity for no real usability gain.


Bug: chromium:781409
Change-Id: I716bb82db2c3e5511d63576a47d6d440dce40088
Reviewed-on: https://chromium-review.googlesource.com/810929
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/26ffbad1dccf66efe1a5296669b357a69b907012/common/py_utils/py_utils/expectations_parser_unittest.py
[modify] https://crrev.com/26ffbad1dccf66efe1a5296669b357a69b907012/common/py_utils/py_utils/expectations_parser.py

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/82576a5bdd2ef41eedc0b95c3c47115585f4e73c

commit 82576a5bdd2ef41eedc0b95c3c47115585f4e73c
Author: rnephew <rnephew@chromium.org>
Date: Thu Dec 07 23:34:22 2017

[Telemetry/TADA] Add trailing comment support to expectations_parser.py

Bug: chromium:781409
Change-Id: I96e6b6aefc5459ffe51e18af1dd36a4b401e97af
Reviewed-on: https://chromium-review.googlesource.com/815393
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/82576a5bdd2ef41eedc0b95c3c47115585f4e73c/common/py_utils/py_utils/expectations_parser_unittest.py
[modify] https://crrev.com/82576a5bdd2ef41eedc0b95c3c47115585f4e73c/common/py_utils/py_utils/expectations_parser.py

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67a0869564137d53f46a7126ff4ad746fc228948

commit 67a0869564137d53f46a7126ff4ad746fc228948
Author: rnephew <rnephew@chromium.org>
Date: Fri Dec 08 00:12:38 2017

[Telemetry] Add expectations path to telemetry config object.

Chromium side change for:
    https://chromium-review.googlesource.com/c/catapult/+/809387

Needs catapult to roll before landing.

Bug: 781409
Change-Id: Ib8713766391fa2425fba9ffb981bcbbc44b4b8bc
Reviewed-on: https://chromium-review.googlesource.com/809646
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522630}
[modify] https://crrev.com/67a0869564137d53f46a7126ff4ad746fc228948/tools/perf/chrome_telemetry_build/chromium_config.py

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33177d59859f59db370b6a7344b19692cb685b9d

commit 33177d59859f59db370b6a7344b19692cb685b9d
Author: rnephew <rnephew@chromium.org>
Date: Fri Dec 08 17:43:08 2017

[Telemetry] Turn TADA style expectations on for loading.desktop benchmark.

Bug: 781409
Change-Id: Iee80696399e7343dda4d04865dffe409f45ec8b4
Reviewed-on: https://chromium-review.googlesource.com/815283
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522812}
[modify] https://crrev.com/33177d59859f59db370b6a7344b19692cb685b9d/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/33177d59859f59db370b6a7344b19692cb685b9d/tools/perf/core/path_util.py
[add] https://crrev.com/33177d59859f59db370b6a7344b19692cb685b9d/tools/perf/expectations.config
[modify] https://crrev.com/33177d59859f59db370b6a7344b19692cb685b9d/tools/perf/run_benchmark

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b54c7717f3cee4746b5cd1949e02cfe3a1437c6a

commit b54c7717f3cee4746b5cd1949e02cfe3a1437c6a
Author: rnephew <rnephew@chromium.org>
Date: Tue Dec 12 01:18:19 2017

[Telemetry] Disable mojo loading stories using new test expectations config file

Bug: 781409
Change-Id: I7d41a7ef52df506c6cb11f8c19051a0f5c63f500
Reviewed-on: https://chromium-review.googlesource.com/820812
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#523289}
[modify] https://crrev.com/b54c7717f3cee4746b5cd1949e02cfe3a1437c6a/tools/perf/expectations.config

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/357abcdf0bab16d9304dc7f8cf78f488d80fcdcb

commit 357abcdf0bab16d9304dc7f8cf78f488d80fcdcb
Author: rnephew <rnephew@chromium.org>
Date: Thu Dec 14 16:57:01 2017

[Telemetry] Use new expectations file when validating disabled stories names.

Bug: 781409
Change-Id: I89a3561584e18dc56e411bceb0ee25d72e996989
Reviewed-on: https://chromium-review.googlesource.com/818331
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524090}
[modify] https://crrev.com/357abcdf0bab16d9304dc7f8cf78f488d80fcdcb/tools/perf/core/story_expectation_validator.py
[add] https://crrev.com/357abcdf0bab16d9304dc7f8cf78f488d80fcdcb/tools/perf/core/story_expectation_validator_unittest.py

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/941f6397f9e27e3d500c065d182518d2aa075437

commit 941f6397f9e27e3d500c065d182518d2aa075437
Author: rnephew <rnephew@chromium.org>
Date: Thu Dec 14 23:04:52 2017

[Telemetry/TADA] Add support for wildcard disabling of benchmark using expectations parser.

The TA/DA format supports the use of benchmark/* to wildcard disable the entire
benchmark. This adds support for that to telemetry.

Bug: chromium:781409
Change-Id: I7923767e4005571076c60c2edc1f1f9a92b4ce73
Reviewed-on: https://chromium-review.googlesource.com/817550
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>

[modify] https://crrev.com/941f6397f9e27e3d500c065d182518d2aa075437/telemetry/telemetry/story/expectations_unittest.py
[modify] https://crrev.com/941f6397f9e27e3d500c065d182518d2aa075437/telemetry/telemetry/story/expectations.py

Project Member

Comment 14 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/aa6995756f55aa2c938b19a79674bb5aaee018e4

commit aa6995756f55aa2c938b19a79674bb5aaee018e4
Author: rnephew <rnephew@chromium.org>
Date: Thu Dec 14 23:31:22 2017

[Telemetry] Make WprRecorder no longer use expectations.

We want to always record every story that matches the wpr request.

Bug: chromium:781409
Change-Id: I3467691a80d0540f4efd4b2977f79c3cc22222e0
Reviewed-on: https://chromium-review.googlesource.com/827790
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>

[modify] https://crrev.com/aa6995756f55aa2c938b19a79674bb5aaee018e4/telemetry/telemetry/record_wpr.py

Project Member

Comment 15 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/3dad0ccfee635ac03c05c6d577938a786118c074

commit 3dad0ccfee635ac03c05c6d577938a786118c074
Author: rnephew <rnephew@chromium.org>
Date: Thu Dec 14 23:31:41 2017

Get rid of spaces in telemetry story names in dashboard tests.

We are getting rid of spaces in all story names to not have spaces.
This is so we can more easily integrate with TA/DAs test expectation
format.

Bug: chromium:781409
Change-Id: Ia37d75f1e5c5da3969865fbe2532e4ee75141c73
Reviewed-on: https://chromium-review.googlesource.com/822181
Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>

[modify] https://crrev.com/3dad0ccfee635ac03c05c6d577938a786118c074/dashboard/dashboard/start_try_job_test.py

Project Member

Comment 16 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbd7a6704a9850acc8037afb981d1205979dbfd1

commit cbd7a6704a9850acc8037afb981d1205979dbfd1
Author: rnephew <rnephew@chromium.org>
Date: Fri Dec 15 17:23:33 2017

[Telemetry] Remove spaces from story names.

TBR: bustamante@chromium.org
Bug: 781409
Change-Id: Ie2c3eda81add06d897369933588363ebc293c4e7
Reviewed-on: https://chromium-review.googlesource.com/823178
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#524403}
[modify] https://crrev.com/cbd7a6704a9850acc8037afb981d1205979dbfd1/tools/chrome_proxy/live_tests/pagesets/data/chrome_proxy_top_20.json
[modify] https://crrev.com/cbd7a6704a9850acc8037afb981d1205979dbfd1/tools/chrome_proxy/live_tests/pagesets/top_20.py
[modify] https://crrev.com/cbd7a6704a9850acc8037afb981d1205979dbfd1/tools/perf/benchmarks/smoothness.py
[modify] https://crrev.com/cbd7a6704a9850acc8037afb981d1205979dbfd1/tools/perf/benchmarks/v8.py
[modify] https://crrev.com/cbd7a6704a9850acc8037afb981d1205979dbfd1/tools/perf/page_sets/data/key_mobile_sites_smooth.json
[modify] https://crrev.com/cbd7a6704a9850acc8037afb981d1205979dbfd1/tools/perf/page_sets/data/top_25.json
[modify] https://crrev.com/cbd7a6704a9850acc8037afb981d1205979dbfd1/tools/perf/page_sets/data/top_25_smooth.json
[modify] https://crrev.com/cbd7a6704a9850acc8037afb981d1205979dbfd1/tools/perf/page_sets/key_mobile_sites_smooth.py
[modify] https://crrev.com/cbd7a6704a9850acc8037afb981d1205979dbfd1/tools/perf/page_sets/top_pages.py

Project Member

Comment 17 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/a41c8c66689c9bcea155a13eb71457b4ec1c9824

commit a41c8c66689c9bcea155a13eb71457b4ec1c9824
Author: rnephew <rnephew@chromium.org>
Date: Fri Dec 15 18:38:08 2017

[Telemetry] Make it so story expectations do not require a reason.

TADA format does not require reasons, so we should't.

Bug: chromium:781409
Change-Id: I0310c88c4aa0f9f9214a52ff72d951472110728e
Reviewed-on: https://chromium-review.googlesource.com/829978
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>

[modify] https://crrev.com/a41c8c66689c9bcea155a13eb71457b4ec1c9824/telemetry/telemetry/story/expectations.py

Project Member

Comment 19 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/b5e23eeaae74cea9c79a447d6cf57f377588a76e

commit b5e23eeaae74cea9c79a447d6cf57f377588a76e
Author: rnephew <rnephew@chromium.org>
Date: Fri Dec 15 20:43:11 2017

Revert "[Telemetry] Add assertion that story names do not contain spaces."

This reverts commit 39b6a81ab1e9482741ee259d269f24850f73025c.

Reason for revert:

A few stories still have spaces in the names. This will block the roll.

Original change's description:
> [Telemetry] Add assertion that story names do not contain spaces.
> 
> requires https://chromium-review.googlesource.com/c/chromium/src/+/823178 to land first.
> LANDED
> 
> Bug: chromium:781409
> Change-Id: Ia0a91eb8f8b78693d17058a18fd2e34da21e1138
> Reviewed-on: https://chromium-review.googlesource.com/824438
> Commit-Queue: rnephew <rnephew@chromium.org>
> Reviewed-by: Charlie Andrews <charliea@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>

TBR=perezju@chromium.org,nednguyen@google.com,charliea@chromium.org,rnephew@chromium.org

Change-Id: Ic19d973782b11f7f05595d2f03e7437ed864fe0f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:781409
Reviewed-on: https://chromium-review.googlesource.com/830826
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>

[modify] https://crrev.com/b5e23eeaae74cea9c79a447d6cf57f377588a76e/telemetry/telemetry/benchmark_unittest.py
[modify] https://crrev.com/b5e23eeaae74cea9c79a447d6cf57f377588a76e/telemetry/telemetry/story/story_unittest.py
[modify] https://crrev.com/b5e23eeaae74cea9c79a447d6cf57f377588a76e/telemetry/telemetry/story/story.py
[modify] https://crrev.com/b5e23eeaae74cea9c79a447d6cf57f377588a76e/telemetry/telemetry/benchmark_run_unittest.py
[modify] https://crrev.com/b5e23eeaae74cea9c79a447d6cf57f377588a76e/telemetry/telemetry/internal/story_runner_unittest.py

Project Member

Comment 20 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1237dbe29659b7e418b0209077f5af298e42d9ef

commit 1237dbe29659b7e418b0209077f5af298e42d9ef
Author: rnephew <rnephew@chromium.org>
Date: Fri Dec 15 20:46:28 2017

[Telemetry] Move system_health_csv_generator to use expectations file.

Bug: 781409
Change-Id: I70d28e9f43a4747f19666fbfa9f3bb18ac1d22d7
Reviewed-on: https://chromium-review.googlesource.com/830256
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524454}
[modify] https://crrev.com/1237dbe29659b7e418b0209077f5af298e42d9ef/tools/perf/core/system_health_csv_generator.py
[modify] https://crrev.com/1237dbe29659b7e418b0209077f5af298e42d9ef/tools/perf/system_health_stories.csv

Project Member

Comment 21 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3046bd39ad90a98eec534ae4d3ce7329b04fa59

commit c3046bd39ad90a98eec534ae4d3ce7329b04fa59
Author: rnephew <rnephew@chromium.org>
Date: Fri Dec 15 22:51:41 2017

[Telemetry] Get rid of spaces in more telemetry benchmark story names

Bug: 781409
Change-Id: Ia653a5a71e3e0063836a6e158ca3fcd6f2dc549b
Reviewed-on: https://chromium-review.googlesource.com/830676
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524499}
[modify] https://crrev.com/c3046bd39ad90a98eec534ae4d3ce7329b04fa59/tools/perf/page_sets/data/tough_path_rendering_cases.json
[modify] https://crrev.com/c3046bd39ad90a98eec534ae4d3ce7329b04fa59/tools/perf/page_sets/tough_filters_cases.py
[modify] https://crrev.com/c3046bd39ad90a98eec534ae4d3ce7329b04fa59/tools/perf/page_sets/tough_path_rendering_cases.py

Project Member

Comment 22 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aff28d76e9c14e7f7c5700c8e1b04dadc047a89d

commit aff28d76e9c14e7f7c5700c8e1b04dadc047a89d
Author: rnephew <rnephew@chromium.org>
Date: Fri Dec 15 23:43:22 2017

[Telemetry] Make perf_data_generator not use expectations

Bug: 781409
Change-Id: I214af9ee0173795c5909d3a037c944af8f5ae456
Reviewed-on: https://chromium-review.googlesource.com/830683
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524519}
[modify] https://crrev.com/aff28d76e9c14e7f7c5700c8e1b04dadc047a89d/tools/perf/core/perf_data_generator.py

Project Member

Comment 23 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae3f936d5d6e9c26c9d0ad76d4a61ce028cd8897

commit ae3f936d5d6e9c26c9d0ad76d4a61ce028cd8897
Author: rnephew <rnephew@chromium.org>
Date: Mon Dec 18 20:19:30 2017

[Telemetry] Update system_health_smoke_test to use expectations file.

It composes its storysets by iterating over other benchmarks. This
updates the benchmark to also load expectations from those benchmarks.

Bug: 781409
Change-Id: I857788e8483e953e53b05bc59ecff9f968fc52cc
Reviewed-on: https://chromium-review.googlesource.com/832381
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524781}
[modify] https://crrev.com/ae3f936d5d6e9c26c9d0ad76d4a61ce028cd8897/tools/perf/benchmarks/system_health.py
[modify] https://crrev.com/ae3f936d5d6e9c26c9d0ad76d4a61ce028cd8897/tools/perf/benchmarks/system_health_smoke_test.py
[modify] https://crrev.com/ae3f936d5d6e9c26c9d0ad76d4a61ce028cd8897/tools/perf/expectations.config
[modify] https://crrev.com/ae3f936d5d6e9c26c9d0ad76d4a61ce028cd8897/tools/perf/page_sets/system_health/expectations.py

Project Member

Comment 24 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7

commit e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7
Author: rnephew <rnephew@chromium.org>
Date: Tue Dec 19 07:30:16 2017

[Telemetry] Move all expectations into expectations file

******************************
SHERIFF: DO NOT REVERT THIS CL
Contact me if it causes issues.
******************************

Bug: 781409
Change-Id: I5c6e33fac45bf32f8dff445ded7287ae9cf448dc
Reviewed-on: https://chromium-review.googlesource.com/830815
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#524964}
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/battor.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/blink_perf.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/dummy_benchmark.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/jetstream.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/kraken.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/media.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/memory.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/octane.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/oortonline.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/power.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/rasterize_and_record_micro.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/smoothness.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/speedometer.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/speedometer2.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/system_health.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/tab_switching.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/thread_times.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/tracing.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/v8.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/v8_browsing.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/wasm.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/benchmarks/webrtc.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/contrib/blink_perf_xml_http_request/blink_perf_xml_http_request.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/contrib/cluster_telemetry/loading_ct.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/contrib/cluster_telemetry/multipage_skpicture_printer.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/contrib/cros_benchmarks/page_cycler_v2.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/contrib/cros_benchmarks/tab_switching_bench.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/contrib/dromaeo_extras/dromaeo_extras.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/contrib/heap_profiling/heap_profiling.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/contrib/memory_extras/memory_extras.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/contrib/oilpan/oilpan_benchmarks.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/contrib/tracing/tracing.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/core/system_health_csv_generator.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/expectations.config
[delete] https://crrev.com/f694beed853dab5bfe06fbde29293677a47e87ad/tools/perf/page_sets/system_health/expectations.py
[modify] https://crrev.com/e70c64af077f7eb1a0eede0a45d1e8e14abb0ed7/tools/perf/system_health_stories.csv

Project Member

Comment 25 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36f929040420a0142b91081d4689d63d4db229de

commit 36f929040420a0142b91081d4689d63d4db229de
Author: rnephew <rnephew@chromium.org>
Date: Tue Dec 19 20:01:56 2017

[Telemetry] Update documentation on how to disable telemetry stories.

In preparation for TA/DA one click test disabling, we have refactored
how telemetry tests are disabled. This documentation change reflects
the new reality of how to disable failing telemetry stories.

Bug: 781409
Change-Id: I16f62ebb8fa048d3ae0314cc0a6149faa14f1e45
Reviewed-on: https://chromium-review.googlesource.com/818074
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#525121}
[modify] https://crrev.com/36f929040420a0142b91081d4689d63d4db229de/docs/speed/perf_bot_sheriffing.md

Status: Assigned (was: Untriaged)
Owner: ----
Status: Available (was: Assigned)
Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.

Sign in to add a comment