New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781398 link

Starred by 136 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature

Blocked on:
issue 781604

Blocking:
issue 854933

Restricted
  • Only users with EditIssue permission may comment.


Show other hotlists

Hotlists containing this issue:
Chromium-bugs-related-to-Crostini


Sign in to add a comment

crosvm: implement emulated AC97 codec

Project Member Reported by smbar...@chromium.org, Nov 3 2017

Issue description

Support audio playback/capture in crosvm with an emulated AC97 codec.
 
Blockedon: 781604
Cc: smbar...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Not starting this one quite yet. PCI emulation is a bit bigger than I wanted to chew on this week.

Comment 3 Deleted

Comment 4 Deleted

Comment 5 Deleted

Labels: Hotlist-Crostini-Platform

Comment 7 by dgreid@chromium.org, May 21 2018

Owner: dgreid@chromium.org
Status: Started (was: Available)

Comment 8 Deleted

Cc: rjahagir@chromium.org vsu...@chromium.org
 Issue 851185  has been merged into this issue.
 Issue 851221  has been merged into this issue.
Blocking: 854933
Labels: M-70
Should we change the subject line more generic for end users to easily recognize it? :-)
As an alternative to emulating an AC97 codec have we considered writing an ALSA or PulseAudio backend that talks to the CRAS daemon on the host system similar to how we proxy the Wayland protocol?
i don't think we should cater to any userland daemon (e.g. PulseAudio).  an ALSA plugin might be the lowest common denominator that would work, but i'm not sure that extra complexity would be worth it.  we'd have to make sure people have our custom plugin bind mounted in to the container and configured in their alsa settings (either in /etc or in the user's ~/) which is a bit fragile.  it's more complex than our existing daemons because we'd have to be in-process for all processes that want to talk directly to the ALSA streams.

doing an AC97 codec would isolate us from all that because it'd just be the guest VM kernel exposing the ALSA nodes to userland which is what all userlands/containers expect out of the box.  and if we wanted, could add OSS shims.
any progress?
Labels: -M-70 M-73
i think there's a PoC, but unlikely to land for R72.  Dylan might be able to post more details or relabel the milestone target.
Just throwing in a thumbs-up of support for this, since it would allow my daughter to play basic Steam games with sound on her Chromebook in Crostini.  
Thanks for all the hard work on this awesome project.

Comment 18 Deleted

Desperately awaiting this functionality, such that I can use ardour on my Pixelbook for multitrack recording. Happy to help with any testing.
The first version will be stereo playback only. Microphone access will come later, we want to make sure the access controls are just right before we allow untrusted code to use the microphone.
what do you meen with stereo play back?


På 13 november 2018 12:25:29 em dgr… via monorail 
<monorail+v2.2092716985@chromium.org> skrev:
@dgreid - thanks, and understood. For my purposes, sound will enter via outboard ADC/DAC using USB, and I don't really have any need for mic input. I'll be delighted with stereo output only. Do you have a rough timeline (I see elsewhere 72 is unlikely - is 73 probable?)?
Another Pixelbook tinkerer here. Would love to help test. -mwb

Comment 24 Deleted

Comment 25 Deleted

Labels: Restrict-AddIssueComment-EditIssue
this bug is for tracking implementing AC97 codec support in crosvm.  please use one of the many user forums instead if you guys want to discuss workarounds and things like Simple Protocol Player.
Cc: alexlau@chromium.org
Project Member

Comment 28 by bugdroid1@chromium.org, Jan 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/451f36db3914fb024a21a7322502a2540f62aef7

commit 451f36db3914fb024a21a7322502a2540f62aef7
Author: Dylan Reid <dgreid@chromium.org>
Date: Sun Jan 13 21:52:17 2019

Add the `audio_streams` crate

The `audio_streams` crate provides a basic interface for playing audio.
This will be used to enable playback to various audio subsystems such as
Alsa and cras. To start, an empty playback example `DummyStreamSource`
is provided.

BUG=781398
TEST=Included Dummy Stream tests and boot crosvm with ac97 using the
DummyStream for output.

Change-Id: I665a92b423a6570659dc5f6aeafbc5786ba2c2e2
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1402264
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>

[add] https://crrev.com/451f36db3914fb024a21a7322502a2540f62aef7/audio_streams/Cargo.toml
[add] https://crrev.com/451f36db3914fb024a21a7322502a2540f62aef7/audio_streams/src/audio_streams.rs
[add] https://crrev.com/451f36db3914fb024a21a7322502a2540f62aef7/audio_streams/README.md

Project Member

Comment 29 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/57f7870c6ef94b41f6014ca10f5e09a233ed47ca

commit 57f7870c6ef94b41f6014ca10f5e09a233ed47ca
Author: paulhsia <paulhsia@chromium.org>
Date: Mon Jan 14 08:39:03 2019

media-sound/audio_streams: Add cros_workon ebuild

Add ebuild for crate audio_streams, which provides a basic
interface for playing audio.

BUG=chromium:781398
BUG=chromium:916921
TEST=$ FEATURES=test emerge-eve media-sound/audio_streams
CQ-DEPEND=CL:1402264

Change-Id: I7f8b923fe2c742457ebc612d1cbf18d9154d9215
Reviewed-on: https://chromium-review.googlesource.com/1400329
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/57f7870c6ef94b41f6014ca10f5e09a233ed47ca/media-sound/audio_streams/audio_streams-9999.ebuild
[add] https://crrev.com/57f7870c6ef94b41f6014ca10f5e09a233ed47ca/media-sound/audio_streams/files/chromeos-version.sh

Project Member

Comment 30 by bugdroid1@chromium.org, Jan 19 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c6f4b9e64da61ff86cce337ae30583b6afde3767

commit c6f4b9e64da61ff86cce337ae30583b6afde3767
Author: paulhsia <paulhsia@chromium.org>
Date: Sat Jan 19 08:13:31 2019

dev-rust: Add ebuilds for byteorder and related crates

To support eclass migration for crosvm ebuild from crate to cros-rust

Since quickcheck and rand are crates in dev-dependencies, we added empty
crates for them.

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ emerge-eve dev-rust/byteorder
     in a clean chroot

Change-Id: Ife9f7f8a87ec2ac3c9376949bc9183f80494c8bb
Reviewed-on: https://chromium-review.googlesource.com/1421297
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: David Tolnay <dtolnay@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/c6f4b9e64da61ff86cce337ae30583b6afde3767/dev-rust/rand/Manifest
[add] https://crrev.com/c6f4b9e64da61ff86cce337ae30583b6afde3767/dev-rust/rand/rand-0.3.20.ebuild
[add] https://crrev.com/c6f4b9e64da61ff86cce337ae30583b6afde3767/dev-rust/byteorder/byteorder-1.1.0.ebuild
[add] https://crrev.com/c6f4b9e64da61ff86cce337ae30583b6afde3767/dev-rust/byteorder/Manifest
[add] https://crrev.com/c6f4b9e64da61ff86cce337ae30583b6afde3767/dev-rust/quickcheck/quickcheck-0.4.2.ebuild

Project Member

Comment 31 by bugdroid1@chromium.org, Jan 19 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/aaca62babcdb713d785e8fbf958443fd3358dd47

commit aaca62babcdb713d785e8fbf958443fd3358dd47
Author: paulhsia <paulhsia@chromium.org>
Date: Sat Jan 19 08:13:31 2019

dev-rust: Add ebuilds for protobuf and related crates

To support eclass migration for crosvm ebuild from crate to cros-rust

Since bytes is an optional crate, we added an empty crate for it.

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ emerge-eve protobuf
     in a clean chroot

Change-Id: Ia2347cd2ae008d9eb8c511575511ad6bd4c13a3a
Reviewed-on: https://chromium-review.googlesource.com/1421299
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: David Tolnay <dtolnay@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/aaca62babcdb713d785e8fbf958443fd3358dd47/dev-rust/protobuf/protobuf-1.4.3.ebuild
[add] https://crrev.com/aaca62babcdb713d785e8fbf958443fd3358dd47/dev-rust/bytes/bytes-0.4.11.ebuild
[add] https://crrev.com/aaca62babcdb713d785e8fbf958443fd3358dd47/dev-rust/protobuf/Manifest

Project Member

Comment 32 by bugdroid1@chromium.org, Jan 19 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a1e117a8d2add179ac15846a35e277b336be8268

commit a1e117a8d2add179ac15846a35e277b336be8268
Author: paulhsia <paulhsia@chromium.org>
Date: Sat Jan 19 08:13:32 2019

dev-rust: Add ebuilds for protoc-rust and related crates

To support eclass migration for crosvm ebuild from crate to cros-rust

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ emerge-eve dev-rust/protoc-rust
     from a clean chroot

Change-Id: Icb5c72c1e733b909d3cb2635cdf4a8086f030020
Reviewed-on: https://chromium-review.googlesource.com/1421300
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/a1e117a8d2add179ac15846a35e277b336be8268/dev-rust/protoc/protoc-1.4.3.ebuild
[add] https://crrev.com/a1e117a8d2add179ac15846a35e277b336be8268/dev-rust/protoc-rust/Manifest
[add] https://crrev.com/a1e117a8d2add179ac15846a35e277b336be8268/dev-rust/protoc-rust/protoc-rust-1.4.3.ebuild
[add] https://crrev.com/a1e117a8d2add179ac15846a35e277b336be8268/dev-rust/protoc/Manifest

Project Member

Comment 33 by bugdroid1@chromium.org, Jan 19 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/43a270f3248f29538f56fe298cb7bde62891bc71

commit 43a270f3248f29538f56fe298cb7bde62891bc71
Author: paulhsia <paulhsia@chromium.org>
Date: Sat Jan 19 08:13:32 2019

dev-rust: Add ebuilds for pkg-config and related crates

To support eclass migration for crosvm ebuild from crate to cros-rust

Since lazy_static is a crate used in pkg-config's dev-dependencies only, we
added an empty crate for it.

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ emerge-eve dev-rust/pkg-config
     in a clean chroot

Change-Id: I7f8d6df39254563618bb0c31705fd6276ec4fe5e
Reviewed-on: https://chromium-review.googlesource.com/1421301
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: David Tolnay <dtolnay@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/43a270f3248f29538f56fe298cb7bde62891bc71/dev-rust/lazy_static/lazy_static-1.2.0.ebuild
[add] https://crrev.com/43a270f3248f29538f56fe298cb7bde62891bc71/dev-rust/pkg-config/Manifest
[add] https://crrev.com/43a270f3248f29538f56fe298cb7bde62891bc71/dev-rust/pkg-config/pkg-config-0.3.11.ebuild

Project Member

Comment 34 by bugdroid1@chromium.org, Jan 19 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/48489cbf620fbc34da757c7ab0fbfbdb775787ea

commit 48489cbf620fbc34da757c7ab0fbfbdb775787ea
Author: paulhsia <paulhsia@chromium.org>
Date: Sat Jan 19 08:13:33 2019

dev-rust: Add ebuilds for num_cpus crates

To support eclass migration for crosvm ebuild from crate to
cros-rust

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ emerge-eve dev-rust/num_cpus
     in a clean chroot

Change-Id: I16f871ec5586e8a458831cc922c66bd0d6d1376b
Reviewed-on: https://chromium-review.googlesource.com/1421302
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: David Tolnay <dtolnay@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/48489cbf620fbc34da757c7ab0fbfbdb775787ea/dev-rust/num_cpus/Manifest
[add] https://crrev.com/48489cbf620fbc34da757c7ab0fbfbdb775787ea/dev-rust/num_cpus/num_cpus-1.9.0.ebuild

Project Member

Comment 35 by bugdroid, Today (16 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/b6d842fa56f0ccb9e5084d0e06100c53170d46f7

commit b6d842fa56f0ccb9e5084d0e06100c53170d46f7
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Support cros-rust version crosvm ebuild

To support eclass migration for crosvm ebuild from crate to cros-rust.
This CL need to be built with cros-rust version crosvm ebuild.

- Upgrage crate cc from 1.0.15 to 1.0.25.
- Change local tempdir version from 0.3.5 to 0.3.7 for ebuild
integration.
- Remove 9s directory since it's moved to platform2.

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ FEATURES=test emerge-eve crosvm
     in a clean chroot
CQ-DEPEND=CL:1421303

Change-Id: Iab615b555a51f8020e5efae1cc40ac6b54ea87f2
Reviewed-on: https://chromium-review.googlesource.com/1421237
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/x86_64/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/plugin_proto/Cargo.toml
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/main.rs
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/vsock.rs
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.lock
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/gpu_display/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/tempdir/Cargo.toml

Project Member

Comment 36 by bugdroid, Today (16 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/799ed9fbf429b82d395645d3d02accd218e05d8a

commit 799ed9fbf429b82d395645d3d02accd218e05d8a
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Migrate ebuild from crate.eclass to cros-rust.eclass

To support the flexibility of installing local crate, we need to let
crosvm's ebuild inherit cros-rust.eclass instead of crate.eclass.

BUG=chromium:781398
BUG=chromium:907520
TEST=Remove dev-rust packages by
     $ emerge-${BOARD} -Cav dev-rust/*
     And run
     $ FEATURES=test emerge-${BOARD} crosvm
CQ-DEPEND=CL:1421237

Change-Id: Ib9961d83a5f40b45541a9024d5ee391a3a31bc02
Reviewed-on: https://chromium-review.googlesource.com/1421303
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>

[modify] https://crrev.com/799ed9fbf429b82d395645d3d02accd218e05d8a/chromeos-base/crosvm/crosvm-9999.ebuild

Project Member

Comment 37 by bugdroid, Today (16 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/b6d842fa56f0ccb9e5084d0e06100c53170d46f7

commit b6d842fa56f0ccb9e5084d0e06100c53170d46f7
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Support cros-rust version crosvm ebuild

To support eclass migration for crosvm ebuild from crate to cros-rust.
This CL need to be built with cros-rust version crosvm ebuild.

- Upgrage crate cc from 1.0.15 to 1.0.25.
- Change local tempdir version from 0.3.5 to 0.3.7 for ebuild
integration.
- Remove 9s directory since it's moved to platform2.

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ FEATURES=test emerge-eve crosvm
     in a clean chroot
CQ-DEPEND=CL:1421303

Change-Id: Iab615b555a51f8020e5efae1cc40ac6b54ea87f2
Reviewed-on: https://chromium-review.googlesource.com/1421237
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/x86_64/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/plugin_proto/Cargo.toml
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/main.rs
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/vsock.rs
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.lock
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/gpu_display/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/tempdir/Cargo.toml

Project Member

Comment 38 by bugdroid, Today (16 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/799ed9fbf429b82d395645d3d02accd218e05d8a

commit 799ed9fbf429b82d395645d3d02accd218e05d8a
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Migrate ebuild from crate.eclass to cros-rust.eclass

To support the flexibility of installing local crate, we need to let
crosvm's ebuild inherit cros-rust.eclass instead of crate.eclass.

BUG=chromium:781398
BUG=chromium:907520
TEST=Remove dev-rust packages by
     $ emerge-${BOARD} -Cav dev-rust/*
     And run
     $ FEATURES=test emerge-${BOARD} crosvm
CQ-DEPEND=CL:1421237

Change-Id: Ib9961d83a5f40b45541a9024d5ee391a3a31bc02
Reviewed-on: https://chromium-review.googlesource.com/1421303
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>

[modify] https://crrev.com/799ed9fbf429b82d395645d3d02accd218e05d8a/chromeos-base/crosvm/crosvm-9999.ebuild

Project Member

Comment 39 by bugdroid, Today (16 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/b6d842fa56f0ccb9e5084d0e06100c53170d46f7

commit b6d842fa56f0ccb9e5084d0e06100c53170d46f7
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Support cros-rust version crosvm ebuild

To support eclass migration for crosvm ebuild from crate to cros-rust.
This CL need to be built with cros-rust version crosvm ebuild.

- Upgrage crate cc from 1.0.15 to 1.0.25.
- Change local tempdir version from 0.3.5 to 0.3.7 for ebuild
integration.
- Remove 9s directory since it's moved to platform2.

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ FEATURES=test emerge-eve crosvm
     in a clean chroot
CQ-DEPEND=CL:1421303

Change-Id: Iab615b555a51f8020e5efae1cc40ac6b54ea87f2
Reviewed-on: https://chromium-review.googlesource.com/1421237
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/x86_64/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/plugin_proto/Cargo.toml
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/main.rs
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/vsock.rs
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.lock
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/gpu_display/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/tempdir/Cargo.toml

Project Member

Comment 40 by bugdroid, Today (16 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/799ed9fbf429b82d395645d3d02accd218e05d8a

commit 799ed9fbf429b82d395645d3d02accd218e05d8a
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Migrate ebuild from crate.eclass to cros-rust.eclass

To support the flexibility of installing local crate, we need to let
crosvm's ebuild inherit cros-rust.eclass instead of crate.eclass.

BUG=chromium:781398
BUG=chromium:907520
TEST=Remove dev-rust packages by
     $ emerge-${BOARD} -Cav dev-rust/*
     And run
     $ FEATURES=test emerge-${BOARD} crosvm
CQ-DEPEND=CL:1421237

Change-Id: Ib9961d83a5f40b45541a9024d5ee391a3a31bc02
Reviewed-on: https://chromium-review.googlesource.com/1421303
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>

[modify] https://crrev.com/799ed9fbf429b82d395645d3d02accd218e05d8a/chromeos-base/crosvm/crosvm-9999.ebuild

Project Member

Comment 41 by bugdroid, Today (15 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/b6d842fa56f0ccb9e5084d0e06100c53170d46f7

commit b6d842fa56f0ccb9e5084d0e06100c53170d46f7
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Support cros-rust version crosvm ebuild

To support eclass migration for crosvm ebuild from crate to cros-rust.
This CL need to be built with cros-rust version crosvm ebuild.

- Upgrage crate cc from 1.0.15 to 1.0.25.
- Change local tempdir version from 0.3.5 to 0.3.7 for ebuild
integration.
- Remove 9s directory since it's moved to platform2.

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ FEATURES=test emerge-eve crosvm
     in a clean chroot
CQ-DEPEND=CL:1421303

Change-Id: Iab615b555a51f8020e5efae1cc40ac6b54ea87f2
Reviewed-on: https://chromium-review.googlesource.com/1421237
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/x86_64/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/plugin_proto/Cargo.toml
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/main.rs
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/vsock.rs
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.lock
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/gpu_display/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/tempdir/Cargo.toml

Project Member

Comment 42 by bugdroid, Today (15 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/799ed9fbf429b82d395645d3d02accd218e05d8a

commit 799ed9fbf429b82d395645d3d02accd218e05d8a
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Migrate ebuild from crate.eclass to cros-rust.eclass

To support the flexibility of installing local crate, we need to let
crosvm's ebuild inherit cros-rust.eclass instead of crate.eclass.

BUG=chromium:781398
BUG=chromium:907520
TEST=Remove dev-rust packages by
     $ emerge-${BOARD} -Cav dev-rust/*
     And run
     $ FEATURES=test emerge-${BOARD} crosvm
CQ-DEPEND=CL:1421237

Change-Id: Ib9961d83a5f40b45541a9024d5ee391a3a31bc02
Reviewed-on: https://chromium-review.googlesource.com/1421303
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>

[modify] https://crrev.com/799ed9fbf429b82d395645d3d02accd218e05d8a/chromeos-base/crosvm/crosvm-9999.ebuild

Project Member

Comment 43 by bugdroid, Today (15 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/b6d842fa56f0ccb9e5084d0e06100c53170d46f7

commit b6d842fa56f0ccb9e5084d0e06100c53170d46f7
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Support cros-rust version crosvm ebuild

To support eclass migration for crosvm ebuild from crate to cros-rust.
This CL need to be built with cros-rust version crosvm ebuild.

- Upgrage crate cc from 1.0.15 to 1.0.25.
- Change local tempdir version from 0.3.5 to 0.3.7 for ebuild
integration.
- Remove 9s directory since it's moved to platform2.

BUG=chromium:781398
BUG=chromium:907520
TEST=Run $ FEATURES=test emerge-eve crosvm
     in a clean chroot
CQ-DEPEND=CL:1421303

Change-Id: Iab615b555a51f8020e5efae1cc40ac6b54ea87f2
Reviewed-on: https://chromium-review.googlesource.com/1421237
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/x86_64/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/plugin_proto/Cargo.toml
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/main.rs
[delete] https://crrev.com/284fcac560ea033f2d10e873cd498bb157c74775/9s/src/vsock.rs
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.lock
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/gpu_display/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/Cargo.toml
[modify] https://crrev.com/b6d842fa56f0ccb9e5084d0e06100c53170d46f7/tempdir/Cargo.toml

Project Member

Comment 44 by bugdroid, Today (15 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/799ed9fbf429b82d395645d3d02accd218e05d8a

commit 799ed9fbf429b82d395645d3d02accd218e05d8a
Author: paulhsia <paulhsia@chromium.org>
Date: Wed Jan 23 00:53:13 2019

crosvm: Migrate ebuild from crate.eclass to cros-rust.eclass

To support the flexibility of installing local crate, we need to let
crosvm's ebuild inherit cros-rust.eclass instead of crate.eclass.

BUG=chromium:781398
BUG=chromium:907520
TEST=Remove dev-rust packages by
     $ emerge-${BOARD} -Cav dev-rust/*
     And run
     $ FEATURES=test emerge-${BOARD} crosvm
CQ-DEPEND=CL:1421237

Change-Id: Ib9961d83a5f40b45541a9024d5ee391a3a31bc02
Reviewed-on: https://chromium-review.googlesource.com/1421303
Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>
Tested-by: Chih-Yang Hsia <paulhsia@chromium.org>
Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>

[modify] https://crrev.com/799ed9fbf429b82d395645d3d02accd218e05d8a/chromeos-base/crosvm/crosvm-9999.ebuild

Sign in to add a comment