New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781392 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 1
Type: Feature



Sign in to add a comment

[Cronet] Provide white list of servers which could use QUIC with Cronet.

Project Member Reported by mef@chromium.org, Nov 3 2017

Issue description

With QUIC being an experimental protocol it may be useful to enable / disable support of QUIC for connection with particular host.

The existing addQuicHint API does suggest that QUIC can be used to connect to the host, but without it QUIC support is discovered automatically via alt-svc response headers.

 
Owner: mef@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by rch@chromium.org, Nov 10 2017

Labels: -Pri-3 Pri-1
Owner: wangyix@chromium.org
wangyix: can you take a look at this? This is fallout from the P0 bug.

We had a whitelist back in https://codereview.chromium.org/1580583002 though we subsequently removed it. In the new version, we'd only used the explicit whitelist, not the IsGooglePinnedHost() check.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10f477ed2ba08c3bc58df78d0571f126748747ac

commit 10f477ed2ba08c3bc58df78d0571f126748747ac
Author: Yixin Wang <wangyix@chromium.org>
Date: Tue Nov 21 04:20:20 2017

Allow QUIC whitelist to be set via Finch or Cronet experiments

If whitelist is specified and non-empty, QUIC can only be spoken to hosts in the whitelist.

Bug:  781392 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2d48262c5449d232bb73eebc7a1683d18e7f8954
Reviewed-on: https://chromium-review.googlesource.com/772826
Commit-Queue: Yixin Wang <wangyix@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518108}
[modify] https://crrev.com/10f477ed2ba08c3bc58df78d0571f126748747ac/components/cronet/url_request_context_config.cc
[modify] https://crrev.com/10f477ed2ba08c3bc58df78d0571f126748747ac/components/cronet/url_request_context_config_unittest.cc
[modify] https://crrev.com/10f477ed2ba08c3bc58df78d0571f126748747ac/components/network_session_configurator/browser/network_session_configurator.cc
[modify] https://crrev.com/10f477ed2ba08c3bc58df78d0571f126748747ac/components/network_session_configurator/browser/network_session_configurator_unittest.cc
[modify] https://crrev.com/10f477ed2ba08c3bc58df78d0571f126748747ac/net/http/http_network_session.h
[modify] https://crrev.com/10f477ed2ba08c3bc58df78d0571f126748747ac/net/http/http_network_session_peer.cc
[modify] https://crrev.com/10f477ed2ba08c3bc58df78d0571f126748747ac/net/http/http_network_session_peer.h
[modify] https://crrev.com/10f477ed2ba08c3bc58df78d0571f126748747ac/net/http/http_stream_factory_impl_job_controller.cc
[modify] https://crrev.com/10f477ed2ba08c3bc58df78d0571f126748747ac/net/http/http_stream_factory_impl_job_controller.h
[modify] https://crrev.com/10f477ed2ba08c3bc58df78d0571f126748747ac/net/http/http_stream_factory_impl_job_controller_unittest.cc
[modify] https://crrev.com/10f477ed2ba08c3bc58df78d0571f126748747ac/net/quic/chromium/quic_network_transaction_unittest.cc

Status: Fixed (was: Assigned)

Comment 5 by rch@google.com, Nov 21 2017

Has go/cronet-experimental-options been updated to reflect the new options?
rch@: yes, it has been updated.

Sign in to add a comment