New issue
Advanced search Search tips

Issue 781352 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 750779



Sign in to add a comment

Migrate off deprecated MessageLoop::*Nestable* APIs

Project Member Reported by gab@chromium.org, Nov 3 2017

Issue description

Migrate MessageLoop::ScopedNestableTaskAllower usage to RunLoop::Type::kNestableTasksAllowed where a RunLoop is used.

Then convert remaining usage to a native/system nested loop specific allowance.

Also remove MessageLoop::NestableTasksAllowed() from the public API when it's just a fact that we don't nest by default.
 

Comment 1 by gab@chromium.org, Nov 3 2017

First script (ran over every file in the codebase), affects patterns in which a RunLoop with a named variable shares the same scope as a ScopedNestableTaskAllower:


import re
import refactor_lib

def Fix(file_path):
  content = refactor_lib.ReadFile(file_path)

  regex = re.compile(r''
                      # Capture optional preceding comment.
                     r'((\n[ ]*//.*)*)'
                      # Main point of interest.
                     r'\n.*MessageLoop::ScopedNestableTaskAllower [a-z_]+'
                      # Also capture whatever is in the brackets of the ScopedNestableTaskAllower constructor call.
                     r'\(([^()]*|\([^()]*\))+\);')

  run_loop_regex = re.compile(r'\n.*RunLoop [a-z_]*;')

  # Search/replace one at a time so that indices are always up-to-date.
  match = regex.search(content)
  if not match:
    return False

  updated = False
  while match:
    scope_start = content.rfind('{', 0, match.start())
    scope_end = content.find('}', match.end())

    run_loop_match = run_loop_regex.search(content[scope_start:scope_end])
    if not run_loop_match:
      print 'No RunLoop in scope, skipping file : %s:%d' % (file_path, match.start())
      return False

    run_loop_match_start = scope_start + run_loop_match.start()
    run_loop_match_end = scope_start + run_loop_match.end()

    if run_loop_regex.search(content[run_loop_match_end:scope_end]):
      print 'Error: multiple RunLoops in scope : %s:%d' % (file_path, match.start())
      return False

    # Note that the operations below are performed from highest to lowest index hence the
    # indices do not need to be shifted after each op :)

    # Insert arg right before the semi-colon
    arg_insert_index = run_loop_match_end - 1
    run_loop_argument = '('
    run_loop_argument += 'base::' if content.rfind('namespace base {', 0, run_loop_match_start) == -1 else ''
    run_loop_argument += 'RunLoop::Type::kNestableTasksAllowed'
    run_loop_argument += ')'

    # Save comment for later as moving it first may affect indices.
    comment = content[match.start(1):match.end(1)]

    # Remove ScopedNestableTaskAllower first if it comes after the RunLoop.
    if match.start() > run_loop_match_start:
      content = content[:match.start()] + content[match.end():]

    # Insert arg
    content = content[:arg_insert_index] + run_loop_argument + content[arg_insert_index:]

    # Bring any comment justifying the use of ScopedNestableTaskAllower over.
    content = content[:run_loop_match_start] + comment + content[run_loop_match_start:]

    # Remove ScopedNestableTaskAllower last if it preceded the RunLoop.
    if match.start() < run_loop_match_start:
      content = content[:match.start()] + content[match.end():]

    updated = True

    # Repeat
    match = regex.search(content)

  if not updated:
    return False

  # Remove message_loop.h if that was the last usage of it in this file.
  content = refactor_lib.RemoveInclude(content, 'base/message_loop/message_loop.h', ["MessageLoop"])

  # Write updated file
  refactor_lib.WriteFile(file_path, content)

  return True

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8627cc53358d8391dac922f133157785098b066

commit a8627cc53358d8391dac922f133157785098b066
Author: Gabriel Charette <gab@chromium.org>
Date: Tue Nov 07 23:25:56 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed when used in same scope as a RunLoop variable in content/network

Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=xunjieli@chromium.org

Bug: 781352
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I3cec1689fc0b8928a33def1e0adb55f7f7f508a3
Reviewed-on: https://chromium-review.googlesource.com/757618
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514646}
[modify] https://crrev.com/a8627cc53358d8391dac922f133157785098b066/content/network/proxy_resolver_factory_mojo_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccecc13ea35081242c7664935ca42d7f57e03e9c

commit ccecc13ea35081242c7664935ca42d7f57e03e9c
Author: Gabriel Charette <gab@chromium.org>
Date: Tue Nov 07 23:45:12 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed when used in same scope as a RunLoop variable.

Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=rockot@chromium.org

Bug: 781352
Change-Id: I78da294c2a5c09f41ae1598839b947ce8c418a9f
Reviewed-on: https://chromium-review.googlesource.com/757234
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514652}
[modify] https://crrev.com/ccecc13ea35081242c7664935ca42d7f57e03e9c/services/service_manager/public/cpp/service_test.cc
[modify] https://crrev.com/ccecc13ea35081242c7664935ca42d7f57e03e9c/services/service_manager/tests/connect/connect_test_package.cc
[modify] https://crrev.com/ccecc13ea35081242c7664935ca42d7f57e03e9c/services/service_manager/tests/lifecycle/parent.cc
[modify] https://crrev.com/ccecc13ea35081242c7664935ca42d7f57e03e9c/services/service_manager/tests/shutdown/shutdown_client_app.cc
[modify] https://crrev.com/ccecc13ea35081242c7664935ca42d7f57e03e9c/services/service_manager/tests/util.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6412be800df4c5401b8f9720ecf7b3d4655a7248

commit 6412be800df4c5401b8f9720ecf7b3d4655a7248
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Nov 08 14:10:46 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed when used in same scope as a RunLoop variable.

Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=sadrul@chromium.org

Bug: 781352
Change-Id: I198a536517041fee331e090de5d4ce6f6d19cefc
Reviewed-on: https://chromium-review.googlesource.com/757642
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514815}
[modify] https://crrev.com/6412be800df4c5401b8f9720ecf7b3d4655a7248/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/6412be800df4c5401b8f9720ecf7b3d4655a7248/ui/views/widget/widget_interactive_uitest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b461c707533e11699e63acd8f64b428661d327dd

commit b461c707533e11699e63acd8f64b428661d327dd
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Nov 08 15:39:46 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed when used in same scope as a RunLoop variable.

Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=dgozman@chromium.org

Bug: 781352
Change-Id: I9b417ecb77a2c858d987f61fbd772b6b24f0f050
Reviewed-on: https://chromium-review.googlesource.com/757585
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514839}
[modify] https://crrev.com/b461c707533e11699e63acd8f64b428661d327dd/content/renderer/devtools/devtools_agent.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8cfe8f16bc980019e729d32050e56b7b4676a2d

commit d8cfe8f16bc980019e729d32050e56b7b4676a2d
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Nov 08 18:15:03 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed when used in same scope as a RunLoop variable in /components/bookmarks

Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

Bug: 781352
Change-Id: I8b5665a400b088ab2b8d3b09dae46c726fe12013
Reviewed-on: https://chromium-review.googlesource.com/757736
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514885}
[modify] https://crrev.com/d8cfe8f16bc980019e729d32050e56b7b4676a2d/components/bookmarks/test/bookmark_test_helpers.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43b8bf31aa9cf7eaf3bbb61c9df807a0eaf32f6f

commit 43b8bf31aa9cf7eaf3bbb61c9df807a0eaf32f6f
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Nov 08 20:24:43 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed when used in same scope as a RunLoop variable.

Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=tsepez@chromium.org

Bug: 781352
Change-Id: I1eba95f6d8329b772a81081ad6b9e5a7cd2a6aed
Reviewed-on: https://chromium-review.googlesource.com/757641
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514924}
[modify] https://crrev.com/43b8bf31aa9cf7eaf3bbb61c9df807a0eaf32f6f/ipc/ipc_mojo_perftest.cc
[modify] https://crrev.com/43b8bf31aa9cf7eaf3bbb61c9df807a0eaf32f6f/ipc/ipc_sync_channel.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e606536f29200c6cfda6fcab409be6b8bd095be9

commit e606536f29200c6cfda6fcab409be6b8bd095be9
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Nov 08 22:17:50 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /base

This pass focuses on ML::SNTA in same scope as RunLoop variable
Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=danakj@chromium.org

Bug: 781352
Change-Id: I57ec28d1a9ccc5891f25ac5df8d68456b561363f
Reviewed-on: https://chromium-review.googlesource.com/759076
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514967}
[modify] https://crrev.com/e606536f29200c6cfda6fcab409be6b8bd095be9/base/message_loop/message_pump_libevent_unittest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37d114bc06e1c65ecd7b413ca02854c6259d280a

commit 37d114bc06e1c65ecd7b413ca02854c6259d280a
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Nov 08 22:56:32 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc

This pass focuses on ML::SNTA in same scope as RunLoop variable
Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=erg@chromium.org

Bug: 781352
Change-Id: I5e5fb2671cabc964a68d4c8e70f90d442e0f4eb2
Reviewed-on: https://chromium-review.googlesource.com/758575
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514985}
[modify] https://crrev.com/37d114bc06e1c65ecd7b413ca02854c6259d280a/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa0a89fc8e6e2ed2bdf59d1c3e19fdd5f400acec

commit aa0a89fc8e6e2ed2bdf59d1c3e19fdd5f400acec
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Nov 08 23:01:40 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /content/browser

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().Run()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=boliu@chromium.org

Bug: 781352
Change-Id: I03737ca2c1e31a2bbcdd6b587e7e5ecff5d4959f
Reviewed-on: https://chromium-review.googlesource.com/758607
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514988}
[modify] https://crrev.com/aa0a89fc8e6e2ed2bdf59d1c3e19fdd5f400acec/content/browser/browser_associated_interface_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48245857c76ab3c34197b9c1cf7de8fa6093e0d5

commit 48245857c76ab3c34197b9c1cf7de8fa6093e0d5
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Nov 08 23:23:12 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /ui/aura

This pass focuses on ML::SNTA in same scope as RunLoop variable
Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=sadrul@chromium.org

Bug: 781352
Change-Id: I218f0fbb163610ced4130cccd22ffa800981e253
Reviewed-on: https://chromium-review.googlesource.com/759077
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514998}
[modify] https://crrev.com/48245857c76ab3c34197b9c1cf7de8fa6093e0d5/ui/aura/window_event_dispatcher_unittest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9ca82fecf4d1059ae558e7f259ce23abdbea896

commit c9ca82fecf4d1059ae558e7f259ce23abdbea896
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Nov 08 23:35:53 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /ui/base/x

This pass focuses on ML::SNTA in same scope as RunLoop variable
Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=sadrul@chromium.org

Bug: 781352
Change-Id: I6516d971c26c54ca5dff3c64361d5ba692764896
Reviewed-on: https://chromium-review.googlesource.com/758927
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515004}
[modify] https://crrev.com/c9ca82fecf4d1059ae558e7f259ce23abdbea896/ui/base/x/selection_requestor.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7586bbb09f56900e969562c1c0c93a31d40b0a6c

commit 7586bbb09f56900e969562c1c0c93a31d40b0a6c
Author: Gabriel Charette <gab@chromium.org>
Date: Thu Nov 09 00:48:19 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /ppapi/proxy

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().Run()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=piman@chromium.org

Bug: 781352
Change-Id: I3900a4cb18da2d78bf6815a582bc69460fe18423
Reviewed-on: https://chromium-review.googlesource.com/758659
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515037}
[modify] https://crrev.com/7586bbb09f56900e969562c1c0c93a31d40b0a6c/ppapi/proxy/ppb_testing_proxy.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63569fdc11fe39d642f21afb4cf71c3bc336db8e

commit 63569fdc11fe39d642f21afb4cf71c3bc336db8e
Author: Gabriel Charette <gab@chromium.org>
Date: Thu Nov 09 01:19:21 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /mojo

This pass focuses on ML::SNTA in same scope as RunLoop variable
Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=jam@chromium.org

Bug: 781352
Change-Id: I2c2c6cb8f19d5c3163c0a0012df38d67822dbf42
Reviewed-on: https://chromium-review.googlesource.com/758930
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515046}
[modify] https://crrev.com/63569fdc11fe39d642f21afb4cf71c3bc336db8e/mojo/public/cpp/bindings/tests/connector_unittest.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fb330ab50bc2097c3aa59a92f4b6bd9a3d50b45

commit 0fb330ab50bc2097c3aa59a92f4b6bd9a3d50b45
Author: Gabriel Charette <gab@chromium.org>
Date: Thu Nov 09 01:59:06 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /chrome/browser/sessions

This pass focuses on ML::SNTA in same scope as RunLoop variable
Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 781352
Change-Id: Ie28ff95630b68ff5dc11c920f652fd721920af63
Reviewed-on: https://chromium-review.googlesource.com/758929
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515057}
[modify] https://crrev.com/0fb330ab50bc2097c3aa59a92f4b6bd9a3d50b45/chrome/browser/sessions/session_restore.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6040439f48b8828263f1588f5bd6f93203666f26

commit 6040439f48b8828263f1588f5bd6f93203666f26
Author: Gabriel Charette <gab@chromium.org>
Date: Thu Nov 09 15:52:40 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /headless

This pass focuses on ML::SNTA in same scope as RunLoop variable
Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=skyostil@chromium.org

Bug: 781352
Change-Id: I80d1a181146b7134b86dde70b41c18f5af954ebf
Reviewed-on: https://chromium-review.googlesource.com/758928
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515177}
[modify] https://crrev.com/6040439f48b8828263f1588f5bd6f93203666f26/headless/lib/frame_id_browsertest.cc
[modify] https://crrev.com/6040439f48b8828263f1588f5bd6f93203666f26/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/6040439f48b8828263f1588f5bd6f93203666f26/headless/lib/headless_web_contents_browsertest.cc
[modify] https://crrev.com/6040439f48b8828263f1588f5bd6f93203666f26/headless/public/util/generic_url_request_job.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abd5d9129f7cc740ff4dadd29ee9868d19f80feb

commit abd5d9129f7cc740ff4dadd29ee9868d19f80feb
Author: Gabriel Charette <gab@chromium.org>
Date: Thu Nov 09 20:41:33 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /ash/drag_drop

This pass focuses on ML::SNTA in same scope as RunLoop variable
Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=mfomitchev@chromium.org

Bug: 781352
Change-Id: I4b8d600da667c5222b589da0d5881f8c6285200b
Reviewed-on: https://chromium-review.googlesource.com/758574
Reviewed-by: Mikhail Fomitchev <mfomitchev@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515278}
[modify] https://crrev.com/abd5d9129f7cc740ff4dadd29ee9868d19f80feb/ash/drag_drop/drag_drop_controller.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c93667a9dd224f7d3b9511a94fcaa591682a45d

commit 9c93667a9dd224f7d3b9511a94fcaa591682a45d
Author: Gabriel Charette <gab@chromium.org>
Date: Thu Nov 09 22:57:30 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /chrome/browser/sync

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().Run()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=zea@chromium.org

Bug: 781352
Change-Id: Ic7a821c637a60a668f897d6bfacdbe323de74537
Reviewed-on: https://chromium-review.googlesource.com/758658
Commit-Queue: Nicolas Zea <zea@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515334}
[modify] https://crrev.com/9c93667a9dd224f7d3b9511a94fcaa591682a45d/chrome/browser/sync/test/integration/status_change_checker.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5ca94a86b5f4571a311f5b5fd0d1df3b3a52b29

commit c5ca94a86b5f4571a311f5b5fd0d1df3b3a52b29
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Nov 10 01:07:46 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /content/renderer/pepper

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().Run()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=raymes@chromium.org

Bug: 781352
Change-Id: I1e5c95734c96387029b4a5818fe21c0dbc0d581c
Reviewed-on: https://chromium-review.googlesource.com/758881
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515397}
[modify] https://crrev.com/c5ca94a86b5f4571a311f5b5fd0d1df3b3a52b29/content/renderer/pepper/plugin_module.cc
[modify] https://crrev.com/c5ca94a86b5f4571a311f5b5fd0d1df3b3a52b29/content/renderer/pepper/ppb_flash_message_loop_impl.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37a608f14111634de804cd6c90df1d4d5bf02b29

commit 37a608f14111634de804cd6c90df1d4d5bf02b29
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Nov 10 14:40:22 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed when used in same scope as a RunLoop variable in /chromecast

Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=lcwu@chromium.org

Bug: 781352
Change-Id: I75739d35febd7596b9526b849d3b2dedb7f0df98
Reviewed-on: https://chromium-review.googlesource.com/757072
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515551}
[modify] https://crrev.com/37a608f14111634de804cd6c90df1d4d5bf02b29/chromecast/browser/cast_media_blocker_browsertest.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecc3087b9de4f9b328d71d6171588136a3bdddce

commit ecc3087b9de4f9b328d71d6171588136a3bdddce
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Nov 10 19:56:23 2017

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /chrome/browser/printing

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().Run()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=dpapad@chromium.org

Bug: 781352
Change-Id: I0877a474b8af3e8422ca58af390dc8f4a49d89ea
Reviewed-on: https://chromium-review.googlesource.com/758657
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515650}
[modify] https://crrev.com/ecc3087b9de4f9b328d71d6171588136a3bdddce/chrome/browser/printing/print_job.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af007379596258a85df3343f86d07438fb207fc8

commit af007379596258a85df3343f86d07438fb207fc8
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Apr 04 18:48:04 2018

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /base

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().RunUntilIdle()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Includes should have been stripped if the was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=thakis@chromium.org

Bug: 781352
Change-Id: I0cb8cd0bbe6161bc706a5fc81d73c1d41ddcc775
Reviewed-on: https://chromium-review.googlesource.com/995974
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548141}
[modify] https://crrev.com/af007379596258a85df3343f86d07438fb207fc8/base/message_loop/message_loop_unittest.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c7b1aeb641d75a6820621202e024a247734d237

commit 7c7b1aeb641d75a6820621202e024a247734d237
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Apr 04 19:45:54 2018

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /content/browser/renderer_host/media

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().RunUntilIdle()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Includes should have been stripped if the was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=xhwang@chromium.org

Bug: 781352
Change-Id: Iae32d4a5cbb177de34391d8cf99e423e4d465cdb
Reviewed-on: https://chromium-review.googlesource.com/995921
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548161}
[modify] https://crrev.com/7c7b1aeb641d75a6820621202e024a247734d237/content/browser/renderer_host/media/audio_output_delegate_impl_unittest.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c7b1aeb641d75a6820621202e024a247734d237

commit 7c7b1aeb641d75a6820621202e024a247734d237
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Apr 04 19:45:54 2018

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /content/browser/renderer_host/media

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().RunUntilIdle()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Includes should have been stripped if the was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=xhwang@chromium.org

Bug: 781352
Change-Id: Iae32d4a5cbb177de34391d8cf99e423e4d465cdb
Reviewed-on: https://chromium-review.googlesource.com/995921
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548161}
[modify] https://crrev.com/7c7b1aeb641d75a6820621202e024a247734d237/content/browser/renderer_host/media/audio_output_delegate_impl_unittest.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54aa64354f9b9394e95003f7f43725f2a511e821

commit 54aa64354f9b9394e95003f7f43725f2a511e821
Author: Gabriel Charette <gab@chromium.org>
Date: Thu Apr 05 14:03:34 2018

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /net

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().RunUntilIdle()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Includes should have been stripped if the was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=rsleevi@chromium.org

Bug: 781352
Change-Id: Ieef9ec8a22e3c7451a27124b447883db7ff3f500
Reviewed-on: https://chromium-review.googlesource.com/995975
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548412}
[modify] https://crrev.com/54aa64354f9b9394e95003f7f43725f2a511e821/net/socket/transport_client_socket_pool_unittest.cc

Project Member

Comment 27 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/715567d4e612619024a3bcdd676c0e9f8a13916a

commit 715567d4e612619024a3bcdd676c0e9f8a13916a
Author: Gabriel Charette <gab@chromium.org>
Date: Thu Apr 05 22:40:45 2018

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /content/test/renderer_audio_output_stream_factory_context_impl_unittest.cc

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().RunUntilIdle()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Includes should have been stripped if the was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=miu@chromium.org

Bug: 781352
Change-Id: Icf40891ff0b5b9ef22e588e65104ff70b55b2047
Reviewed-on: https://chromium-review.googlesource.com/995919
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548594}
[modify] https://crrev.com/715567d4e612619024a3bcdd676c0e9f8a13916a/content/test/renderer_audio_output_stream_factory_context_impl_unittest.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e044d657b9e11051954b64644b2357dff4ef0c2

commit 7e044d657b9e11051954b64644b2357dff4ef0c2
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Apr 06 00:37:44 2018

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /content/browser/service_worker

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().RunUntilIdle()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Includes should have been stripped if the was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=nhiroki@chromium.org

Bug: 781352
Change-Id: Ia1793866f9ebdf502732dcd49861bf3b80c29894
Reviewed-on: https://chromium-review.googlesource.com/995973
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548622}
[modify] https://crrev.com/7e044d657b9e11051954b64644b2357dff4ef0c2/content/browser/service_worker/service_worker_job_unittest.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c1128c7274b092f95a7f5b78520bf52d344ff1c

commit 7c1128c7274b092f95a7f5b78520bf52d344ff1c
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Apr 06 21:28:37 2018

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /chrome/service

This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().RunUntilIdle()
Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1
which focused on RunLoops with a variable name.

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed. If there was a comment above the
MessageLoop::ScopedNestableTaskAllower, it should have been moved
alongside the augmented RunLoop.

Includes should have been stripped if the was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=scottbyer@chromium.org

Bug: 781352
Change-Id: Icd144a3323e761d8ca80a0e42d3ea8c886db5188
Reviewed-on: https://chromium-review.googlesource.com/995920
Reviewed-by: Scott Byer <scottbyer@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548935}
[modify] https://crrev.com/7c1128c7274b092f95a7f5b78520bf52d344ff1c/chrome/service/service_ipc_server_unittest.cc

Project Member

Comment 30 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fbf977ad56a0c9c3ba4e9bce049a66a137c4ce8

commit 5fbf977ad56a0c9c3ba4e9bce049a66a137c4ce8
Author: Gabriel Charette <gab@chromium.org>
Date: Tue Apr 17 05:14:12 2018

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /third_party/blink/renderer/platform/scheduler

This is another scripted pass done by a slightly modified version of
https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which
has a better notion of "scope".

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed.

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=altimin@chromium.org

Bug: 781352
Change-Id: I471d4462277bf67332939a1cfce7f6f17d642cc7
Reviewed-on: https://chromium-review.googlesource.com/1013214
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551250}
[modify] https://crrev.com/5fbf977ad56a0c9c3ba4e9bce049a66a137c4ce8/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl_unittest.cc
[modify] https://crrev.com/5fbf977ad56a0c9c3ba4e9bce049a66a137c4ce8/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc

Project Member

Comment 31 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb05222e3ee023a08f9c914cda47dddfbf4261c6

commit eb05222e3ee023a08f9c914cda47dddfbf4261c6
Author: Gabriel Charette <gab@chromium.org>
Date: Tue Apr 17 05:14:38 2018

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /third_party/blink/renderer/platform/scheduler/child

This is another scripted pass done by a slightly modified version of
https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which
has a better notion of "scope".

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed.

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=alexclarke@chromium.org

Bug: 781352
Change-Id: I3ffef78836b7c4ffe22be0bc8043c39d9397729f
Reviewed-on: https://chromium-review.googlesource.com/1013216
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551251}
[modify] https://crrev.com/eb05222e3ee023a08f9c914cda47dddfbf4261c6/third_party/blink/renderer/platform/scheduler/child/idle_helper_unittest.cc

Project Member

Comment 32 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad1a78349f6c91238f1b73534d1bb8f56af786a5

commit ad1a78349f6c91238f1b73534d1bb8f56af786a5
Author: Gabriel Charette <gab@chromium.org>
Date: Tue Apr 17 14:33:02 2018

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /content/browser/site_per_process_browsertest.cc

This is another scripted pass done by a slightly modified version of
https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which
has a better notion of "scope".

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed.

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=kenrb@chromium.org

Bug: 781352
Change-Id: Ie0c1d1908812adc327f0777d552c7e4c97433d80
Reviewed-on: https://chromium-review.googlesource.com/1014781
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551323}
[modify] https://crrev.com/ad1a78349f6c91238f1b73534d1bb8f56af786a5/content/browser/site_per_process_browsertest.cc

Project Member

Comment 33 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd7f88c230b7ae7bb05c3f435f20bab1bdf99996

commit fd7f88c230b7ae7bb05c3f435f20bab1bdf99996
Author: Gabriel Charette <gab@chromium.org>
Date: Tue Apr 17 21:47:18 2018

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /headless

This is another scripted pass done by a slightly modified version of
https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which
has a better notion of "scope".

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed.

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=rvera@chromium.org

Bug: 781352
Change-Id: I5429418614b13b654af86c4764ac1c9066a21f95
Reviewed-on: https://chromium-review.googlesource.com/1014780
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551485}
[modify] https://crrev.com/fd7f88c230b7ae7bb05c3f435f20bab1bdf99996/headless/test/headless_render_test.cc

Project Member

Comment 34 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c92fdcdd769c9beaee5bbb9561376e0fd2532ffe

commit c92fdcdd769c9beaee5bbb9561376e0fd2532ffe
Author: Gabriel Charette <gab@chromium.org>
Date: Tue Apr 17 22:39:08 2018

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /ui/aura

This is another scripted pass done by a slightly modified version of
https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which
has a better notion of "scope".

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed.

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 781352
Change-Id: Ide6e641f8e9fed673bbf641074f33a05d238735a
Reviewed-on: https://chromium-review.googlesource.com/1014782
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551508}
[modify] https://crrev.com/c92fdcdd769c9beaee5bbb9561376e0fd2532ffe/ui/aura/mus/drag_drop_controller_mus.cc

Project Member

Comment 35 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/867f0910e006ebca81db347849eb47159eec9902

commit 867f0910e006ebca81db347849eb47159eec9902
Author: Gabriel Charette <gab@chromium.org>
Date: Thu Apr 19 21:59:55 2018

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /ash/wm

This is another scripted pass done by a slightly modified version of
https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which
has a better notion of "scope".

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed.

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=flackr@chromium.org

Bug: 781352
Change-Id: Ica51fdb505201c8f1944b160ef6dba8553b0c338
Reviewed-on: https://chromium-review.googlesource.com/1013215
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552179}
[modify] https://crrev.com/867f0910e006ebca81db347849eb47159eec9902/ash/wm/toplevel_window_event_handler.cc

Project Member

Comment 36 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d258c5155b1bb1ca893ee6f86345c341bb6d98f4

commit d258c5155b1bb1ca893ee6f86345c341bb6d98f4
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Apr 20 00:50:45 2018

Migrate MessageLoop::ScopedNestableTaskAllower usage to MessageLoopCurrent

And use the new argument-less constructor to avoid being redundant.

R=altimin@chromium.org
TBR=thestig@chromium.org

Bug: 781352, 825327
Change-Id: I57a0bd50934f402ec24409fa4b315bafec83bd7f
Reviewed-on: https://chromium-review.googlesource.com/1020288
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552221}
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/base/message_loop/message_loop.h
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/base/message_loop/message_loop_unittest.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/base/message_loop/message_pump_mac_unittest.mm
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/chrome/browser/chromeos/policy/user_network_configuration_updater_factory_browsertest.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/chrome/browser/printing/print_view_manager_base.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop_cocoa.mm
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/chrome/browser/ui/cocoa/first_run_dialog.mm
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/chrome/browser/ui/views/bookmarks/bookmark_drag_drop_views.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/content/browser/frame_host/popup_menu_helper_mac.mm
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/content/browser/renderer_host/render_widget_host_view_browsertest.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/content/browser/web_contents/web_contents_view_mac.mm
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/content/public/test/browser_test_base.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/content/public/test/test_utils.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/content/renderer/dom_serializer_browsertest.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/headless/test/headless_browser_test.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/headless/test/headless_render_test.h
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/net/base/file_stream_unittest.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/printing/printing_context_system_dialog_win.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/services/service_manager/tests/connect/connect_test_app.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/third_party/blink/renderer/platform/scheduler/DEPS
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl_unittest.cc
[modify] https://crrev.com/d258c5155b1bb1ca893ee6f86345c341bb6d98f4/ui/views/win/hwnd_message_handler.cc

Sign in to add a comment