Issue metadata
Sign in to add a comment
|
Login.ConsumerNewUsersAllowed Has Bad Construction Parameters |
||||||||||||||||||||||||
Issue descriptionChrome Version: HEAD OS: ALL The Login.ConsumerNewUsersAllowed histogram is being constructed with bad parameters. I couldn't find where this is created in the code but a debug build might expose the exact problem. The check is here: https://cs.chromium.org/chromium/src/base/metrics/histogram.cc?rcl=d10aadd8b3db83273bdf5748c7f216910d7d0e14&l=396 You can see this getting counted under UMA here: https://uma.googleplex.com/p/chrome/histograms/?endDate=latest&dayCount=28&histograms=Histogram.BadConstructionArguments&fixupData=true&showMax=true&filters=channel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
,
Nov 3 2017
The histogram is defined in platform2/login_manager/login_metrics.cc.
void LoginMetrics::SendConsumerAllowsNewUsers(bool allowed) {
int uma_code = allowed ? ANY_USER_ALLOWED : ONLY_WHITELISTED_ALLOWED;
metrics_lib_.SendEnumToUMA(kLoginConsumerAllowsNewUsersMetric, uma_code, 2);
}
enum AllowedUsersState { ANY_USER_ALLOWED = 0, ONLY_WHITELISTED_ALLOWED = 1 };
Looks right to me.
Looking closer, I see:
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/687214
which seems to have fixed it in late September.
As near as I can tell (maybe I'm looking in the wrong place), ChromeOS hasn't pushed a new release since that change was submitted.
,
Nov 9 2017
Oh, my apologies. I didn't realize I had previously reported this. Sorry.
,
Jun 29 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bcwh...@chromium.org
, Nov 3 2017