Tests using CommandLineInitRule mysteriously pass |
|||
Issue descriptionCommandLineInitRule currently doesn't call evaluate the base statement passed to it (https://codesearch.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/test/CommandLineInitRule.java?rcl=0f83d0347ba1b72a02a64d56ff9b9f86a96c1b17&l=34), so it doesn't evaluate the statement it contains. One of the contained statements is the test itself, tests using CommandLineTestRule -- currently just IntentHandlerTest, fortunately -- don't actually get executed, and we consider them to have passed.
,
Nov 3 2017
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f31578028a9aff1f6535153d0dc0271889493dc commit 4f31578028a9aff1f6535153d0dc0271889493dc Author: John Budorick <jbudorick@chromium.org> Date: Fri Nov 03 19:15:45 2017 [android] Ensure CommandLineInitRule evaluates its contained rules. Bug: 781346 Change-Id: I778e6739cd933d47bf8e63af952e40033fe69609 Reviewed-on: https://chromium-review.googlesource.com/754105 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#513865} [modify] https://crrev.com/4f31578028a9aff1f6535153d0dc0271889493dc/chrome/android/javatests/src/org/chromium/chrome/browser/test/CommandLineInitRule.java
,
Nov 3 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jbudorick@chromium.org
, Nov 3 2017