kernel warning detector doesn't like u |
|||
Issue descriptionForked from bug #780600 If you look at: https://goto.google.com/cr780600_crashes The 2nd crash from the top is "c64a73e9-nknown-function". One example specific crash is: http://crash.corp.google.com/38abaa3c3fc61fb4 --- So there are two problems here. 1. The "u" is missing in "unknown". 2. Really, this shouldn't be an unknown function. ...this bug is about #1. I'll file a bug about #2 soon-ish.
,
Nov 3 2017
also note that bug for point 2 above is bug #781384
,
Nov 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/5b928431b8c4167ad92e85cbd5095a4abbeb479c commit 5b928431b8c4167ad92e85cbd5095a4abbeb479c Author: Douglas Anderson <dianders@chromium.org> Date: Sat Nov 04 04:56:50 2017 crash: Fix "nknown" => "unknown" in anomaly collector This was just a simple silly thing where the code was skipping the first letter of the string, assuming it was a space. Just add a space so it's assumption is now correct. BUG= chromium:781343 TEST=FEATURES=test emerge-kevin crash-reporter # while cros_workon TEST=' echo WARNING > /sys/kernel/debug/provoke-crash/DIRECT grep "" /var/spool/crash/*.kcrash ' Change-Id: I835c0a9b3249b9d8633e7d4476927799b5bce6f7 Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/754086 Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/5b928431b8c4167ad92e85cbd5095a4abbeb479c/crash-reporter/anomaly_collector.l [modify] https://crrev.com/5b928431b8c4167ad92e85cbd5095a4abbeb479c/crash-reporter/anomaly_collector_test.sh [modify] https://crrev.com/5b928431b8c4167ad92e85cbd5095a4abbeb479c/crash-reporter/crash-reporter.gyp [add] https://crrev.com/5b928431b8c4167ad92e85cbd5095a4abbeb479c/crash-reporter/TEST_WARNING_OLD_ARM64
,
Nov 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/0fd77fcb1a5e785e1f93177dd6785aaa7570908a commit 0fd77fcb1a5e785e1f93177dd6785aaa7570908a Author: Heiko Carstens <heiko.carstens@de.ibm.com> Date: Sat Nov 04 04:56:44 2017 UPSTREAM: lib/bug.c: make panic_on_warn available for all architectures Christian Borntraeger reported that panic_on_warn doesn't have any effect on s390. The panic_on_warn feature was introduced with 9e3961a09798 ("kernel: add panic_on_warn"). However it did care only for the case when WANT_WARN_ON_SLOWPATH is defined. This is turn is only the case for architectures which do not have an own __WARN_TAINT defined. Other architectures which do have __WARN_TAINT defined call report_bug() for warnings within lib/bug.c which does not call panic() in case panic_on_warn is set. Let's simply enable the panic_on_warn feature by adding the same code like it was added to warn_slowpath_common() in panic.c. This enables panic_on_warn also for arm64, parisc, powerpc, s390 and sh. BUG= chromium:781343 TEST=echo WARNING > /sys/kernel/debug/provoke-crash/DIRECT Change-Id: I8fdf6490ea439e091054995367472accfb46a66c Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com> Tested-by: Christian Borntraeger <borntraeger@de.ibm.com> Acked-by: Prarit Bhargava <prarit@redhat.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will.deacon@arm.com> Cc: "James E.J. Bottomley" <jejb@parisc-linux.org> Cc: Helge Deller <deller@gmx.de> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Tested-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Douglas Anderson <dianders@chromium.org> (cherry picked from commit d7b85cab74edef84a9330c476478ba8cd732b6a9) Reviewed-on: https://chromium-review.googlesource.com/754000 Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> [modify] https://crrev.com/0fd77fcb1a5e785e1f93177dd6785aaa7570908a/lib/bug.c
,
Nov 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/89660857d58cec2155474f446455c41a22fd2b50 commit 89660857d58cec2155474f446455c41a22fd2b50 Author: Josh Poimboeuf <jpoimboe@redhat.com> Date: Sat Nov 04 04:56:46 2017 UPSTREAM: lib/bug.c: use common WARN helper The traceoff_on_warning option doesn't have any effect on s390, powerpc, arm64, parisc, and sh because there are two different types of WARN implementations: 1) The above mentioned architectures treat WARN() as a special case of a BUG() exception. They handle warnings in report_bug() in lib/bug.c. 2) All other architectures just call warn_slowpath_*() directly. Their warnings are handled in warn_slowpath_common() in kernel/panic.c. Support traceoff_on_warning on all architectures and prevent any future divergence by using a single common function to emit the warning. Also remove the '()' from '%pS()', because the parentheses look funky: [ 45.607629] WARNING: at /root/warn_mod/warn_mod.c:17 .init_dummy+0x20/0x40 [warn_mod]() BUG= chromium:781343 TEST=echo WARNING > /sys/kernel/debug/provoke-crash/DIRECT Change-Id: I3babe475d30ed2c5e16aa783a1422f3d5c599e74 Reported-by: Chunyu Hu <chuhu@redhat.com> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com> Tested-by: Prarit Bhargava <prarit@redhat.com> Acked-by: Prarit Bhargava <prarit@redhat.com> Acked-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Douglas Anderson <dianders@chromium.org> (cherry picked from commit 2553b67a1fbe7bf202e4e8070ab0b00d3d3a06a2) Reviewed-on: https://chromium-review.googlesource.com/754221 Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> [modify] https://crrev.com/89660857d58cec2155474f446455c41a22fd2b50/kernel/panic.c [modify] https://crrev.com/89660857d58cec2155474f446455c41a22fd2b50/include/asm-generic/bug.h [modify] https://crrev.com/89660857d58cec2155474f446455c41a22fd2b50/lib/bug.c
,
Nov 6 2017
Two of the changes above should have been tagged bug #781384 and I'll likely try to get those merged to M-63 in that bug. The other changes is just cosmetic and there's no real value in a marge. Calling this Fixed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by diand...@chromium.org
, Nov 3 2017