New issue
Advanced search Search tips

Issue 781340 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Add ChromeHomeBottomNavLabels to fieldtrials.json

Project Member Reported by k...@chromium.org, Nov 3 2017

Issue description

We should add ChromeHomeBottomNavLabels to the field trials json so that it gets tested by bots.
 
It won't get tested by the bots because we don't have any default configurations with Chrome Home enabled.

Comment 2 by k...@chromium.org, Nov 3 2017

Oh - I see. So there's no way around the fieldtrial.json error that we'll get when we move that experiment to beta+?
We can still add an entry. I guess maybe our Chrome Home tests will pick it up... All local builds will also start showing the labels when chrome home is enabled.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bb300a86c10d99d7b8eb89fd2c4beeaf736b12d

commit 3bb300a86c10d99d7b8eb89fd2c4beeaf736b12d
Author: Troy Hildebrandt <thildebr@chromium.org>
Date: Tue Nov 28 21:13:04 2017

Add ChromeHomeBottomNavLabels to fieldtrial_testing_config.json

Bug:  781340 
Change-Id: Id9d18f4873ce0d47ed882ff9a6e00140f424b991
Reviewed-on: https://chromium-review.googlesource.com/782709
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519838}
[modify] https://crrev.com/3bb300a86c10d99d7b8eb89fd2c4beeaf736b12d/testing/variations/fieldtrial_testing_config.json

Status: Fixed (was: Assigned)

Sign in to add a comment