Issue 781328 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	mustaq@chromium.org
Closed:	May 2018
Cc:	mlamouri@chromium.org
Components:	Blink>Input
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug
Hotlist-CodeHealth UserActivation

ChromeClientImpl::OpenJavaScript*Delegate methods access user activation through the web layer

Project Member Reported by mustaq@chromium.org, Nov 3 2017

Issue description

Shouldn't it access the current renderer's state directly?
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/page/ChromeClientImpl.cpp?rcl=6150bd6c4dd93aaea91b8515e3f9d54ac15cc9aa&l=354

Comment 1 by mustaq@chromium.org, May 16 2018

Labels: Hotlist-CodeHealth
Status: Started (was: Assigned)
Summary: ChromeClientImpl::OpenJavaScript*Delegate methods access user activation through the web layer (was: Why ChromeClientImpl::OpenJavaScriptAlertDelegate accesses user activation though the web layer?)

Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ffe87bb9aa46aa792e6446a48d3a8ca28d53536

commit 2ffe87bb9aa46aa792e6446a48d3a8ca28d53536
Author: Mustaq Ahmed <mustaq@google.com>
Date: Fri May 18 15:34:31 2018

ChromeClientImpl calls UserGestureIndicator methods directly.

Bug:  781328 
Change-Id: If1cb265cf1dfcf4ef2fffe4cd67741ed177ae1be
Reviewed-on: https://chromium-review.googlesource.com/1062768
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559902}
[modify] https://crrev.com/2ffe87bb9aa46aa792e6446a48d3a8ca28d53536/third_party/blink/public/web/web_user_gesture_indicator.h
[modify] https://crrev.com/2ffe87bb9aa46aa792e6446a48d3a8ca28d53536/third_party/blink/renderer/core/exported/web_user_gesture_indicator.cc
[modify] https://crrev.com/2ffe87bb9aa46aa792e6446a48d3a8ca28d53536/third_party/blink/renderer/core/page/chrome_client_impl.cc

Comment 3 by mustaq@chromium.org, May 18 2018

Status: Fixed (was: Started)

►

Issue 781328 link

Issue metadata

ChromeClientImpl::OpenJavaScript*Delegate methods access user activation through the web layer

Issue description

Comment 1 by mustaq@chromium.org, May 16 2018

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, May 18 2018

Comment 2 Deleted

Comment 3 by mustaq@chromium.org, May 18 2018

Comment 3 Deleted

Sign in to add a comment