New issue
Advanced search Search tips

Issue 781324 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Cros SplitView - Overview windows can be dragged really slowly and nothing will happen.

Project Member Reported by sammiequon@chromium.org, Nov 3 2017

Issue description

(1) Enter tablet mode with split view enabled.
(2) Enter overview mode.
(3) Tap a window, and slowly drag, less than 5px at a time.

What is the expected result?
After dragging 5px from the tap point, the window should move with the finger.

What happens instead?
You can drag forever and nothing will happen.


 
Actually, the dragging speed does not matter. To repro, you have drag horizontally or vertically and make sure it is dragged straight +- 5px from the start point.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e3de121131acc222d168fb8406c5c775fbed5ea

commit 6e3de121131acc222d168fb8406c5c775fbed5ea
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Nov 17 17:43:01 2017

splitview: Improve dragging in overview mode.

Add a minimum distance for windows that get tapped and already in a snap region
(windows tapped close too the left or right side of the screen). This is
so users do not accidently snap too easily when trying to activate the
window. Also fix a bug where you can drag very straight across or down
without the overview window moving.

Test: ash_unittests SplitViewWindowSelectorTest.Dragging
Bug: 778933,  781324 
Change-Id: I1b4e993951260f079f85851890854dc217ea95f3
Reviewed-on: https://chromium-review.googlesource.com/757985
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517458}
[modify] https://crrev.com/6e3de121131acc222d168fb8406c5c775fbed5ea/ash/wm/overview/overview_window_drag_controller.cc
[modify] https://crrev.com/6e3de121131acc222d168fb8406c5c775fbed5ea/ash/wm/overview/overview_window_drag_controller.h
[modify] https://crrev.com/6e3de121131acc222d168fb8406c5c775fbed5ea/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/6e3de121131acc222d168fb8406c5c775fbed5ea/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/6e3de121131acc222d168fb8406c5c775fbed5ea/ash/wm/splitview/split_view_controller.h

Status: Fixed (was: Assigned)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment