New issue
Advanced search Search tips

Issue 781322 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 685854
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 781231



Sign in to add a comment

testdriver.js duplication

Project Member Reported by nzolghadr@chromium.org, Nov 3 2017

Issue description

There was a new file added in wpt similar to testharness. It is called testdriver.js which has a vendor specific part called testdriver-vendor.js.

Since we expose Layouttests/resources/*to the tests we need to make sure they are in sync or better just have one copy.
 
Blockedon: 781231

Comment 2 by foolip@chromium.org, Nov 21 2017

Cc: robertma@chromium.org
robertma@, do you think we should treat this like testharness.js and allow it to go out of sync but bring them back in sync every so often?
Yes, we should definitely treat the two JS in the same way. Although we can
discuss whether to sync them manually or automatically.

The previous decision to sync testharness.js manually is because it can
sometimes break in the upstream, and cause a huge (and wrong) rebaseline
during import. More human scrutiny is hence needed. (Heard from qyearsley@)
However, if the upstream has become more stable (especially if the Travis
checks prove to be effective), we can surely revisit the decision.

Comment 4 by foolip@chromium.org, Nov 21 2017

Mergedinto: 685854
Status: Duplicate (was: Available)
I'll call this a dupe of  issue 685854  and update that one.

Sign in to add a comment