Simplify perf_data_generator |
||
Issue descriptionBug for myself: Instead of checking that the tests are the same, just regenerate the json file and then check to see if there are uncommitted files. It will simplify this file a lot!
,
Nov 13 2017
,
Feb 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de996bafd4753a7482b4ef47df2a5fce7256309d commit de996bafd4753a7482b4ef47df2a5fce7256309d Author: Ashley Enstad <ashleymarie@chromium.org> Date: Fri Feb 16 04:22:10 2018 Simplifying perf_data_generator We are down to one waterfall json generated by this file so we should have easier to read code. Bug: 781312 Change-Id: I9e3c770691362690c5967947001ebf219844ca8c Reviewed-on: https://chromium-review.googlesource.com/923282 Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#537193} [modify] https://crrev.com/de996bafd4753a7482b4ef47df2a5fce7256309d/tools/perf/core/perf_data_generator.py
,
Feb 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c8ad416a0c1c4d68046985cc1d24ab5ea8cf823 commit 5c8ad416a0c1c4d68046985cc1d24ab5ea8cf823 Author: Ashley Enstad <ashleymarie@chromium.org> Date: Fri Feb 16 16:45:23 2018 Updating presubmit for perf_data_generator Bug: 781312 Change-Id: Ia8c7eba3853f1dff32e95c6f89d2fbfcc2e73aeb Reviewed-on: https://chromium-review.googlesource.com/921926 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#537320} [modify] https://crrev.com/5c8ad416a0c1c4d68046985cc1d24ab5ea8cf823/tools/perf/PRESUBMIT.py [modify] https://crrev.com/5c8ad416a0c1c4d68046985cc1d24ab5ea8cf823/tools/perf/core/perf_data_generator.py [modify] https://crrev.com/5c8ad416a0c1c4d68046985cc1d24ab5ea8cf823/tools/perf/generate_perf_data |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Nov 13 2017