New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781312 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Simplify perf_data_generator

Project Member Reported by ashleymarie@chromium.org, Nov 3 2017

Issue description

Bug for myself:
Instead of checking that the tests are the same, just regenerate the json file and then check to see if there are uncommitted files. It will simplify this file a lot!

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2383d3201fd6c2c7aeb18ea11e1a4eb4dde7c5c4

commit 2383d3201fd6c2c7aeb18ea11e1a4eb4dde7c5c4
Author: Ashley Enstad <ashleymarie@chromium.org>
Date: Mon Nov 13 21:48:44 2017

Regenerating perf_data_generator on presubmit so the csv and json files stay up-to-date

Instead of verifying that a user manually ran the update command, just
run it anyways and block presubmit if there are uncommitted changes
(namely the updated csv and json files).

BUG= chromium:781312 

Change-Id: I8f05cd0bf817ca958c608c0e54c87a990ba6848e
Reviewed-on: https://chromium-review.googlesource.com/754062
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#516066}
[modify] https://crrev.com/2383d3201fd6c2c7aeb18ea11e1a4eb4dde7c5c4/tools/perf/PRESUBMIT.py
[modify] https://crrev.com/2383d3201fd6c2c7aeb18ea11e1a4eb4dde7c5c4/tools/perf/core/perf_data_generator.py
[modify] https://crrev.com/2383d3201fd6c2c7aeb18ea11e1a4eb4dde7c5c4/tools/perf/generate_perf_data

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de996bafd4753a7482b4ef47df2a5fce7256309d

commit de996bafd4753a7482b4ef47df2a5fce7256309d
Author: Ashley Enstad <ashleymarie@chromium.org>
Date: Fri Feb 16 04:22:10 2018

Simplifying perf_data_generator

We are down to one waterfall json generated by this file so we should
have easier to read code.

Bug:  781312 
Change-Id: I9e3c770691362690c5967947001ebf219844ca8c
Reviewed-on: https://chromium-review.googlesource.com/923282
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#537193}
[modify] https://crrev.com/de996bafd4753a7482b4ef47df2a5fce7256309d/tools/perf/core/perf_data_generator.py

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c8ad416a0c1c4d68046985cc1d24ab5ea8cf823

commit 5c8ad416a0c1c4d68046985cc1d24ab5ea8cf823
Author: Ashley Enstad <ashleymarie@chromium.org>
Date: Fri Feb 16 16:45:23 2018

Updating presubmit for perf_data_generator

Bug:  781312 
Change-Id: Ia8c7eba3853f1dff32e95c6f89d2fbfcc2e73aeb
Reviewed-on: https://chromium-review.googlesource.com/921926
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537320}
[modify] https://crrev.com/5c8ad416a0c1c4d68046985cc1d24ab5ea8cf823/tools/perf/PRESUBMIT.py
[modify] https://crrev.com/5c8ad416a0c1c4d68046985cc1d24ab5ea8cf823/tools/perf/core/perf_data_generator.py
[modify] https://crrev.com/5c8ad416a0c1c4d68046985cc1d24ab5ea8cf823/tools/perf/generate_perf_data

Sign in to add a comment