Implement Doodle logging via /async/ddllog |
|||||||
Issue descriptionThe response from /async/ddljson may contain a log_url and/or cta_log_url. We should ping those on the corresponding impressions, and use their responses (interaction_log_url or target_url_params) to log interactions.
,
Nov 7 2017
,
Nov 22 2017
Issue 625806 has been merged into this issue.
,
Jan 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b524482740db48f7fba695b70bddec6cb3c204fa commit b524482740db48f7fba695b70bddec6cb3c204fa Author: Marc Treib <treib@chromium.org> Date: Mon Jan 15 12:42:51 2018 Local NTP: Doodle logging via /async/ddllog Bug: 781309 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iac285baf48c04251a749e5ed06201c2e63d568c3 Reviewed-on: https://chromium-review.googlesource.com/753370 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#529258} [modify] https://crrev.com/b524482740db48f7fba695b70bddec6cb3c204fa/chrome/browser/resources/local_ntp/local_ntp.js [modify] https://crrev.com/b524482740db48f7fba695b70bddec6cb3c204fa/chrome/browser/search/local_ntp_source.cc [modify] https://crrev.com/b524482740db48f7fba695b70bddec6cb3c204fa/chrome/browser/ui/search/local_ntp_doodle_browsertest.cc [add] https://crrev.com/b524482740db48f7fba695b70bddec6cb3c204fa/chrome/test/data/local_ntp/ddllog-interaction_log_url [add] https://crrev.com/b524482740db48f7fba695b70bddec6cb3c204fa/chrome/test/data/local_ntp/ddllog-interaction_log_url.mock-http-headers [add] https://crrev.com/b524482740db48f7fba695b70bddec6cb3c204fa/chrome/test/data/local_ntp/ddllog-target_url_params [add] https://crrev.com/b524482740db48f7fba695b70bddec6cb3c204fa/chrome/test/data/local_ntp/ddllog-target_url_params.mock-http-headers [add] https://crrev.com/b524482740db48f7fba695b70bddec6cb3c204fa/chrome/test/data/local_ntp/simple.html [modify] https://crrev.com/b524482740db48f7fba695b70bddec6cb3c204fa/components/search_provider_logos/features.cc [modify] https://crrev.com/b524482740db48f7fba695b70bddec6cb3c204fa/components/search_provider_logos/features.h [modify] https://crrev.com/b524482740db48f7fba695b70bddec6cb3c204fa/components/search_provider_logos/google_logo_api.cc [modify] https://crrev.com/b524482740db48f7fba695b70bddec6cb3c204fa/components/search_provider_logos/google_logo_api_unittest.cc [modify] https://crrev.com/b524482740db48f7fba695b70bddec6cb3c204fa/components/search_provider_logos/logo_cache.cc [modify] https://crrev.com/b524482740db48f7fba695b70bddec6cb3c204fa/components/search_provider_logos/logo_cache_unittest.cc [modify] https://crrev.com/b524482740db48f7fba695b70bddec6cb3c204fa/components/search_provider_logos/logo_common.h
,
Jan 30 2018
This is done for the desktop local NTP. The remote NTP (if it will continue to exist) as well as mobile are still TBD.
,
Mar 5 2018
The design for this is finished and approved for all platforms, see go/ntp-doodle-logging and go/ntp-doodle-logging-privacy. Implementation: - The desktop local NTP is done. - The desktop remote NTP is not started. It uses its own endpoint for fetching Doodles, so some extra plumbing will be required to pipe through the [cta_]log_url params. Otherwise this should be a straightforward port of the above CL. - The Android implementation is started (https://crrev.com/c/870772) but a lot remains to be done. Because it's a native UI, this is a bit more tedious than on desktop. The Doodles team has been waiting for this for a long time already. Since it looks like the local NTP isn't launching any time soon, it'd be great to get the remote NTP done ASAP. jshneier@ will be able to help with the plumbing.
,
Mar 5 2018
Hi ramyan! I hear you're owning this now. What's the plan for this feature? We've been working on getting this logging in place for a long time; it's our last major unlogged platform, so we'd really like to see it launched.
,
Jul 27
,
Sep 20
,
Nov 30
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by treib@chromium.org
, Nov 3 2017