New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 781294 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Nov 6
Cc:
yus...@chromium.org
tedc...@chromium.org
█ donnd@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

The needToCheckForSearchEnginePromo doesn't work correctly in the public tree

Project Member Reported by donnd@google.com, Nov 3 2017 
When a CCT launches the public-only Chromium Contextual Search is not enabled because needToCheckForSearchEnginePromo returns true.

Comment 1 by tedc...@chromium.org, Nov 3 2017

Cc: tedc...@chromium.org yus...@chromium.org
Components: UI>Browser>Mobile
Owner: ----
Status: Available (was: Untriaged)
Going to ChromeTabbedActivity a single time should set mSearchEnginePromoCheckedThisSession = true, and for the rest of the lifetime, CCT should work for contextual search.

The problem is we never set a sticky value in the public repro, so we rely on the session check each time.

We should instead find a path that sets KEY_SEARCH_ENGINE_PROMO_SHOW_STATE to something other than SHOULD_CHECK in the public repo.

yusufo@ has more experience with this flag, so he might have a better idea with where to set it
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 5

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by donnd@google.com, Nov 6

Status: Fixed (was: Untriaged)
Just tested this, looks like it's working now.
►

Sign in to add a comment