New issue
Advanced search Search tips

Issue 781291 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Don't show "add card" button for non-basic-card payment requests.

Project Member Reported by rouslan@chromium.org, Nov 3 2017

Issue description

Chrome Version       : 64.0.3253.3
OS Version: 
URLs (if applicable) : https://rsolomakhin.github.io/pr/bob/
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5:
  Firefox 4.x:
     IE 7/8/9:

What steps will reproduce the problem?
1. Install the payment handler from https://bobpay.xyz.
2. Open the payment sheet on https://rsolomakhin.github.io/pr/bob/.
3. Expand the list of all payment methods.

What is the expected result?
There should not be an "Add Card" button, because this payment request does not include "basic-card" as a supported payment method.

What happens instead of that?
The "Add Card" button is present and can be clicked. Upon clicking it, the "add card" sheet appears, but it has no card issuer network icons (because none of the networks are accepted).

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3253.3 Safari/537.36



 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33ec65c108becbecbbe64c97a74cb12daa50904d

commit 33ec65c108becbecbbe64c97a74cb12daa50904d
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Wed Jan 03 18:03:36 2018

[Payments] Hide 'Add card' button when cards are not supported.

Bug:  781291 
Change-Id: I4405edc4e76f3c00b4ea83eab07b3387edc7a80f
Reviewed-on: https://chromium-review.googlesource.com/849155
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526734}
[modify] https://crrev.com/33ec65c108becbecbbe64c97a74cb12daa50904d/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/33ec65c108becbecbbe64c97a74cb12daa50904d/components/payments/content/payment_request_spec.h

Status: Fixed (was: Assigned)
Labels: Needs-Feedback
Tested the issue using #65.0.3311.0 on Linux Ubuntu 14.04 as per the steps mentioned in original comment.

@rouslan: Could you please find the attached screencast and confirm about the fix?

Thanks!! 
781291.webm
4.4 MB View Download
Yep, looks correct. Thank you!

Sign in to add a comment