New issue
Advanced search Search tips

Issue 781287 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Payment sheet is not showing "Loading..." spinner when using a payment handler.

Project Member Reported by rouslan@chromium.org, Nov 3 2017

Issue description

Chrome Version       : 64.0.3253.3
OS Version: 
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5:
  Firefox 4.x:
     IE 7/8/9:

What steps will reproduce the problem?
1. Install a payment handler from https://rsolomakhin.github.io/pr/apps/basic-card/
2. Pay via this payment handler on https://rsolomakhin.github.io/pr/cc/

What is the expected result?
Clicking "Pay" in the Chrome payment sheet should activate the "Loading..." spinner and prevent user interaction with the payment sheet.

What happens instead of that?
After clicking "Pay" in the Chrome payment sheet, the UI does not change for ~2 seconds and then hides when the payment completes. During these ~2 seconds, it's possible to further interact with the payment sheet. Clicking "Pay" the second time will crash the browser, for example.


Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3253.3 Safari/537.36



 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04867cfd358904eb4082f7ef61ccefb9673fcbd4

commit 04867cfd358904eb4082f7ef61ccefb9673fcbd4
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Wed Jan 03 14:51:45 2018

[Payments] Show spinner when invoking payment handler.

TEST=PaymentRequestPaymentAppTest*

Bug:  781287 
Change-Id: I81317d3b6299b5617c1886e37596dcbb7f4435de
Reviewed-on: https://chromium-review.googlesource.com/814575
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526691}
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/chrome/browser/payments/chrome_payment_request_delegate.cc
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/chrome/browser/payments/chrome_payment_request_delegate.h
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/chrome/browser/ui/views/payments/cvc_unmask_view_controller_browsertest.cc
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/chrome/browser/ui/views/payments/empty_update_browsertest.cc
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/chrome/browser/ui/views/payments/error_message_view_controller_browsertest.cc
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/chrome/browser/ui/views/payments/order_summary_view_controller_browsertest.cc
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/chrome/browser/ui/views/payments/payment_request_dialog_view.cc
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/chrome/browser/ui/views/payments/payment_request_dialog_view.h
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/chrome/browser/ui/views/payments/payment_request_no_update_with_browsertest.cc
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/chrome/browser/ui/views/payments/payment_request_payment_app_browsertest.cc
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/chrome/browser/ui/views/payments/shipping_option_view_controller_browsertest.cc
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/components/payments/content/payment_request_dialog.h
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/components/payments/content/service_worker_payment_instrument.cc
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/components/payments/content/service_worker_payment_instrument.h
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/components/payments/content/service_worker_payment_instrument_unittest.cc
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/components/payments/content/test_content_payment_request_delegate.cc
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/components/payments/content/test_content_payment_request_delegate.h
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/components/payments/core/payment_request_delegate.h
[modify] https://crrev.com/04867cfd358904eb4082f7ef61ccefb9673fcbd4/components/payments/core/test_payment_request_delegate.h

Status: Fixed (was: Started)
Summary: Payment sheet is not showing "Loading..." spinner when using a payment handler. (was: Payment sheet is not showing "Loading..." button when payment via payment handler.)

Sign in to add a comment