New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 781286 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
█ ajwong@chromium.org
etienneb@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

OOP HP: don't enable profiling if build is unsupported

Project Member Reported by erikc...@chromium.org, Nov 3 2017 
e.g. if the build is ASAN, profiling shouldn't be allowed. Also, Windows requires release + statis. Android builds require certain CPU architectures or profiling modes.

Some of this logic exists in the memory_internals UI page. We should probably move it into ProfilingProcessHost:

https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/memory_internals_ui.cc?type=cs&q=memory_internals&sq=package:chromium&l=63
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e7acf38af7dcc7ccacec531f1882cee0b1efa2c

commit 9e7acf38af7dcc7ccacec531f1882cee0b1efa2c
Author: Etienne Bergeron <etienneb@chromium.org>
Date: Tue Nov 07 18:13:18 2017

Turn off memlog when memory sanitizers are present.

SyzyASAN and clang-ASAN may cause memlog to report slow-reports by using lot of memory. Also, clang-ASAN is doing dynamic patching to hook on allocators. This may conflict with memlog (SHIM). It's better to not allow memlog and sanitizers at the same time.

On a performance point of view, sanitizer are using lots of memory and memlog too. It's better to not affect too much the user experience by activating both feature at the same time.

R=erikchen@chromium.org

Bug:  781286 
Change-Id: If4619e0ba13f320e4c3755698ecd5dcea1130360
Reviewed-on: https://chromium-review.googlesource.com/753931
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514508}
[modify] https://crrev.com/9e7acf38af7dcc7ccacec531f1882cee0b1efa2c/chrome/browser/profiling_host/chrome_browser_main_extra_parts_profiling.cc
[modify] https://crrev.com/9e7acf38af7dcc7ccacec531f1882cee0b1efa2c/chrome/browser/ui/webui/memory_internals_ui.cc

Comment 2 by erikc...@chromium.org, Jan 11 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment