Issue metadata
Sign in to add a comment
|
viz could be made smaller by optimizing for size |
||||||||||||||||||||||
Issue descriptionIn a recent clang roll c4a8c7b5ff68ad06bdaff91be5170e4da89c3a9f agrieve noticed that targets without optimize_for_size saw the most growth. The top three symbols that grew were in viz (they contributed almost 50 kb of the growth).
,
Nov 3 2017
Take a look at the history why this was originally done for src/cc
,
Nov 7 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by estevenson@chromium.org
, Nov 3 2017I removed this optimization from android builds: diff --git a/components/viz/viz.gni b/components/viz/viz.gni index 5df8b1aba69a..794d5f2b5064 100644 --- a/components/viz/viz.gni +++ b/components/viz/viz.gni @@ -7,7 +7,7 @@ import("//testing/test.gni") viz_remove_configs = [] viz_add_configs = [ "//build/config:precompiled_headers" ] -if (!is_debug && (is_win || is_android)) { +if (!is_debug && (is_win)) { viz_remove_configs += [ "//build/config/compiler:default_optimization" ] viz_add_configs += [ "//build/config/compiler:optimize_max" ] } And MonochromePublic.apk shrank by about 60 kb. Any chance we can try this out? Are there any perf tests I can try this with?