Issue metadata
Sign in to add a comment
|
2.8%-24.5% regression in thread_times.key_silk_cases at 512747:512907 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Nov 3 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8963936925652146912
,
Nov 3 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8963936823682663088
,
Nov 3 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Koji Ishii Commit : 811fe6a25ddee5065812bf50733de963e58832cb Date : Tue Oct 31 14:34:37 2017 Subject: Add CrashKey to LazyLineBreakIterator on Android Bisect Details Configuration: android_nexus6_perf_bisect Benchmark : thread_times.key_silk_cases Metric : thread_renderer_main_cpu_time_per_frame/infinite_scrolling.html Change : 20.80% | 5.76044660487 -> 6.95834795102 Revision Result N chromium@512803 5.76045 +- 0.0542307 6 good chromium@512821 5.78187 +- 0.0812025 6 good chromium@512824 5.79801 +- 0.0622223 6 good chromium@512825 6.93244 +- 0.120212 6 bad <-- chromium@512826 6.94082 +- 0.0990212 6 bad chromium@512830 6.96606 +- 0.117406 6 bad chromium@512839 6.95378 +- 0.0883694 6 bad chromium@512875 6.95835 +- 0.108007 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=infinite.scrolling.html thread_times.key_silk_cases More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8963936823682663088 For feedback, file a bug with component Speed>Bisection
,
Nov 3 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Koji Ishii Commit : 811fe6a25ddee5065812bf50733de963e58832cb Date : Tue Oct 31 14:34:37 2017 Subject: Add CrashKey to LazyLineBreakIterator on Android Bisect Details Configuration: android_one_perf_bisect Benchmark : thread_times.key_silk_cases Metric : thread_renderer_main_cpu_time_per_frame/infinite_scrolling.html Change : 24.98% | 6.67728001071 -> 8.34525368412 Revision Result N chromium@512781 6.67728 +- 0.214739 6 good chromium@512813 6.69377 +- 0.131895 6 good chromium@512821 6.7532 +- 0.260075 6 good chromium@512823 6.70081 +- 0.178872 6 good chromium@512824 6.61537 +- 0.116272 6 good chromium@512825 8.33497 +- 0.155611 6 bad <-- chromium@512829 8.383 +- 0.197789 6 bad chromium@512844 8.34302 +- 0.487758 6 bad chromium@512907 8.34525 +- 0.0583833 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=infinite.scrolling.html thread_times.key_silk_cases More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8963936925652146912 For feedback, file a bug with component Speed>Bisection
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ea04e064baa8615e5ef9702050ce6a605435c57 commit 0ea04e064baa8615e5ef9702050ce6a605435c57 Author: Annie Sullivan <sullivan@chromium.org> Date: Fri Nov 03 18:38:38 2017 Revert "Add CrashKey to LazyLineBreakIterator on Android" This reverts commit 811fe6a25ddee5065812bf50733de963e58832cb. Reason for revert: This CL slowed down the blink_perf.paint test to the point where it times out, and also caused several other performance regressions. Bug: 780502 , 781166 , 781167 , 781245 , 781245 Original change's description: > Add CrashKey to LazyLineBreakIterator on Android > > This patch adds CrashKey to investigate where crashes occur. > > LazyLineBreakIterator::IsBreakable() has inline and templates > that the stack quality is low. > > Bug: 756624 > Change-Id: I657b18aa1cb74b2587104352b4a3e826522b6ba8 > Reviewed-on: https://chromium-review.googlesource.com/737710 > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#512825} TBR=falken@chromium.org,eae@chromium.org,kojii@chromium.org,drott@chromium.org,halliwell@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 756624 Change-Id: Ib5dbe2ea94fe719d96c2bbfd4a908f2d226aa8ae Reviewed-on: https://chromium-review.googlesource.com/753529 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#513852} [modify] https://crrev.com/0ea04e064baa8615e5ef9702050ce6a605435c57/android_webview/common/crash_reporter/crash_keys.cc [modify] https://crrev.com/0ea04e064baa8615e5ef9702050ce6a605435c57/chrome/common/crash_keys.cc [modify] https://crrev.com/0ea04e064baa8615e5ef9702050ce6a605435c57/chromecast/crash/cast_crash_keys.cc [modify] https://crrev.com/0ea04e064baa8615e5ef9702050ce6a605435c57/third_party/WebKit/Source/platform/text/TextBreakIterator.cpp |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 3 2017