New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781194 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'Back' button is not working in "Network not available" page of Sign-In page

Project Member Reported by mmanchala@chromium.org, Nov 3 2017

Issue description

Chrome Version: 64.0.3256.0/10093.0.0 dev channel Peppy,Kip and Paine
OS: Chrome

What steps will reproduce the problem?
(1)Recover build -> In Sign-in screen enter Email Id -> Now at Uber Tray turn-off WI-FI 
(2)Now "Network not available" page is seen ->observe unnecessary 'Back' button is seen and try to click it(please refer video)

Expected:
'Back' button should be seen disabled
(or) 
'Back' button should not be available in "Network not available" page

Actual: Instead  unnecessary 'Back' button is seen
i.e. On clicking 'Back' button nothing happens i.e. 'Back' button is not working

This is Regression Issue as same is working fine in M-60 

@wzang : Please confirm the Issue
 
Actual_UnnecessaryBackButtonisSeen.mp4
18.5 MB Download
Actual_UnnecessaryBackButtonisSeen.jpg
415 KB View Download
Attaching Expected video for reference
Expected_NoIcon.mp4
14.3 MB View Download

Comment 2 by wzang@chromium.org, Nov 9 2017

Labels: -ReleaseBlock-Beta

Comment 3 by wzang@chromium.org, Nov 16 2017

I'm not able to repro following the instructions. 
C #3>

Steps to reproduce the Issue:
1)After recovering Build -> In sign-n screen -> Enter valid Email Id -> Click on 'NEXT' button -> 'Enter your password' field screen is seen
2)Now Click on UberTray -> Select Network option -> Turn off Wi-Fi and observe 'Wi-Fi is turned off' message at Uber tray
3)Now after wi-Fi is turned off  "Network not available" page is seen -> Observe 'Back' button option is available at bottom of the page(Back button is seen enabled i.e. Blue color text is seen as it is clickabale) and try to click -> Unable to click on 'Back' button

Expected:
Either 'Back' button should be seen disabled
(or) 
'Back' button should not be available in "Network not available" page at bottom of the page

Issue is reproducible on latest M-64 64.0.3270.0/10136.0.0 and attaching video for reference.

Thanks..!!
BackButtonNotWorkingOn6.0.3270.0.mp4
18.9 MB Download

Comment 5 by wzang@chromium.org, Nov 17 2017

Thanks for the detailed explanation and the video! I'm still not able to repro though.. See my video here https://drive.google.com/a/google.com/file/d/17A8E7JZQf5k3_aMC1hWq0ueSrZinG1rU/view?usp=sharing

I will keep an eye on this..
Issue is seen only for first user sign-in screen as mentioned in comment #0 & #4.
but in video mentioned in comment # 5 there are 3 users in sign-out screen.
'Back' button works for other Users sign-in screen 'Network offline page' other than owner sign-in screen 'Network offline page'.

Thanks..!!
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b04e162cfd5a703f8cee8586bae5941343b7a8f0

commit b04e162cfd5a703f8cee8586bae5941343b7a8f0
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue Feb 27 19:34:51 2018

cros: Disable back button on network error screen when it's not clickable

Bug:  781194 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4c0946028e8fdb6e86825052af14cef498119cdb
Reviewed-on: https://chromium-review.googlesource.com/933706
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539522}
[modify] https://crrev.com/b04e162cfd5a703f8cee8586bae5941343b7a8f0/chrome/browser/resources/chromeos/login/screen_error_message.js

Comment 8 by wzang@chromium.org, Feb 27 2018

Status: Fixed (was: Assigned)

Sign in to add a comment