New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781175 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in SkSurface_Base::getCachedCanvas

Project Member Reported by ClusterFuzz, Nov 3 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5511110253084672

Fuzzer: inferno_layout_test_fuzzer
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  SkSurface_Base::getCachedCanvas
  blink::ImageBitmap::RasterizeImageOnBackgroundThread
  void base::internal::FunctorTraits<void
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=508795:508862

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5511110253084672

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 3 2017

Components: Blink>Canvas Internals>Core
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 3 2017

Labels: Test-Predator-AutoOwner
Owner: ericrk@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://skia.googlesource.com/skia/+/914a36b248ffb538874483d86759254838866dd7 (MakeBackendTextureFromSkImage).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 3 by junov@chromium.org, Nov 3 2017

Owner: junov@chromium.org
I'll take this.

Comment 4 by junov@chromium.org, Nov 3 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/985e9443e23940d15fcad2accfab741156239a8c

commit 985e9443e23940d15fcad2accfab741156239a8c
Author: Justin Novosad <junov@chromium.org>
Date: Mon Nov 06 19:26:43 2017

Fix crash due to allocation failure in CreateImageBitmap

BUG= 781175 

Change-Id: If8b1a100b41e5bde7035def350c92abb18e9f0a6
Reviewed-on: https://chromium-review.googlesource.com/753922
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514208}
[modify] https://crrev.com/985e9443e23940d15fcad2accfab741156239a8c/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp

Project Member

Comment 6 by ClusterFuzz, Nov 7 2017

ClusterFuzz has detected this issue as fixed in range 514186:514212.

Detailed report: https://clusterfuzz.com/testcase?key=5511110253084672

Fuzzer: inferno_layout_test_fuzzer
Job Type: linux_ubsan_vptr_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  SkSurface_Base::getCachedCanvas
  blink::ImageBitmap::RasterizeImageOnBackgroundThread
  void base::internal::FunctorTraits<void
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=508795:508862
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_content_shell_drt&range=514186:514212

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5511110253084672

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Nov 7 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5511110253084672 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: Test-Predator-Auto-CC
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner
Labels: -Test-Predator-Auto-CC

Sign in to add a comment