New issue
Advanced search Search tips

Issue 781167 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 780502
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

14.7%-251.8% regression in v8.runtimestats.browsing_mobile at 512736:512860

Project Member Reported by mlippautz@google.com, Nov 3 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=781167

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=b39ffba0b318ed5899bca65bb22b5f698b7d4d444d78448388e7d87f6acddd7e


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus5X
android-webview-nexus6
Mergedinto: 780502
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Koji Ishii
  Commit : 811fe6a25ddee5065812bf50733de963e58832cb
  Date   : Tue Oct 31 14:34:37 2017
  Subject: Add CrashKey to LazyLineBreakIterator on Android

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : v8.browsing_mobile
  Metric       : total:500ms_window:renderer_eqt:v8_max/browse_social/browse_social_tumblr_infinite_scroll
  Change       : 157.64% | 169.719051231 -> 437.26535721

Revision             Result                  N
chromium@512746      169.719 +- 125.238      9      good
chromium@512790      150.697 +- 40.1372      6      good
chromium@512812      151.443 +- 33.885       6      good
chromium@512823      163.239 +- 45.5293      6      good
chromium@512824      170.923 +- 48.2484      6      good
chromium@512825      419.603 +- 365.18       6      bad       <--
chromium@512826      308.679 +- 120.156      6      bad
chromium@512829      403.549 +- 424.334      6      bad
chromium@512834      437.265 +- 510.185      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.tumblr.infinite.scroll v8.browsing_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963954585998050448


For feedback, file a bug with component Speed>Bisection
Owner: kojii@chromium.org
Status: Assigned (was: Duplicate)
Unduping as this is a performance issue and the duped bug is a test failure.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ea04e064baa8615e5ef9702050ce6a605435c57

commit 0ea04e064baa8615e5ef9702050ce6a605435c57
Author: Annie Sullivan <sullivan@chromium.org>
Date: Fri Nov 03 18:38:38 2017

Revert "Add CrashKey to LazyLineBreakIterator on Android"

This reverts commit 811fe6a25ddee5065812bf50733de963e58832cb.

Reason for revert: This CL slowed down the blink_perf.paint test to the point where it times out, and also caused several other performance regressions.

Bug:  780502 ,  781166 ,  781167 ,  781245 ,  781245 

Original change's description:
> Add CrashKey to LazyLineBreakIterator on Android
> 
> This patch adds CrashKey to investigate where crashes occur.
> 
> LazyLineBreakIterator::IsBreakable() has inline and templates
> that the stack quality is low.
> 
> Bug: 756624
> Change-Id: I657b18aa1cb74b2587104352b4a3e826522b6ba8
> Reviewed-on: https://chromium-review.googlesource.com/737710
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Luke Halliwell <halliwell@chromium.org>
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#512825}

TBR=falken@chromium.org,eae@chromium.org,kojii@chromium.org,drott@chromium.org,halliwell@chromium.org,rsesek@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 756624
Change-Id: Ib5dbe2ea94fe719d96c2bbfd4a908f2d226aa8ae
Reviewed-on: https://chromium-review.googlesource.com/753529
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513852}
[modify] https://crrev.com/0ea04e064baa8615e5ef9702050ce6a605435c57/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/0ea04e064baa8615e5ef9702050ce6a605435c57/chrome/common/crash_keys.cc
[modify] https://crrev.com/0ea04e064baa8615e5ef9702050ce6a605435c57/chromecast/crash/cast_crash_keys.cc
[modify] https://crrev.com/0ea04e064baa8615e5ef9702050ce6a605435c57/third_party/WebKit/Source/platform/text/TextBreakIterator.cpp

Comment 6 by kojii@chromium.org, Nov 5 2017

Status: Duplicate (was: Assigned)

Sign in to add a comment