New issue
Advanced search Search tips

Issue 781166 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 780502
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

9.4%-199.3% regression in v8.browsing_mobile at 512790:512885

Project Member Reported by mlippautz@google.com, Nov 3 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=781166

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=dc5d63493a6d89a4dc8b6810e1611c14a9ccb18f5c0f637ac776a77dcd796771


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus6
android-nexus7v2
android-webview-nexus5X
Mergedinto: 780502
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Koji Ishii
  Commit : 811fe6a25ddee5065812bf50733de963e58832cb
  Date   : Tue Oct 31 14:34:37 2017
  Subject: Add CrashKey to LazyLineBreakIterator on Android

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : v8.browsing_mobile
  Metric       : total:500ms_window:renderer_eqt_max/browse_social/browse_social_tumblr_infinite_scroll
  Change       : 149.87% | 434.019166667 -> 1084.472

Revision             Result                  N
chromium@512803      434.019 +- 206.982      6      good
chromium@512821      422.0 +- 171.232        6      good
chromium@512824      428.996 +- 232.528      6      good
chromium@512825      1074.91 +- 353.283      6      bad       <--
chromium@512826      1045.58 +- 555.176      6      bad
chromium@512830      1061.7 +- 707.646       6      bad
chromium@512839      1008.07 +- 481.687      6      bad
chromium@512875      1084.47 +- 226.913      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.tumblr.infinite.scroll v8.browsing_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963954597957306480


For feedback, file a bug with component Speed>Bisection
Owner: kojii@chromium.org
Status: Assigned (was: Duplicate)
Un-duping as this is a performance issue, and the duped issue is a test failure.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ea04e064baa8615e5ef9702050ce6a605435c57

commit 0ea04e064baa8615e5ef9702050ce6a605435c57
Author: Annie Sullivan <sullivan@chromium.org>
Date: Fri Nov 03 18:38:38 2017

Revert "Add CrashKey to LazyLineBreakIterator on Android"

This reverts commit 811fe6a25ddee5065812bf50733de963e58832cb.

Reason for revert: This CL slowed down the blink_perf.paint test to the point where it times out, and also caused several other performance regressions.

Bug:  780502 ,  781166 ,  781167 ,  781245 ,  781245 

Original change's description:
> Add CrashKey to LazyLineBreakIterator on Android
> 
> This patch adds CrashKey to investigate where crashes occur.
> 
> LazyLineBreakIterator::IsBreakable() has inline and templates
> that the stack quality is low.
> 
> Bug: 756624
> Change-Id: I657b18aa1cb74b2587104352b4a3e826522b6ba8
> Reviewed-on: https://chromium-review.googlesource.com/737710
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Luke Halliwell <halliwell@chromium.org>
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#512825}

TBR=falken@chromium.org,eae@chromium.org,kojii@chromium.org,drott@chromium.org,halliwell@chromium.org,rsesek@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 756624
Change-Id: Ib5dbe2ea94fe719d96c2bbfd4a908f2d226aa8ae
Reviewed-on: https://chromium-review.googlesource.com/753529
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513852}
[modify] https://crrev.com/0ea04e064baa8615e5ef9702050ce6a605435c57/android_webview/common/crash_reporter/crash_keys.cc
[modify] https://crrev.com/0ea04e064baa8615e5ef9702050ce6a605435c57/chrome/common/crash_keys.cc
[modify] https://crrev.com/0ea04e064baa8615e5ef9702050ce6a605435c57/chromecast/crash/cast_crash_keys.cc
[modify] https://crrev.com/0ea04e064baa8615e5ef9702050ce6a605435c57/third_party/WebKit/Source/platform/text/TextBreakIterator.cpp

Comment 6 by kojii@chromium.org, Nov 5 2017

Status: Duplicate (was: Assigned)

Sign in to add a comment