New issue
Advanced search Search tips

Issue 781164 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in gl::GLApiBase::glPopGroupMarkerEXTFn

Project Member Reported by ClusterFuzz, Nov 3 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4844260880023552

Fuzzer: libFuzzer_gpu_angle_passthrough_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  gl::GLApiBase::glPopGroupMarkerEXTFn
  gpu::gles2::GLES2DecoderPassthroughImpl::DoPopGroupMarkerEXT
  gpu::error::Error gpu::gles2::GLES2DecoderPassthroughImpl::DoCommandsImpl<false>
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=512885:512922

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4844260880023552

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 3 2017

Components: Internals>GPU>Internals
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 3 2017

Labels: Test-Predator-AutoOwner
Owner: piman@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/18afd13d94183587e05cb04031f2ee7d56ba98d9 (gpu fuzzers: AddRef on null pointers).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 3 by piman@chromium.org, Nov 3 2017

Cc: piman@chromium.org
Owner: geoffl...@chromium.org
Labels: Test-Predator-Auto-CC
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner
Labels: -Test-Predator-Auto-CC
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/73dcc60c868fddb884d4c8e48aa45b0863930718

commit 73dcc60c868fddb884d4c8e48aa45b0863930718
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Nov 09 16:00:06 2017

Support more always-available extensions in ContextNULL.

Add some extensions that are required by the passthrough command decoder
and exposed on all other ANGLE backends.

BUG= 781164 

Change-Id: Ie83143effd2460122e7a093c658f217fb460d8b2
Reviewed-on: https://chromium-review.googlesource.com/759132
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/73dcc60c868fddb884d4c8e48aa45b0863930718/src/libANGLE/renderer/null/ContextNULL.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/6fdde9bc7195a3e62a013973adfa82c2481fc5ab

commit 6fdde9bc7195a3e62a013973adfa82c2481fc5ab
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Thu Nov 09 17:17:34 2017

Roll skia/third_party/externals/angle2/ 70b715c9b..73dcc60c8 (3 commits)

https://chromium.googlesource.com/angle/angle.git/+log/70b715c9b8bc..73dcc60c868f

$ git log 70b715c9b..73dcc60c8 --date=short --no-merges --format='%ad %ae %s'
2017-11-08 geofflang Support more always-available extensions in ContextNULL.
2017-11-08 svaisanen Support B8G8R8A8_UNORM_SRGB as D3D11 texture format
2017-10-24 geofflang Validate GL_COLOR_ATTACHMENT0 separately from the draw buffers attachments.

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 781164 


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE
TBR=egdaniel@google.com

Change-Id: I67d8f1cb19935755a4bda06e7c7e5fa8d098a72d
Reviewed-on: https://skia-review.googlesource.com/69302
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/6fdde9bc7195a3e62a013973adfa82c2481fc5ab/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d33900d66fb19ac42985e051b7a762b1ad75f0e7

commit d33900d66fb19ac42985e051b7a762b1ad75f0e7
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Thu Nov 09 19:38:54 2017

Roll src/third_party/angle/ 70b715c9b..73dcc60c8 (3 commits)

https://chromium.googlesource.com/angle/angle.git/+log/70b715c9b8bc..73dcc60c868f

$ git log 70b715c9b..73dcc60c8 --date=short --no-merges --format='%ad %ae %s'
2017-11-08 geofflang Support more always-available extensions in ContextNULL.
2017-11-08 svaisanen Support B8G8R8A8_UNORM_SRGB as D3D11 texture format
2017-10-24 geofflang Validate GL_COLOR_ATTACHMENT0 separately from the draw buffers attachments.

Created with:
  roll-dep src/third_party/angle
BUG= 781164 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I654e15d3c7d65f063aeea18fc4e9ad1c01d3c80c
Reviewed-on: https://chromium-review.googlesource.com/760669
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515245}
[modify] https://crrev.com/d33900d66fb19ac42985e051b7a762b1ad75f0e7/DEPS

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e71fb3a775baa675546516403080094d2628d92

commit 4e71fb3a775baa675546516403080094d2628d92
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Fri Nov 10 01:54:41 2017

Roll src/third_party/skia/ 0d8766c84..22499b096 (19 commits)

https://skia.googlesource.com/skia.git/+log/0d8766c84c80..22499b0969ac

$ git log 0d8766c84..22499b096 --date=short --no-merges --format='%ad %ae %s'
2017-11-09 bungeman Update mirror-dev for *-dev:amd64 packages.
2017-11-09 herb Revert "Gauss filter calculation"
2017-11-09 reed Revert "Revert "Remove MakeForLocalSpace since picture image is sufficient""
2017-11-09 brianosman Include target CS in SkColorSpaceXformCanvas' image info
2017-11-09 caryclark replace some points with vectors to clarify documentation
2017-11-09 jvanverth Move ms meter from the title bar to the display
2017-11-09 egdaniel Dynamically load the vulkan library in our test tools
2017-11-09 ethannicholas renamed GrPrimitiveEdgeType / GrProcessorEdgeType to GrClipEdgeType
2017-11-09 halcanary SkTypeface_win_dw, SkTypeface_Mac: set NotEmbeddable_FontFlag
2017-11-09 angle-deps-roller Roll skia/third_party/externals/angle2/ 661fc487d..9e888a46f (2 commits)
2017-11-03 herb Gauss filter calculation
2017-11-09 angle-deps-roller Roll skia/third_party/externals/angle2/ 73dcc60c8..661fc487d (1 commit)
2017-11-09 kjlubick Use validating buffer for skpath
2017-11-09 reed Revert "Remove MakeForLocalSpace since picture image is sufficient"
2017-11-09 mtklein remove SkFixedMul_arm()
2017-11-09 bungeman Update doc and example for SkPaint::FontMetrics.
2017-11-09 benjaminwagner Guard VFPv3 ASM with an ifdef.
2017-11-09 ahaas [v8-platform] Store the platform in a unique_ptr
2017-11-09 angle-deps-roller Roll skia/third_party/externals/angle2/ 70b715c9b..73dcc60c8 (3 commits)

Created with:
  roll-dep src/third_party/skia
BUG=772651, 781164 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: I2244a33b3cab5564b38e5fb69ae58a5ad87e6f35
Reviewed-on: https://chromium-review.googlesource.com/762400
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515414}
[modify] https://crrev.com/4e71fb3a775baa675546516403080094d2628d92/DEPS

Project Member

Comment 12 by ClusterFuzz, Nov 10 2017

ClusterFuzz has detected this issue as fixed in range 515212:515249.

Detailed report: https://clusterfuzz.com/testcase?key=4844260880023552

Fuzzer: libFuzzer_gpu_angle_passthrough_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  gl::GLApiBase::glPopGroupMarkerEXTFn
  gpu::gles2::GLES2DecoderPassthroughImpl::DoPopGroupMarkerEXT
  gpu::error::Error gpu::gles2::GLES2DecoderPassthroughImpl::DoCommandsImpl<false>
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=512885:512922
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=515212:515249

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4844260880023552

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Nov 10 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4844260880023552 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/5d5253a3360a90d47e3d24d4bf30997664fc7364

commit 5d5253a3360a90d47e3d24d4bf30997664fc7364
Author: Geoff Lang <geofflang@chromium.org>
Date: Fri Nov 24 00:07:28 2017

Clean up usage of EXT_debug_marker and KHR_debug in the backends.

In RendererGL, the EXT_debug_marker functions were calling the
KHR_debug entry points, now they fall back only when EXT_debug_marker is
missing.

Separated the ContextImpl methods for the two extensions.

BUG= 781164 

Change-Id: I615b5965b705e55eb730ebefa6e27e0ee6d86c31
Reviewed-on: https://chromium-review.googlesource.com/786337
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/gl/DispatchTableGL_autogen.h
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/d3d/d3d11/Context11.cpp
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/gl/ContextGL.h
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/gl/ContextGL.cpp
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/gl/null_functions.cpp
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/ContextImpl.h
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/vulkan/ContextVk.h
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/Context.cpp
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/gl/DispatchTableGL_autogen.cpp
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/gl/null_functions.h
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/null/ContextNULL.cpp
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/gl/RendererGL.cpp
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/gl/RendererGL.h
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/d3d/d3d9/Context9.cpp
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/gl/renderergl_utils.cpp
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/gl/gl_bindings_data.json
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/vulkan/ContextVk.cpp
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/d3d/d3d9/Context9.h
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/null/ContextNULL.h
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/gl/functionsgl_typedefs.h
[modify] https://crrev.com/5d5253a3360a90d47e3d24d4bf30997664fc7364/src/libANGLE/renderer/d3d/d3d11/Context11.h

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e7457e6771ead2d01ce9a60d64da5422f6d763d

commit 3e7457e6771ead2d01ce9a60d64da5422f6d763d
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Fri Nov 24 01:24:12 2017

Roll src/third_party/angle/ 1f73b7c6d..5d5253a33 (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/1f73b7c6d4a0..5d5253a3360a

$ git log 1f73b7c6d..5d5253a33 --date=short --no-merges --format='%ad %ae %s'
2017-11-22 geofflang Clean up usage of EXT_debug_marker and KHR_debug in the backends.

Created with:
  roll-dep src/third_party/angle
BUG= 781164 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I819e0b6fcf37532cdf6a82f697167ef4caa16467
Reviewed-on: https://chromium-review.googlesource.com/788188
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519042}
[modify] https://crrev.com/3e7457e6771ead2d01ce9a60d64da5422f6d763d/DEPS

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/e5d4f2c76b39da672c8b251eb4e8f8a66d888014

commit e5d4f2c76b39da672c8b251eb4e8f8a66d888014
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Fri Nov 24 01:29:20 2017

Roll skia/third_party/externals/angle2/ 1f73b7c6d..5d5253a33 (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/1f73b7c6d4a0..5d5253a3360a

$ git log 1f73b7c6d..5d5253a33 --date=short --no-merges --format='%ad %ae %s'
2017-11-22 geofflang Clean up usage of EXT_debug_marker and KHR_debug in the backends.

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 781164 


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE
TBR=herb@google.com

Change-Id: I7d1e3e87abb5fdc2cd93fb24c3a736fee8880d06
Reviewed-on: https://skia-review.googlesource.com/75640
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/e5d4f2c76b39da672c8b251eb4e8f8a66d888014/DEPS

Project Member

Comment 17 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2e393669f34d87ad2ca13f2cf8df1f1b0a0f6bc

commit f2e393669f34d87ad2ca13f2cf8df1f1b0a0f6bc
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Fri Nov 24 03:00:55 2017

Roll src/third_party/skia/ 19f776efb..e5d4f2c76 (1 commit)

https://skia.googlesource.com/skia.git/+log/19f776efbdbb..e5d4f2c76b39

$ git log 19f776efb..e5d4f2c76 --date=short --no-merges --format='%ad %ae %s'
2017-11-24 angle-deps-roller Roll skia/third_party/externals/angle2/ 1f73b7c6d..5d5253a33 (1 commit)

Created with:
  roll-dep src/third_party/skia
BUG= 781164 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: Id4140fc9ecaece64e3d396b71f243770f165d2c2
Reviewed-on: https://chromium-review.googlesource.com/788593
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519048}
[modify] https://crrev.com/f2e393669f34d87ad2ca13f2cf8df1f1b0a0f6bc/DEPS

Project Member

Comment 18 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/c7c0d1c1b08b584a7b2a64bbf9ce1ca7016aa799

commit c7c0d1c1b08b584a7b2a64bbf9ce1ca7016aa799
Author: Geoff Lang <geofflang@chromium.org>
Date: Fri Nov 24 15:28:44 2017

Expose OES_vertex_array_object on the GL backend.

BUG= 781164 

Change-Id: I92738c0f45efdf0efaecede509648fd5a4d00b8b
Reviewed-on: https://chromium-review.googlesource.com/786338
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/c7c0d1c1b08b584a7b2a64bbf9ce1ca7016aa799/src/libANGLE/renderer/gl/renderergl_utils.cpp

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/73010a0b397180f86d8ae67115ce1ca578b6c84b

commit 73010a0b397180f86d8ae67115ce1ca578b6c84b
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Fri Nov 24 16:57:41 2017

Roll skia/third_party/externals/angle2/ 7881cfdfb..ed2e6aa55 (3 commits)

https://chromium.googlesource.com/angle/angle.git/+log/7881cfdfb586..ed2e6aa5547c

$ git log 7881cfdfb..ed2e6aa55 --date=short --no-merges --format='%ad %ae %s'
2017-11-23 jiajia.qin GLES31: Use more compact entry point style.
2017-11-22 geofflang Expose OES_vertex_array_object on the GL backend.
2017-11-22 jiajia.qin GLES31: Auto-generate entry points source.

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 781164 


The AutoRoll server is located here: https://angle-skia-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE
TBR=herb@google.com

Change-Id: Id0605c347bafeb73efe178ae65343cfcffa58b03
Reviewed-on: https://skia-review.googlesource.com/75760
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/73010a0b397180f86d8ae67115ce1ca578b6c84b/DEPS

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adaa835f63e7ed6dc4e4fa0c1b9e483250a63446

commit adaa835f63e7ed6dc4e4fa0c1b9e483250a63446
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Fri Nov 24 17:43:44 2017

Roll src/third_party/angle/ cb59a9097..ed2e6aa55 (2 commits)

https://chromium.googlesource.com/angle/angle.git/+log/cb59a9097aed..ed2e6aa5547c

$ git log cb59a9097..ed2e6aa55 --date=short --no-merges --format='%ad %ae %s'
2017-11-23 jiajia.qin GLES31: Use more compact entry point style.
2017-11-22 geofflang Expose OES_vertex_array_object on the GL backend.

Created with:
  roll-dep src/third_party/angle
BUG= 781164 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: If3b0875220444820bbcd1a7078ccfb4ba2099439
Reviewed-on: https://chromium-review.googlesource.com/789350
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519140}
[modify] https://crrev.com/adaa835f63e7ed6dc4e4fa0c1b9e483250a63446/DEPS

Project Member

Comment 21 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88c543addae8e98da2c3e6475825bbb12f67aad0

commit 88c543addae8e98da2c3e6475825bbb12f67aad0
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Fri Nov 24 18:35:51 2017

Roll src/third_party/skia/ 1b8fae37e..73010a0b3 (1 commit)

https://skia.googlesource.com/skia.git/+log/1b8fae37e575..73010a0b3971

$ git log 1b8fae37e..73010a0b3 --date=short --no-merges --format='%ad %ae %s'
2017-11-24 angle-deps-roller Roll skia/third_party/externals/angle2/ 7881cfdfb..ed2e6aa55 (3 commits)

Created with:
  roll-dep src/third_party/skia
BUG= 781164 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: Ieb3e6b374a0f05113d0e569a6f242e4a6cbf98ad
Reviewed-on: https://chromium-review.googlesource.com/789371
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519145}
[modify] https://crrev.com/88c543addae8e98da2c3e6475825bbb12f67aad0/DEPS

Sign in to add a comment