Non-Regression:Weird behavior is seen while discarding photo in video mode of settings/changePicture page |
||||||
Issue descriptionChrome Version:64.0.3256.0/10093.0.0 dev channel Peppy,Paine,Kip OS:Chrome OS What steps will reproduce the problem? (1)Sign into user->goto chrome://settings/changePicture (2)In video mode >>while capturing,click'Take photo' button multiple times(4/5) (3)Now try to discard the captured video and Observe the weird behavior(please refer video) Actual: (a)Captured image in video mode doesn't get discarded even after clicking discard button/ (b)weird blinking of image is seen at camera perspective box/ (c)also some times picture is seen discarded at frame not in right side options Expected:After clicking discard button,it should get discard This is a Non-Regression issue seen from M-63 Note:Issue is not seen in Linux,Windows OS @reveman: Please confirm the issue.
,
Nov 3 2017
I can reproduce this if clicking fast in single photo mode too. That's a regression that also needs to be fixed in M63.
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d313402700cf122830699f78bf4926ed27eef78d commit d313402700cf122830699f78bf4926ed27eef78d Author: David Reveman <reveman@chromium.org> Date: Tue Nov 07 02:26:58 2017 Change Picture: Prevent new photo capture while capture is in progress This prevents double-clicks on capture button from causing bad behavior. Bug: 781160 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I976391a94741b95911fab412981a40f7e4de0696 Reviewed-on: https://chromium-review.googlesource.com/753404 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#514359} [modify] https://crrev.com/d313402700cf122830699f78bf4926ed27eef78d/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.js
,
Nov 7 2017
,
Nov 7 2017
Let's have this verified on tot first before approving merge to M63 branch.
,
Nov 8 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 14 2017
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0cc9dee24fd8cb039a57c373f0a2d47db7c5f4f5 commit 0cc9dee24fd8cb039a57c373f0a2d47db7c5f4f5 Author: David Reveman <reveman@chromium.org> Date: Wed Nov 15 02:41:36 2017 Change Picture: Prevent new photo capture while capture is in progress This prevents double-clicks on capture button from causing bad behavior. TBR=reveman@chromium.org (cherry picked from commit d313402700cf122830699f78bf4926ed27eef78d) Bug: 781160 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I976391a94741b95911fab412981a40f7e4de0696 Reviewed-on: https://chromium-review.googlesource.com/753404 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#514359} Reviewed-on: https://chromium-review.googlesource.com/770530 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#501} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/0cc9dee24fd8cb039a57c373f0a2d47db7c5f4f5/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.js |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by reve...@chromium.org
, Nov 3 2017