New issue
Advanced search Search tips

Issue 781154 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Import Web Platform Tests for WOFF2

Project Member Reported by fw...@igalia.com, Nov 3 2017

Issue description

Components: Blink>WebFonts

Comment 3 by fw...@igalia.com, Nov 24 2017

Cc: drott@chromium.org behdad@chromium.org
http://www.w3c-test.org/css/WOFF2/

Thanks. I think they are useful and I know how to import more WPT tests into chromium. It's just that I'm not sure when I'll have time to try it and check exactly which tests are failing/passing... So for now I'm just opening this for the record.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db365e5d3aee65099998a88c38bd6bbea2c7f627

commit db365e5d3aee65099998a88c38bd6bbea2c7f627
Author: Frédéric Wang <fwang@igalia.com>
Date: Fri Jun 01 16:17:43 2018

Unskip WOFF2 WPT tests

The WOFF2 reftests from the Fonts WG have recently been modified to load
required support fonts as Web fonts and hence remove the need of manual
installation (*). The tests have already been imported into WebKit and
Mozilla repositories. This CL unskips the WOFF2 test suite in Chromium
too, in order to import the tests at the next synchronization cycle.

(*) https://github.com/w3c/web-platform-tests/commit/31c2aeb1e71c5490f8fd304d731c18848065ad24

R=foolip@chromium.org

Bug: 781154
Change-Id: I91f73c584c11d46116182beebd1d0e8d24b82566
Reviewed-on: https://chromium-review.googlesource.com/1073148
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#563665}
[modify] https://crrev.com/db365e5d3aee65099998a88c38bd6bbea2c7f627/third_party/WebKit/LayoutTests/W3CImportExpectations

fwang@, after this change landed, wpt-importer has been failing to import new tests. You can see the failed imports here:
https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19013
...
https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19030

The problem was that the expectations created by rebaselining didn't pass in CQ. Normally when this happens the solution is to add failing expectations to TestExpectations to get the import through, and then sort it out afterwards. Unfortunately, here I observed differences in which tests fails from run to run:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/108375
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/108367

Suspecting that this may be due to flaky tests, I instead reverted #5. Importing the tests manually and running them 100 times or so locally to check for flakiness is probably best.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b022136d167f00494fc0d1439a9fa83020569a51

commit b022136d167f00494fc0d1439a9fa83020569a51
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Sun Jun 03 21:32:58 2018

Revert "Unskip WOFF2 WPT tests"

This reverts commit db365e5d3aee65099998a88c38bd6bbea2c7f627.

Reason for revert: WOFF2 test blocking wpt-importer, seemingly flaky.

Original change's description:
> Unskip WOFF2 WPT tests
>
> The WOFF2 reftests from the Fonts WG have recently been modified to load
> required support fonts as Web fonts and hence remove the need of manual
> installation (*). The tests have already been imported into WebKit and
> Mozilla repositories. This CL unskips the WOFF2 test suite in Chromium
> too, in order to import the tests at the next synchronization cycle.
>
> (*) https://github.com/w3c/web-platform-tests/commit/31c2aeb1e71c5490f8fd304d731c18848065ad24
>
> R=​foolip@chromium.org
>
> Bug: 781154
> Change-Id: I91f73c584c11d46116182beebd1d0e8d24b82566
> Reviewed-on: https://chromium-review.googlesource.com/1073148
> Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
> Commit-Queue: Frédéric Wang <fwang@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#563665}

TBR=foolip@chromium.org,fwang@igalia.com

No-Try: true
Bug: 781154
Change-Id: I685e21681fa1f34a128edf54107cb9907d6eba14
Reviewed-on: https://chromium-review.googlesource.com/1084271
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563976}
[modify] https://crrev.com/b022136d167f00494fc0d1439a9fa83020569a51/third_party/WebKit/LayoutTests/W3CImportExpectations

Sign in to add a comment