New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781141 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Preview picture is still seen even on clicking 'Discard photo' option in 'Set your profile picture' screen

Project Member Reported by mmanchala@chromium.org, Nov 3 2017

Issue description

Chrome Version: 64.0.3256.0/10093.0.0 dev channel Peppy,Kip and Paine
OS: Chrome


What steps will reproduce the problem?
(1)Recover build -> Sign into User which already has default 'Google profile picture' and click on next button
(2)Now in 'Set your profile picture' screen -> Click on 'Take photo' option -> So that Camera screen is seen -> Press 'Enter' button and picture is captured
(3)Now try to discard photo and observe photo gets discarded from 'Photo from internal camera' option but still preview picture is seen (Please refer video)

Expected: On clicking 'Discard photo' picture should get discarded and focus should traverse to  default 'Google profile picture' screen
 
Actual: Instead even on clicking 'Discard photo' option photo gets discarded from 'Photo from internal camera' option but still preview picture is seen with  'Discard photo' option and on clicking it nothing happens

This is Regression issue as same is working fine in 63.0.3238.0/10028.0.0 dev-channel Peppy.

@stevenjb : Please confirm the Issue
 
Actual_PictureDoesnotGetDisacrded.mp4
11.5 MB View Download
Owner: reve...@chromium.org
I'll take this. Probably regression from one of my recent fixes.
Cc: steve...@chromium.org
I can't reproduce this after applying https://chromium-review.googlesource.com/c/chromium/src/+/753404 so it's possible that fixes both issues.
Hi, this is tagged as a beta blocker for M64.  We're not that far out and this bug hasn't been updated in a while.  Ping?  Thanks...

Status: Fixed (was: Assigned)
I can't reproduce this so I think it was fixed with that other bug. mmanchala@, please re-open if you can still repo.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.
Status: Assigned (was: Fixed)
Able to reproduce the issue on latest M-65 i.e. on 65.0.3287.0/10203.0.0 Kip. 
Re-opening this issue as per comment #4

Thanks..!!
Please re-evaluate today (Monday, 11-Dec) re: Beta Blocker Status.  We're targeting Beta for tomorrow, so please update if a) this isn't blocking, b) the impacted boards can be identified, c) this is resolved / not reproducible, d) a merge / fix can be submitted today.  Thanks!

Comment 8 by gkihumba@google.com, Dec 12 2017

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Marking this as RBS as it should not gate beta.

Comment 9 by gkihumba@google.com, Dec 12 2017

Re. #8: functionality is generally fine
Ping as no traction in some time.  Please eval as a stable blocker.
I still can't repro this. I think it's a duplicate of 786887 that was fixed on Dec 2: https://chromium.googlesource.com/chromium/src/+/e5a074a4c902e83f0d50cb06e9b6f400702333ba
Labels: -Merge-TBD -M-64 M-65
Seems like this was only repro'd on M65 (c#6) back in Dec
Still repro?
If no one has seen this please close it, this is marked as blocking stable 65 and we are only a few weeks away.
Owner: mmanchala@chromium.org
Status: Fixed (was: Assigned)
Is this still reproducible? Is it specific to Kip? Please re-open with some more details if still an issue.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.
Project Member

Comment 16 by sheriffbot@chromium.org, Apr 4 2018

Labels: -Merge-TBD
Owner: reve...@chromium.org
C#14>>

Issue is working fine on M-69 dev 69.0.3497.24/10895.11.0.It is not specific to Kip device.

Thanks..!!
Cc: -reve...@chromium.org

Sign in to add a comment