LEGEND elements force display:block
Reported by
tgn...@gmail.com,
Nov 3 2017
|
|||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36 Steps to reproduce the problem: 1. make legend tag and add some text 2. apply inline block style to legend tag 3. then, you can see legend block consume all length instead of the contents length in legend tag. What is the expected behavior? legend tag applied by inline-block style should consume the length of the contents in its tag. What went wrong? css style. Did this work before? Yes 60 version worked correctly. Chrome version: 61.0.3163.100 Channel: n/a OS Version: OS X 10.12.6 Flash Version:
,
Nov 3 2017
https://jsfiddle.net/6naL97vm/ you can see in this page. please check a difference between latest IE and chrome.
,
Nov 3 2017
,
Nov 4 2017
,
Nov 4 2017
Bisect info: 480789 (good) - 480791 (bad) https://chromium.googlesource.com/chromium/src/+log/14f53c5b..8f3cf861?pretty=fuller Suspecting r480791 - 8f3cf8617dc8c27d6b0155dd775d4beebd58d62c "Update LEGEND implementation to better match the spec" Landed in 61.0.3137.0 Looks like the new behavior is intended and correctly matches the updated specification: >overriding any explicit 'display' value The <legend> element can be used only in <fieldset>: https://html.spec.whatwg.org/multipage/form-elements.html#the-legend-element
,
Nov 6 2017
Tested on Chrome Stable#62.0.3202.75, Canary#64.0.3260.0 on Mac 10.12.6, Windows 10 and Ubuntu 14.04 and able to reproduce the issue. Please find the bisect info below: Chrome Good Build - 61.0.3136.0 (480665) Chrome Bad Build -61.0.3137.0 (481056) You are probably looking for a change made after 480790 (known good), but no later than 480791 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/758742204e186ac83e73b4a393bdfaa660e2ca15..8f3cf8617dc8c27d6b0155dd775d4beebd58d62c https://chromium.googlesource.com/chromium/src/+/8f3cf8617dc8c27d6b0155dd775d4beebd58d62c Review-URL: https://chromium-review.googlesource.com/535595 From the CL above, assigning the issue to the reviewer. @szager: Could you please look into the issue as we were unable to assign to mstensho@, pardon me if it has nothing to do with the above changes and if possible please assign it to owner concerned. Thanks!
,
Nov 7 2017
,
Nov 7 2017
,
Dec 5 2017
,
Aug 16
,
Aug 20
,
Sep 14
LEGEND elements are supposed to allow any display type, after blockification. Spec work in progress here: https://github.com/whatwg/html/pull/3934/files
,
Sep 14
Issue 879573 has been merged into this issue.
,
Sep 17
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bc5404659b20bec0948f0af3b3115fb9d8664fa commit 3bc5404659b20bec0948f0af3b3115fb9d8664fa Author: Morten Stenshorne <mstensho@chromium.org> Date: Wed Sep 19 15:19:03 2018 Allow any blockified display type for LEGEND. Fixed one test that I expected to pass, but didn't because it was pointing to the wrong ref. Fixed that, and now it passes. Updated some expectation files. More stuff from various tests (but not whole tests) is passing than before. Bug: 781135 Change-Id: Ieb1312b8bf13c7a45afe644ad2a58f3f955044b6 Reviewed-on: https://chromium-review.googlesource.com/1228073 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#592403} [modify] https://crrev.com/3bc5404659b20bec0948f0af3b3115fb9d8664fa/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/3bc5404659b20bec0948f0af3b3115fb9d8664fa/third_party/WebKit/LayoutTests/external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-display-expected.txt [add] https://crrev.com/3bc5404659b20bec0948f0af3b3115fb9d8664fa/third_party/WebKit/LayoutTests/external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-grid-flex-multicol-expected.txt [modify] https://crrev.com/3bc5404659b20bec0948f0af3b3115fb9d8664fa/third_party/WebKit/LayoutTests/external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-list-item.html [modify] https://crrev.com/3bc5404659b20bec0948f0af3b3115fb9d8664fa/third_party/WebKit/LayoutTests/platform/linux/external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-sans-fieldset-display-expected.txt [delete] https://crrev.com/3cbb8c9aeac96ef999816bf2ce2ffd826a08cfe4/third_party/WebKit/LayoutTests/platform/mac/external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-grid-flex-multicol-expected.txt [modify] https://crrev.com/3bc5404659b20bec0948f0af3b3115fb9d8664fa/third_party/WebKit/LayoutTests/platform/mac/external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-sans-fieldset-display-expected.txt [delete] https://crrev.com/3cbb8c9aeac96ef999816bf2ce2ffd826a08cfe4/third_party/WebKit/LayoutTests/platform/win/external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-grid-flex-multicol-expected.txt [modify] https://crrev.com/3bc5404659b20bec0948f0af3b3115fb9d8664fa/third_party/WebKit/LayoutTests/platform/win/external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-sans-fieldset-display-expected.txt [modify] https://crrev.com/3bc5404659b20bec0948f0af3b3115fb9d8664fa/third_party/blink/renderer/core/css/resolver/style_adjuster.cc
,
Sep 19
|
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by woxxom@gmail.com
, Nov 3 2017