MacViews: Get Translate Bubble Ready |
||
Issue descriptionChrome Version : 64.0.3251.0 OS Version: OS X 10.12.6 We currently use the infobar on Mac. The Translate bubble seems to need more work before it's shippable. We should keep using the infobar for Harmony phase 1. There's a test failure interactive_ui_tests --gtest_filter=AutofillInteractiveTest.AutofillAfterTranslate --enable-features=SecondaryUiMd,ShowAllDialogsWithViewsToolkit And a partial fix in https://chromium-review.googlesource.com/752783 But it points to more problems. failure is a sad tab [42354:775:1103/184613.804484:FATAL:translate_helper.cc(336)] Check failed: false. 5 libchrome_dll.dylib 0x00000001218ea6df translate::TranslateHelper::RevertTranslation() + 175 6 libchrome_dll.dylib 0x0000000118f95fa2 translate::mojom::PageStubDispatch::Accept(translate::mojom::Page*, mojo::Message*) + 514 7 libchrome_dll.dylib 0x00000001218ec143 translate::mojom::PageStub<mojo::RawPtrImplRefTraits<translate::mojom::Page> >::Accept(mojo::Message*) + 83 8 libbindings.dylib 0x000000010efad922 mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) + 6002 9 libbindings.dylib 0x000000010efac1a1 mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept(mojo::Message*) + 33 10 libbindings.dylib 0x000000010efaa2b5 mojo::FilterChain::Accept(mojo::Message*) + 821 bool TranslateHelper::IsTranslateLibAvailable() returns false. So I don't know how functional this UI is on Mac.
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26200f5525047de3095d426af3b6fdf4744f7e49 commit 26200f5525047de3095d426af3b6fdf4744f7e49 Author: Trent Apted <tapted@chromium.org> Date: Wed Dec 20 00:54:05 2017 MacViews: Fix Translate Bubble Anchoring Currently translate _bubble_ tests on Mac (not the info bar tests) fail with a DCHECK because the translate bubble does not currently anchor properly under MacViews. To Anchor properly the bubble needs a parent window set before calling Widget::Show(). Fix that, and expand test coverage on Mac to include tests for the bubble. Note the translate bubble is not enabled by default on Mac (m65 will continue to use infobars). Enables on Mac: - AutofillInteractiveTest.AutofillAfterTranslate - TranslateBubbleViewBrowserTest.* (3 tests) Bug: 781134 , 795987 , 507442 Change-Id: I27f8489ad84eb90997ad6f319b178942a07a7a51 Reviewed-on: https://chromium-review.googlesource.com/752783 Reviewed-by: Michael Martis <martis@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#525201} [modify] https://crrev.com/26200f5525047de3095d426af3b6fdf4744f7e49/chrome/browser/autofill/autofill_interactive_uitest.cc [rename] https://crrev.com/26200f5525047de3095d426af3b6fdf4744f7e49/chrome/browser/ui/cocoa/translate/translate_bubble_test_utils_views_cocoa.mm [modify] https://crrev.com/26200f5525047de3095d426af3b6fdf4744f7e49/chrome/browser/ui/views/translate/translate_bubble_view.cc [modify] https://crrev.com/26200f5525047de3095d426af3b6fdf4744f7e49/chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc [modify] https://crrev.com/26200f5525047de3095d426af3b6fdf4744f7e49/chrome/test/BUILD.gn
,
Mar 7 2018
Also note other get-Translate-ready for Mac work in 814477
,
Mar 23 2018
MacViews triage: this happened (done by anthonyvd@) and this work is shipping in M66. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Nov 3 2017