New issue
Advanced search Search tips

Issue 781077 link

Starred by 3 users

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Autofill-Fixit


Sign in to add a comment

Replace usage of base::WrapUnique in Autofill code

Project Member Reported by jsaul@google.com, Nov 3 2017

Issue description

Comment 1 by jsaul@google.com, Dec 6 2017

Cc: jsaul@google.com
Owner: ----
Status: Available (was: Assigned)

Comment 2 by ma...@chromium.org, May 1 2018

Status: Untriaged (was: Available)

Comment 3 by ma...@chromium.org, May 15 2018

Labels: Hotlist-GoodFirstBug
Status: Available (was: Untriaged)
Owner: wuandy@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2

commit 21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2
Author: Hui(Andy) Wu <wuandy@chromium.org>
Date: Wed Dec 19 16:59:27 2018

[Autofill] Replace base::WrapUnique with std smart pointer functions.

This CL replaces the usage of base::WrapUnique with std::make_unique to
eliminate the usage of 'new'.

Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=781077
Change-Id: I8b77b131417cf07d1e8f2b2b7dbc20ef2cf5f275
Reviewed-on: https://chromium-review.googlesource.com/c/1382857
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Hui Wu <wuandy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617859}
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/chrome/browser/autofill/manual_filling_controller_impl.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/chrome/browser/autofill/manual_filling_controller_impl.h
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/content/browser/content_autofill_driver_factory.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/content/browser/content_autofill_driver_factory.h
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/address_field_unittest.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/address_normalizer_impl.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/autofill_address_util.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/credit_card_field.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/credit_card_field.h
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/credit_card_field_unittest.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/email_field.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/email_field.h
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/name_field.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/name_field_unittest.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/phone_field_unittest.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/search_field_unittest.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.h
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.h
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/browser/webdata/web_data_service_unittest.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/core/common/autofill_l10n_util.cc
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/ios/browser/autofill_driver_ios_webframe.h
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/ios/browser/autofill_driver_ios_webframe.mm
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/ios/browser/autofill_driver_ios_webstate.h
[modify] https://crrev.com/21aa74d6c058e9ffdcb1ad1792ad72f23f590ed2/components/autofill/ios/browser/autofill_driver_ios_webstate.mm

Sign in to add a comment