New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781072 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

SafeArchiveAnalyzer should be servicified.

Project Member Reported by jcivelli@chromium.org, Nov 3 2017

Issue description

As part of the effort of removing UtilityprocessHost, SafeArchiveAnalyzer should be servicified and UtilityprocessHost shoudl be removed from:
chrome/browser/safe_browsing/download_protection/sandboxed_dmg_analyzer_mac.h
chrome.mojom.SafeArchiveAnalyzer SANDBOX
chrome/browser/safe_browsing/download_protection/sandboxed_zip_analyzer.h

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2

commit d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2
Author: Jay Civelli <jcivelli@google.com>
Date: Fri Nov 10 03:37:05 2017

Servicifying SafeArchiveAnalyzer.

Making the SafeArchiveAnalyzer interface part of the Chrome file_util
service. Moving the associated calling classes, SandboxedZipAnalyzer
and SandboxedDmgAnalyzer to chrome/services/file_util/public/cpp,
making them the client library to the service. The unit-tests have
been moved as well.

Bug:  781072 
Change-Id: I2947ca13742baef85ab4f9d539f743ea427c883e
Reviewed-on: https://chromium-review.googlesource.com/752555
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515441}
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/app/BUILD.gn
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/app/generated_resources.grd
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/browser/chrome_content_utility_manifest_overlay.json
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/browser/safe_browsing/BUILD.gn
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/browser/safe_browsing/download_protection/check_client_download_request.cc
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/browser/safe_browsing/download_protection/check_client_download_request.h
[delete] https://crrev.com/304f7b1742149d57b20e90a3d3154ac6c1c520cb/chrome/browser/safe_browsing/download_protection/sandboxed_dmg_analyzer_mac.cc
[delete] https://crrev.com/304f7b1742149d57b20e90a3d3154ac6c1c520cb/chrome/browser/safe_browsing/download_protection/sandboxed_zip_analyzer.h
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/common/BUILD.gn
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/common/DEPS
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/common/common_message_generator.h
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/common/safe_browsing/BUILD.gn
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/BUILD.gn
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/DEPS
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/file_util_service.cc
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/manifest.json
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/public/cpp/BUILD.gn
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/public/cpp/DEPS
[add] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/public/cpp/sandboxed_dmg_analyzer_mac.cc
[rename] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/public/cpp/sandboxed_dmg_analyzer_mac.h
[rename] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/public/cpp/sandboxed_dmg_analyzer_mac_unittest.cc
[rename] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/public/cpp/sandboxed_zip_analyzer.cc
[add] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/public/cpp/sandboxed_zip_analyzer.h
[rename] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/public/cpp/sandboxed_zip_analyzer_unittest.cc
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/public/interfaces/BUILD.gn
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/public/interfaces/OWNERS
[rename] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/public/interfaces/safe_archive_analyzer.mojom
[rename] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/public/interfaces/safe_archive_analyzer.typemap
[rename] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/public/interfaces/safe_archive_analyzer_param_traits.h
[add] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/safe_archive_analyzer.cc
[add] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/services/file_util/safe_archive_analyzer.h
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/test/BUILD.gn
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/typemaps.gni
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/utility/BUILD.gn
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/utility/safe_browsing/mac/dmg_analyzer.cc
[modify] https://crrev.com/d5b61433a7efc6d3ad90a9bb6f7a5304bbe0b8c2/chrome/utility/safe_browsing/mac/dmg_analyzer.h

Status: Fixed (was: Untriaged)

Sign in to add a comment