New issue
Advanced search Search tips

Issue 781058 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 765490



Sign in to add a comment

Crash when taking Android "now on tap" snapshot of YouTube url

Project Member Reported by dmazz...@chromium.org, Nov 2 2017

Issue description

Chrome 64.0.3255.0
Android Nougat

Repro:
1. Open https://m.youtube.com/watch?v=3P6DWAwwViU&app=m in Chrome on Android
2. Scroll to the bottom and click on the disclosure triangle to display some comments
3. Long-press the Home button to bring up Google Assistant, which triggers getting a snapshot of the page currently visible (using accessibility)
4. Crash

These crash logs show the specific error:

https://crash.corp.google.com/browse?q=EXISTS%20(SELECT%201%20FROM%20UNNEST(productdata)%20WHERE%20key%3D%27ax_tree_error%27)&sql_dialect=googlesql&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D#samplereports

 
Blocking: 765490
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de17d566c402e75179dd38750885d4e7f329124f

commit de17d566c402e75179dd38750885d4e7f329124f
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Mon Nov 06 23:15:45 2017

Check return value from SerializeChanges in SnapshotAccessibilityTree

When generating a snapshot of the accessibility tree (for Google Assistant
or Now On Tap on Android) occasionally the serialization fails the first
time. We were ignoring the return value, leading to a crash later.

On one particular url (https://m.youtube.com/watch?v=3P6DWAwwViU&app=m)
I determined that serialization failed due to aria-owns rearranging the
tree. It succeeds the second time.

I tried for several hours to turn that page into a minimal repro, with
no luck. The bug disappears if I try to change the page, it seems
very sensitive to the exact details.

I think it's important to land this fix even without a
regression test.

Bug:  781058 ,765490
Change-Id: Iccd3b4e1b9f178b2c3be6da8784a656dbb0c904a
Reviewed-on: https://chromium-review.googlesource.com/752573
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514281}
[modify] https://crrev.com/de17d566c402e75179dd38750885d4e7f329124f/content/renderer/accessibility/render_accessibility_impl.cc

Status: Fixed (was: Assigned)

Sign in to add a comment