New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781056 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-XR
Proj-XR-VR



Sign in to add a comment

Press app button to exit msg shows up when entering webvr presentation

Project Member Reported by dbbrooks@chromium.org, Nov 2 2017

Issue description

Chrome Version: 64.0.3256.0 
OS: Android N
VRCore: 1.10.172754103

It doesn't seem like this is expected behavior. Especially when in cardboard mode. I'm not sure this message should show up even when Daydream is set to be default headset.


What steps will reproduce the problem?
(1) Set device to use cardboard as default headset
(2) Go to https://webvr.info/samples/XX-360-panorama.html
(3) Press enter VR button

What is the expected result? In cardboard mode, a message referring to an app button should not appear.

What happens instead? A msg saying "Press app button to exit" appears for a few seconds.

 
Owner: bshe@chromium.org
Status: Assigned (was: Untriaged)
Biao, could you please take a look at this?
Labels: Pri-2 Type-Bug
Labels: -Type-Bug M-64 Type-Bug-Regression
Note that this happens on Daydream headsets when you autopresent WebVR using NFC (Placing the device in the headset).


Cc: vollick@chromium.org
 Issue 797359  has been merged into this issue.
Labels: -Pri-2 Pri-1
Summary: Press app button to exit msg shows up when entering webvr presentation with NFC autopresent (was: Press app button to exit msg shows up when entering webvr presentation)

Comment 8 by bshe@chromium.org, Dec 28 2017

Labels: -Pri-1 Pri-2
Status: WontFix (was: Assigned)
Summary: Press app button to exit msg shows up when entering webvr presentation (was: Press app button to exit msg shows up when entering webvr presentation with NFC autopresent)
just checked on both TOT and beta (64.0.3282.29), can't reproduce the problem following steps in bug report. so mark as wont fix.
Status: Assigned (was: WontFix)
Hey Brian, still repros for me. It only happens when you autopresent using NFC though. Which I didn't include that detail in the original repro steps.
Were you using NFC to autopresent?
My mistake, I see now how following the repro steps listed here would not repro the issue. However, this issue was always only triggered by NFC, I just wrote the steps down incorrectly. I should have been more clear when I noted this in comment #4 and adjusted the title earlier.


Labels: -Pri-2 -M-64 M-65 Pri-1

Comment 13 by bshe@chromium.org, Jan 10 2018

Owner: ----
Status: Available (was: Assigned)
I see, in that case, I agree it is the same as 797359. Sorry I won't be able to work on this because of vacation. Could anyone (mthiesse, ymalik, vollic?) help with this? I think it is probably because of this line: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java?rcl=0a8f633e910ca85f4fc5ff4cf1f8cecca481e30c&l=1083

Components: -Blink>WebVR UI>Browser>VR
Owner: mthiesse@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a64fa42500c74c5f38f1f2f0deafe8c3c1887d0

commit 7a64fa42500c74c5f38f1f2f0deafe8c3c1887d0
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Thu Jan 18 00:03:58 2018

VR: Don't show "press App button" toast with VR browsing disabled

Bug:  781056 
Change-Id: I0bbd61d071ea50293b4600d61cb657bd42eadd12
Reviewed-on: https://chromium-review.googlesource.com/871801
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529958}
[modify] https://crrev.com/7a64fa42500c74c5f38f1f2f0deafe8c3c1887d0/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[modify] https://crrev.com/7a64fa42500c74c5f38f1f2f0deafe8c3c1887d0/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Status: Fixed (was: Started)
Hi Michael, the issue here is whether or not the toast should appear when a user does the following:

1. in 2D, goes to https://webvr.info/samples/03-vr-presentation.html
2. Places the phone in the Daydream headset
3. The WebVR presentation is auto-presented via NFC
4. Current behavior is that the toast appears in this case. 

Also, I noticed that the toast now appears even if the user presses the Enter VR button in step 2. This was not the case before. M63. So Is the expected behavior now to show this toast in both cases?

Status: Assigned (was: Fixed)
Status: Verified (was: Assigned)
Ah, actually, closing this as fixed and verified, since it fixes the cardboard mode case. (not showing toast)
Labels: Test-Complete

Sign in to add a comment