New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781043 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Breadcrumbs Stability File Is Sometimes Invalid

Project Member Reported by bcwh...@chromium.org, Nov 2 2017

Issue description

Chrome Version: HEAD
OS: Win

https://crash.corp.google.com/browse?q=product.Version%3E%3D%2764.0.3251.0%27%20AND%20product.Version%20LIKE%20%27__.%25.%25.%25%27%20AND%20product.name%20CONTAINS%20%27Chrome%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%20CONTAINS%20%27PersistentMemoryAllocator%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27base%3A%3APersistentMemoryAllocator%3A%3APersistentMemoryAllocator%27&sql_dialect=dremelsql&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D

These crashes are all due to a bad file that is failing a CHECK:

  CHECK(IsMemoryAcceptable(memory.base, size, page_size, readonly));

It looks like the |stability_file| (chrome_browser_field_trials_desktop.cc:132) is not valid for the metrics file, either because it the create parameters are invalid or something is wrong with the file.

The file is opened with CREATE_ALWAYS so I'm not sure how it could have existing contents that cause a problem.  I'll add a check to the CreateWithFile to avoid the crash but there's a bigger problem here.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4ba46b5b3c858371751121e65d728c925f053c9

commit f4ba46b5b3c858371751121e65d728c925f053c9
Author: Brian White <bcwhite@chromium.org>
Date: Fri Nov 03 18:45:43 2017

Handle bad files when creating tracker.

Bug:  781043 
Change-Id: Ie10d85da6e7c69b54af14c330de64902320d76fa
Reviewed-on: https://chromium-review.googlesource.com/753761
Reviewed-by: Pierre-Antoine Manzagol (departed) <manzagop@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513857}
[modify] https://crrev.com/f4ba46b5b3c858371751121e65d728c925f053c9/base/debug/activity_tracker.cc
[modify] https://crrev.com/f4ba46b5b3c858371751121e65d728c925f053c9/base/debug/activity_tracker.h

Status: Fixed (was: Started)
The calling code appears tolerant of a failure to create the file so I don't think anything else is necessary.

Sign in to add a comment