New issue
Advanced search Search tips

Issue 781042 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Chrome OS: no notification is shown upon receiving multipart SMS

Project Member Reported by benchan@chromium.org, Nov 2 2017

Issue description

The Chrome OS UI currently shows a notification upon receiving a SMS. However, no notification is shown upon receiving a multipart SMS (i.e. a SMS message that is too long and broken up into multiple parts to deliver).
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aac97fe5f3cb5890bedac2a2ba9fec6b3e8c16fc

commit aac97fe5f3cb5890bedac2a2ba9fec6b3e8c16fc
Author: Ben Chan <benchan@chromium.org>
Date: Tue Nov 07 01:15:59 2017

Chrome OS: Fix multi-part SMS handling in SMSClient.

SMSClient incorrectly assumes that a SMS is fully received upon
receiving an "Added" signal emitted from the
org.freedesktop.ModemManager1.Modem.Messaging interface by ModemManager.
For a multi-part SMS, the Added signal is emitted by ModemManager upon
receiving the first part and no further Added signal is emitted on
subsequent parts. As the SMS content isn't available in the first SMS
part, it results in no notification shown. This CL fixes SMSClient to
monitor the "State" property of the SMS object exposed by ModemManager
to determine when the SMS is fully received.

Bug:  781042 
Test: Verify that UI pops up a notification upon receiving a multi-part SMS.
Change-Id: Ide06e5cfafa3127c44a5df653ad701e05473615f
Reviewed-on: https://chromium-review.googlesource.com/754335
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514329}
[modify] https://crrev.com/aac97fe5f3cb5890bedac2a2ba9fec6b3e8c16fc/chromeos/dbus/sms_client.cc
[modify] https://crrev.com/aac97fe5f3cb5890bedac2a2ba9fec6b3e8c16fc/chromeos/dbus/sms_client.h
[modify] https://crrev.com/aac97fe5f3cb5890bedac2a2ba9fec6b3e8c16fc/chromeos/network/network_sms_handler.cc

Status: Fixed (was: Started)

Sign in to add a comment