New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781036 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Versioning for data device related protocol is broken

Project Member Reported by reve...@chromium.org, Nov 2 2017

Issue description

Sorry, I missed this during review. Version handling for data device interfaces is broken in chrome. It's causing non-arc clients to crash.
 
I'll fix the chrome side. hirono@, can you take care of fixing the android side if some changes are needed on that side? Changes are likely needed as with proper version handling, version 1 clients will not get version 3 events.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5008ba658b1e308223736a24a6288d31423073e6

commit 5008ba658b1e308223736a24a6288d31423073e6
Author: David Reveman <reveman@chromium.org>
Date: Fri Nov 03 01:43:15 2017

exo: Implement proper versioning for data device manager

Version 1 is reported but version 3 is currently implemented. That
is causing clients to crash. This makes us report version 3 and
take into account the version supported by the client.

Bug:  781036 
Test: weston-info
Change-Id: I263eb12637c12a3b6604343da8ec0b5922718f3e
Reviewed-on: https://chromium-review.googlesource.com/752761
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513653}
[modify] https://crrev.com/5008ba658b1e308223736a24a6288d31423073e6/components/exo/wayland/server.cc

Status: Fixed (was: Started)

Sign in to add a comment