New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781029 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 778956
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::Element::SetIntegralAttribute

Project Member Reported by ClusterFuzz, Nov 2 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5754367109234688

Fuzzer: inferno_twister
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::Element::SetIntegralAttribute
  blink::Document::WillChangeFrameOwnerProperties
  blink::HTMLFrameElementBase::SetMarginWidth
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=508795:508862

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5754367109234688

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 3 2017

Components: Blink>DOM Blink>HTML
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 3 2017

Labels: Test-Predator-AutoOwner
Owner: chaopeng@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/145660d6a05041e0da6a412598a29741b9efe816 (Invalid viewport meta width/height value should fall back to auto.).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Labels: Test-Predator-Wrong-CLs
Owner: ----
I can still reproduce the crash with my patch's revert patch. https://chromium-review.googlesource.com/c/chromium/src/+/753802

Comment 4 by kochi@chromium.org, Nov 3 2017

Cc: kochi@chromium.org
Owner: yosin@chromium.org
yosin@, could you take a look?
Labels: Test-Predator-Auto-CC
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner
Labels: -Test-Predator-Auto-CC

Comment 9 by yosin@chromium.org, Nov 14 2017

Labels: -Pri-1 Pri-3
Owner: ----
Status: (was: Assigned)
Lower to Pri-3 since it is caused by unusual HTML and DOM mutation events.

Comment 10 by kochi@chromium.org, Dec 27 2017

Status: Available
Project Member

Comment 11 by ClusterFuzz, Jan 20 2018

ClusterFuzz has detected this issue as fixed in range 530461:530464.

Detailed report: https://clusterfuzz.com/testcase?key=5754367109234688

Fuzzer: inferno_twister
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::Element::SetIntegralAttribute
  blink::Document::WillChangeFrameOwnerProperties
  blink::HTMLFrameElementBase::SetMarginWidth
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=508795:508862
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=530461:530464

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5754367109234688

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Jan 20 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase 5754367109234688 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 13 by kochi@chromium.org, Jan 22 2018

Cc: fergal@chromium.org
@fergal FYI
Probably your CL fixed this as well.

https://chromium.googlesource.com/chromium/src/+/7d8f1e30e8d6918f4da3657e03be88d555deccd8

Mergedinto: 778956
Status: Duplicate (was: Verified)
Yes, looks like. Thanks.

Sign in to add a comment