clang-format quality problem - interface defaults in Java |
||||||
Issue description
clang-format produced code that (choose all that apply):
- Doesn't match Chromium style
- Riles my finely honed stylistic dander
- No sane human would ever choose
Here's the code before formatting:
/**
* FeedbackReporter enables Chrome to send feedback to the feedback server.
*/
public interface FeedbackReporter {
/**
* Report feedback to the feedback server.
*
* @param collector the {@link FeedbackCollector} to use for extra data.
*/
default void reportFeedback(FeedbackCollector collector) {}
}
Here's the code after formatting:
/**
* FeedbackReporter enables Chrome to send feedback to the feedback server.
*/
public interface FeedbackReporter {
/**
* Report feedback to the feedback server.
*
* @param collector the {@link FeedbackCollector} to use for extra data.
*/
default void
reportFeedback(FeedbackCollector collector) {}
}
Here's how it ought to look:
/**
* FeedbackReporter enables Chrome to send feedback to the feedback server.
*/
public interface FeedbackReporter {
/**
* Report feedback to the feedback server.
*
* @param collector the {@link FeedbackCollector} to use for extra data.
*/
default void reportFeedback(FeedbackCollector collector) {}
}
Code review link for full files/context:
https://chromium-review.googlesource.com/c/chromium/src/+/726821
,
Jan 22 2018
,
Jan 23 2018
Issue 781018 has been merged into this issue.
,
Jan 23 2018
Fixed in http://llvm.org/viewvc/llvm-project?view=revision&revision=323218 , just needs a clang-format roll.
,
Aug 1
,
Sep 26
,
Nov 26
A clang-format with the fix got deployed on Nov 21 2018. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dtrainor@chromium.org
, Nov 2 2017