New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 780982 link

Starred by 1 user
Status: Fixed
Owner:
█ chili@chromium.org
Last visit 21 days ago
Closed: Jan 2018
Cc:
█ aboss@chromium.org
yus...@chromium.org
█ dim...@chromium.org
shaktisahu@chromium.org
dtrainor@chromium.org
█ ltian@chromium.org
█ sbirch@chromium.org
█ chili@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Browser Actions needs a callback to from OfflinePage to release the foreground service

Reported by ltian@chromium.org, Nov 2 2017 
Now Browser Actions calls OfflinePageBridge.savePageLater to download a url and lets OfflinePage itself to manage the life cycle of the Download service. It also immediately dismisses the spinning ProgressDialog and Activity.

The more descent way to handle this should be having a callback from OfflinePage to release the download service. And also it could be used to dismiss the ProgressDialog and BrowserActionsActivity.

Comment 1 by chili@chromium.org, Nov 2 2017

Owner: chili@chromium.org

Comment 2 by chili@chromium.org, Nov 2 2017

Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/218636353509ea4fca1339f60d7ec2a2c9665d2d

commit 218636353509ea4fca1339f60d7ec2a2c9665d2d
Author: Cathy Li <chili@chromium.org>
Date: Wed Jan 10 03:39:56 2018

[Offline pages] Add callback for whether the call to SavePageLater is successful or not

Bug:  780982 
Change-Id: Id8e1d7453fb57a4e16259e32e04ee7fdab11275f
Reviewed-on: https://chromium-review.googlesource.com/755887
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528232}
[modify] https://crrev.com/218636353509ea4fca1339f60d7ec2a2c9665d2d/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/218636353509ea4fca1339f60d7ec2a2c9665d2d/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
[modify] https://crrev.com/218636353509ea4fca1339f60d7ec2a2c9665d2d/chrome/browser/offline_pages/android/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/218636353509ea4fca1339f60d7ec2a2c9665d2d/chrome/browser/offline_pages/android/offline_page_bridge.cc
[modify] https://crrev.com/218636353509ea4fca1339f60d7ec2a2c9665d2d/chrome/browser/offline_pages/android/offline_page_bridge.h
[modify] https://crrev.com/218636353509ea4fca1339f60d7ec2a2c9665d2d/chrome/browser/offline_pages/offline_page_tab_helper.cc
[modify] https://crrev.com/218636353509ea4fca1339f60d7ec2a2c9665d2d/chrome/browser/offline_pages/offline_page_utils_unittest.cc
[modify] https://crrev.com/218636353509ea4fca1339f60d7ec2a2c9665d2d/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
[modify] https://crrev.com/218636353509ea4fca1339f60d7ec2a2c9665d2d/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h
[modify] https://crrev.com/218636353509ea4fca1339f60d7ec2a2c9665d2d/components/offline_pages/core/background/request_coordinator.cc
[modify] https://crrev.com/218636353509ea4fca1339f60d7ec2a2c9665d2d/components/offline_pages/core/background/request_coordinator.h
[modify] https://crrev.com/218636353509ea4fca1339f60d7ec2a2c9665d2d/components/offline_pages/core/background/request_coordinator_unittest.cc
[modify] https://crrev.com/218636353509ea4fca1339f60d7ec2a2c9665d2d/components/offline_pages/core/background/request_queue_results.h
[modify] https://crrev.com/218636353509ea4fca1339f60d7ec2a2c9665d2d/components/offline_pages/core/downloads/download_ui_adapter_unittest.cc

Comment 4 by chili@chromium.org, Jan 10 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment