New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780976 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

media.mse_cases benchmark was removed but is still scheduled on builders

Project Member Reported by ashleymarie@chromium.org, Nov 2 2017

Issue description

Looks like it's failing with the error No benchmark named "media.mse_cases"

Looks like media.mse_cases benchmark was removed today in
https://chromium-review.googlesource.com/750202

So I think I'm going to deschedule this benchmark

There might be more builders failing soon with a similar error since it appears to be scheduled on other builders as well still...

If anyone has objections to just descheduling it, speak now :)
 
Summary: media.mse_cases benchmark was removed but is still scheduled on builders (was: One Buildbot Step Test Builder is red)
Nope, I am surprised that our PRESUBMIT didn't catch this 
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/629ae7433f5ddf8c10719b6936e81403f3178520

commit 629ae7433f5ddf8c10719b6936e81403f3178520
Author: Ashley Enstad <ashleymarie@chromium.org>
Date: Fri Nov 03 13:20:15 2017

Descheduling media.mse_cases

media.mse_cases benchmark was removed today in
https://chromium-review.googlesource.com/750202 so the OBBS Test Builder
is failing with the error No benchmark named "media.mse_cases". I'm
guessing other builders will be following soon with the same error so
I'm preemptively descheduling the removed benchmark.

BUG= chromium:780976 

Change-Id: I90d5035755e1817d9ee79fe59bf0504d6ba6d2ee
Reviewed-on: https://chromium-review.googlesource.com/752182
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#513757}
[modify] https://crrev.com/629ae7433f5ddf8c10719b6936e81403f3178520/tools/perf/core/benchmark_sharding_map.json
[modify] https://crrev.com/629ae7433f5ddf8c10719b6936e81403f3178520/tools/perf/core/desktop_benchmark_avg_times.json

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6f833b4a22e2db9ec3a5ebd81bbbb41611da81a

commit f6f833b4a22e2db9ec3a5ebd81bbbb41611da81a
Author: Ashley Enstad <ashleymarie@chromium.org>
Date: Fri Nov 03 19:18:48 2017

Adding presubmit check to make sure benchmark sharding map file is always up to date.

Regenerating the sharding map will also remove benchmarks from the map
if the benchmarks no longer exist (e.g. were deleted recently).

BUG= chromium:780976 

Change-Id: Ie8c5d0465e3c04e193485e5f8770c1849cca4811
Reviewed-on: https://chromium-review.googlesource.com/753646
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#513867}
[modify] https://crrev.com/f6f833b4a22e2db9ec3a5ebd81bbbb41611da81a/tools/perf/PRESUBMIT.py
[modify] https://crrev.com/f6f833b4a22e2db9ec3a5ebd81bbbb41611da81a/tools/perf/core/benchmark_sharding_map.json
[modify] https://crrev.com/f6f833b4a22e2db9ec3a5ebd81bbbb41611da81a/tools/perf/core/sharding_map_generator.py

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/506f70c42935168b90d9c9571c2dcea8b1043ca1

commit 506f70c42935168b90d9c9571c2dcea8b1043ca1
Author: Ashley Enstad <ashleymarie@chromium.org>
Date: Wed Nov 15 22:41:49 2017

Removing presubmit for benchmark sharding map.

Seems to cause an issue if you manually update chromium.perf.json
instead of waiting for the presubmit to do it. Could also cause all our
benchmarks to be assigned to different bots unexpectedly if the timings
change too much which will be an issue until we figure out the bot
affinity issue. For now, I'll plan to manually run the script on
occasion to ensure things are alphabetized and what not.

BUG= chromium:780976 

Change-Id: I4d06f771df706b17ecf8b2ad2f2dd8baef6476bb
Reviewed-on: https://chromium-review.googlesource.com/772829
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516869}
[modify] https://crrev.com/506f70c42935168b90d9c9571c2dcea8b1043ca1/tools/perf/PRESUBMIT.py

Status: Fixed (was: Assigned)
Gonna go ahead and close this one since media.mse_cases is no longer scheduled

Sign in to add a comment