Issue metadata
Sign in to add a comment
|
Remove security_bits from a bunch of enums |
||||||||||||||||||||||||
Issue descriptionOnce we no longer need it for Page Info (it's only used on Android), we can remove it from: - SSLStatus - VisibleSecurityState - SecurityInfo https://cs.chromium.org/chromium/src/components/security_state/core/security_state.h?l=124&rcl=13e9b84c8187eb11f42c04969a9a57757fd720f3
,
Feb 18 2018
,
Nov 19
,
Nov 19
,
Nov 28
This is mostly done in CL 1338259 [1], save for one detail in the test SecurityStateTabHelperTest/HttpPage. For completeness, this test should check the value of security_info.connection_info_initialized. I originally thought the value should be false, but the value is actually true. See [2] for my discussion with meacer. I am adding a TODO to follow up with estark when she is available. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1338259 [2]: https://chromium-review.googlesource.com/c/chromium/src/+/1338259/17/chrome/browser/ssl/security_state_tab_helper_browsertest.cc#642
,
Nov 29
,
Dec 14
The NextAction date has arrived: 2018-12-14
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b74021e7575934bca8499de7343c61c8258f3d5 commit 6b74021e7575934bca8499de7343c61c8258f3d5 Author: Daniel McArdle <dmcardle@chromium.org> Date: Mon Dec 17 20:05:29 2018 Finish process of removing security_bits from structs Add missing field to a test and rename helper method in security_state_tab_helper_browsertest. Bug: 780972 Change-Id: Ieb5784f36010c72ad8ee2d68a118676bd511148a Reviewed-on: https://chromium-review.googlesource.com/c/1379275 Commit-Queue: Daniel McArdle <dmcardle@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#617199} [modify] https://crrev.com/6b74021e7575934bca8499de7343c61c8258f3d5/chrome/browser/ssl/security_state_tab_helper_browsertest.cc
,
Dec 17
This is done!
,
Dec 17
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by est...@chromium.org
, Nov 10 2017