New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780967 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 862640

Blocking:
issue 549140
issue 718157



Sign in to add a comment

Isolated Telemetry tests use gsutil to dynamically fetch stuff

Project Member Reported by iannucci@chromium.org, Nov 2 2017

Issue description

Thus, they're not very isolated :).

There's a three potential solutions I can think of:
  * do all the gsutil stuff before creating the isolate, and then stick the artifacts in the isolate
  * fetch the artifacts as CIPD packages as part of the swarming task
  * add the devshell wrapper tool to the tasks and assign a service account so that they can continue to fetch stuff (this is the least preferred solution)

But I'm sure there's more possibilities (I'm also a bit fuzzy on the exact details of the underlying fetcher thingy).

In particular, this will be important to fix sooner than later, because we're rolling out swarming service accounts, which will no longer give all bots blanket read/write access credentials for e.g. gsutil (which is what these tests currently rely on).
 
Cc: dpranke@chromium.org eyaich@chromium.org martiniss@chromium.org
Owner: ----
Status: Available (was: Assigned)
The best way to do this is to prefetch all Telemetry dependencies through gclient sync & have isolate already include those extra deps. 

How urgent is this bug? Our team's OKR is very packed, so it would be great if we can push this to Q1 next year.
I agree prefetching would be the best. I think it's doable. Dirk had an idea about how to do this I think?

I don't think we can push this back to Q1; from what I could tell they're going to roll out the swarming service accounts this quarter.
If doing it in gclient is too hard, including the devshell wrapper and setting up a service account would probably change the fewest number of things.
I actually tried to enable prefetch everything in https://codereview.chromium.org/2921353002/#msg29 but there was some concern about adding 7 mins of data fetching (one-time hit) to the compile step, so it didn't go through.
So the other thing you could do would be to wrap that data up in a cipd package, and then include that in the swarming task. Then the triggering would just reference the data, and the swarming bot would have it cached already.

CIPD is also available on all developer machines too, so if devs need it, they could fetch the same version.
Blocking: 718157
Owner: dpranke@chromium.org
Status: Started (was: Available)
I can/will help with the gclient/gn parts. Once that's done, the rest of this is hopefully straightforward.

We've decided that the 7 min hit is acceptable (though we should figure out if we can parallelize/speed that up), but we also realized that this only works on google machines, so we can't enable it by default (bug 773357).
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/81dc0c738f01f728be4320bfc7c427b20f82deef

commit 81dc0c738f01f728be4320bfc7c427b20f82deef
Author: Dirk Pranke <dpranke@chromium.org>
Date: Thu Nov 02 21:14:15 2017

Add a custom_var for fetching telemetry deps to the chromium recipe.

We want bots running the chromium configs to fetch the telemetry
dependencies by default, so this change makes that explicit.

R=iannucci@chromium.org, martiniss@chromium.org, phajdan.jr@chromium.org
BUG= 780967 

Change-Id: Iec16c49d8573748dff77c2de17a76764bf3202c6
Reviewed-on: https://chromium-review.googlesource.com/752181
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_bad_output.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/test.expected/remove_culprits_for_flaky_failures.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/failure_tryserver.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/ios/examples/full.expected/expired.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_one_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/gathering_references_no_values.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/bad set up.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_cts_test.expected/basic.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Linux_deterministic__dbg_.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_Builder.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/test.expected/none_swarming_tests.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic__dbg__fail.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_disconnected_device.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/linux_tests.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/api/deapply_patch.expected/basic.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/failed_build_inconclusive_1.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__test_failure.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/retest_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/android/builder.expected/full_client_v8_fyi_Android_Builder.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_no_device.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/histograms.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/archive/tests/zip_and_upload_build.expected/mac.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/codesearch/tests/checkout_generated_files_repo_and_sync.expected/generated_repo_not_set_failed.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_bucket.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/update_components.expected/addition_into_subdirs.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_gtest.expected/trigger_script.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus6_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/ios/examples/full.expected/target_cpu_missing.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/update_components.expected/removal.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/ios/examples/full.expected/no_exit_code.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/ios/examples/full.expected/test_failure.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/test.expected/nonexistent_test_step_skipped.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_swarming_tests.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/legion/legion.expected/basic.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/update_components.expected/failed_upload.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/no_values.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/precommit_args.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_one_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus7_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric_valueset.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming_trigger_script.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/update_components.expected/conflict.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium_libfuzzer_clang_tot.expected/full_chromium_fyi_ClangToTLinuxASanLibfuzzer.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium.expected/gtest_bad_custom_merge_script.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection_linux.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/run_presubmit.expected/presubmit-infra-failure.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium_trybot.expected/invalid_results.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/ios/try.expected/without_patch_success.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/preemptive_bot_update.expected/mac.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_build_error.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium_trybot.expected/skip_swarming_layout_tests_via_manual_diff_doesnt_match.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_MSan.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_pass.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/merge_invalid.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium.expected/msan.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/run_presubmit.expected/chromium.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_checkout/examples/full.expected/buildbot.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/bad_config.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium_trybot.expected/gclient_runhooks__with_patch__failure.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium_trybot.expected/dont_deapply_patch.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/webrtc_fyi_tester.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/ios/try.expected/gn.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/swarming_dimension_sets.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium.expected/dynamic_gtest.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/swarming/staging.expected/android.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/compile.expected/previous_revision_valid.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/v8_roll_bisect_bis.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/ios/try.expected/additional_compile_targets.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/basic_buildbot_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_fyi_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_one_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/compile.expected/check_suspected_revision_before_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/test.expected/record_infra_failure.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/test.expected/compile_skipped.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_no_results_failure.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/update_components.expected/addition.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_blink_trybot.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/ios/try.expected/no_compilation.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium.expected/dynamic_swarmed_instrumentation_test.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_ignore_task_failure.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/test.expected/findit_tests_multiple_culprits.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/flake.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.expected/chartjson_simplified_ignore_task_failure.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_nexus7_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/return_code_fail.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/steps/webrtc_perf_test.expected/upload_any_wav_files_from_audio_quality_test.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_checkout/examples/full.expected/kitchen.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/basic_linux_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/api/prepare_checkout.expected/basic.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium_trybot.expected/check_swarming_version_failure.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.expected/invalid_test_results.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromedriver/examples/full.expected/Android_ChromeDriver_basic.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.expected/basic.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium_trybot.expected/swarmed_layout_tests_with_and_without_patch_fail.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_custom_results_handler.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_failed_device.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/failure.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/codesearch/tests/checkout_generated_files_repo_and_sync.expected/basic.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium.expected/dynamic_script_test_failure.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/basic_buildbot_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_at_first_revision_of_a_sub_range.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/chromium_upload_clang.expected/full_tryserver_chromium_mac_mac_upload_clang.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Deterministic_Linux_fail.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/ios/try.expected/without_patch_failure.json
[modify] https://crrev.com/81dc0c738f01f728be4320bfc7c427b20f82deef/scripts/slave/recipes/
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1d528fc0a6602a03e9c7a2f0a8f0422cd8bad9c

commit c1d528fc0a6602a03e9c7a2f0a8f0422cd8bad9c
Author: Dirk Pranke <dpranke@chromium.org>
Date: Fri Nov 03 15:15:03 2017

Check out telemetry dependencies properly using a gclient condition.

This adds a 'checkout_telemetry_dependencies' flag, so that we
can stop relying on the GYP_DEFINE. This defaults to off for now
because the dependencies contain some internal things; eventually
we should split them into public and private dependencies.

R=martiniss@chromium.org, nednguyen@google.com, iannucci@chromium.org
BUG= 780967 , 718157

Change-Id: I1c2681af21a547b21e772b2ec729a7af17045f3d
Reviewed-on: https://chromium-review.googlesource.com/752044
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513777}
[modify] https://crrev.com/c1d528fc0a6602a03e9c7a2f0a8f0422cd8bad9c/DEPS

I'm taking a look now to see if this change worked. It looks like it might not have, but it's a bit unclear.
I think some (most? all?) of the bots were already setting the GYP_DEFINE, so I'm not sure if the change would've had any effect. If there were bots that weren't, then, yes, it should've helped. If you find a failure, let me know.
Yeah, I think most bots did have the GYP_DEFINE. The wpr archives aren't in there.

As far as I can tell, that command never did download the wpr archives. I had thought previously that running this command would download the wpr archives, but as I'm digging into the catapult code, the WPR archives are only checked and downloaded when a story is run. So I think we're going to need some changes telemetry side. Ned, does this sound right?
Yes, we need to redo the change in https://codereview.chromium.org/2921353002/#msg29 in order to fetch all telemetry wpr dependencies
I think the change you mention has already essentially landed.

I looked at https://codereview.chromium.org/download/issue2921353002_100001_110003.diff, and the only difference I could see is that that CL does some browser options stuff, which seems to not be necessary, and also has a comment saying we shouldn't be doing it.

Ned, am I looking at the wrong patch set?
Owner: martiniss@chromium.org
I am out of my knowledge zone here, so I'm going to punt it to you; feel free to punt it to nednguyen@ instead if need be.

I'll post a couple of CLs to remove the old-style hooks, regardless of whether they currently do anything or not.
#14: you need to look at "Patch set 5"
I don't see any meaningful diffs in patch set 5 as well. 

My understanding is that we could just add the DEPS line present in that CL, which does effectively what the CL in #9 does, but instead of calling checkout_telemetry_dependencies, we call fetch_benchmark_deps.py.
Right, we need to call fetch_benchmark_deps.py to fetch WPRs
https://chromium-review.googlesource.com/c/chromium/src/+/756353 successfully calls fetch_benchmark_deps.py in gclient runhooks on the bots. So theoretically we could land it and we'd be happy. 
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/924a02d316fe6de1b0a1a93fe522b1d2fe14ce82

commit 924a02d316fe6de1b0a1a93fe522b1d2fe14ce82
Author: Stephen Martinis <martiniss@chromium.org>
Date: Wed Nov 08 10:12:03 2017

Fetch benchmark binary deps

This CL adds fetching benchmark runtime deps (web page replay
files) to gclient runhooks. This adds about 5 minutes of extra cycle
time to each builder.

Bug:  780967 
Change-Id: I012e35ab8da37d475c6012688831a87486dc149f
Reviewed-on: https://chromium-review.googlesource.com/756353
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514790}
[modify] https://crrev.com/924a02d316fe6de1b0a1a93fe522b1d2fe14ce82/DEPS

https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FLinux_Builder%2F159356%2F%2B%2Frecipes%2Fsteps%2Fgclient_runhooks%2F0%2Fstdout and https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Builder%2F94103%2F%2B%2Frecipes%2Fsteps%2Fgclient_runhooks%2F0%2Fstdout are both logs which have it fetching the wpr replays. So it looks like that flag is set on our builders.

I don't see it in the isolate files though. https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FLinux_Builder%2F159356%2F%2B%2Frecipes%2Fsteps%2Fisolate_tests%2F0%2Flogs%2Fjson.output%2F0 gives me 7530c3ae61a42e081550c1940bbc9fdd67960d99 for telemetry_perf_tests. I tried a similar isolate earlier, and it didn't have the wpr files. AFAIK the entire //tools/perf directory is included in the isolate file, so I'm not sure what's going on.
Ah ok, nevermind. Looks like it's in there!
Awesome, and in the logs for https://chromium-swarm.appspot.com/task?id=39b4a8f976df9410&refresh=10&show_raw=1 I see this:

(INFO) 2017-11-08 05:56:13,891 archive_info.DownloadArchivesIfNeeded:68  Downloading WPR archives. This can take a long time.
(INFO) 2017-11-08 05:56:13,892 archive_info.DownloadArchivesIfNeeded:110  All WPR archives are downloaded, took 0.000540018081665 seconds.
Cc: dtu@chromium.org
+Dave: thanks to Stephen's work, we now fetch the WPR archives during build time & put them in isolate. Can you check if the bisect runtime is reduced on all platforms?
Blocking: 549140
Woot! This is great. Thanks for working on this.
Status: Fixed (was: Started)
I believe this is done. Thanks Stephen!
There's still a TODO referencing this bug in the DEPS file...
Owner: nednguyen@chromium.org
Status: Assigned (was: Fixed)
Ned, is it safe to remove this TODO? https://cs.chromium.org/chromium/src/DEPS?type=cs&q=780967&sq=package:chromium&g=0&l=1890 is the specific line.
Yes, I think so.
Cc: nednguyen@chromium.org
Owner: dpranke@chromium.org
Actually Dirk knows about that part more than me since he did most of the work here
Owner: martiniss@chromium.org
Yes, it should be safe to remove that hook. @martiniss - did you want to try to do so?
Blockedon: 862640
I accidentally seem to have picked up the cleanup task in Issue 862640. Sorry for stepping on anyone's toes.

Status: Fixed (was: Assigned)
The DEPS cleanup is done now.

Comment 36 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 37 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment