[Cronet] Expose QUIC handshake timeout as experimental options. |
|||
Issue descriptionWe should consider increasing the handshake timeout from the current defaults of 5 seconds for idle timeout and 10 for total timeout. These were conservative numbers picked a while ago, and there's evidence they're too short. If a large portion of connections are using TCP, that's good evidence the timeouts are too short. Currently Cronet doesn't expose any knobs to configure those, but QuicConfig has set_max_time_before_crypto_handshake() set_max_idle_time_before_crypto_handshake() We should add Cronet experimental options to adjust those.
,
Nov 13 2017
Can this actually be changed on iOS?
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98387515ac91eae9fea10ce175eadfb30ddb385a commit 98387515ac91eae9fea10ce175eadfb30ddb385a Author: Yixin Wang <wangyix@chromium.org> Date: Tue Nov 21 20:30:13 2017 Allow HttpNetworkSession::Params::quic_max(_idle)_time_before_crypto_handshake to be set by Cronet experiments Bug: 780964 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib405bcdd6ae986f0eb2f6e1be9f360a61dbf1e3c Reviewed-on: https://chromium-review.googlesource.com/778043 Commit-Queue: Yixin Wang <wangyix@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#518366} [modify] https://crrev.com/98387515ac91eae9fea10ce175eadfb30ddb385a/components/cronet/url_request_context_config.cc [modify] https://crrev.com/98387515ac91eae9fea10ce175eadfb30ddb385a/components/cronet/url_request_context_config_unittest.cc
,
Nov 21 2017
,
Nov 21 2017
Has go/cronet-experimental-options been updated to reflect the new options?
,
Nov 22 2017
rch@: yes, it has been updated. |
|||
►
Sign in to add a comment |
|||
Comment 1 by rch@chromium.org
, Nov 10 2017