New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780951 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Regression in Event.Latency.ScrollBegin.Touch.TimeToScrollUpdateSwapBegin2 on Windows

Project Member Reported by nzolghadr@chromium.org, Nov 2 2017

Issue description

We see a regression in lower percentile (i.e. <= 50) for the Event.Latency.ScrollBegin.Touch.TimeToScrollUpdateSwapBegin2 metric.

https://uma.googleplex.com/timeline_v2?sid=ea262734d31f00ccb20d61581a537b6e#Event.Latency.ScrollBegin.Touch.TimeToScrollUpdateSwapBegin2

It seems to be caused by the Vsync align input change which got into beta and is enabled by default in m63.

It is worth noting that the finch shows the same result in lower percentile and also a huge improvement in the higher percentiles in the dev channel.

https://uma.googleplex.com/p/chrome/variations/?sid=f53bf1b409b6edbb8a8cc659f1c6a30f

It also applies to Event.Latency.ScrollUpdate.Touch.TimeToScrollUpdateSwapBegin2
 
Labels: Performance-Responsiveness
Cc: chongz@chromium.org
+chongz@
Labels: -Pri-3 Pri-1
This is a performance regression, so P1. Understanding the impact is P1, but let's reassess priority from there.
So the initial bump looks to be adoption. The data around the Nov 6,7 shows about 5ms of latency 18ms->23ms.

chongz@ this is similar numbers you saw on the perf waterfall right?
I believe the 18ms->23ms regression is what we are expecting from Vsync Aligned Input.

The 18ms->23ms = +27.8% regression is similar to the one we saw in Finch Trial mentioned in #0.
e.g. A +38.2% sum regression in 50th percentile where the count is roughly the same (Δ: -5.9%).

This 5ms regression sounds reasonable to me since Vsync Aligned Input could cause as much as half a frame delay in average.
The Speed Releasing team is trying to be a bit more rigorous about justifying regressions.

Do we have a doc or something we can point to when claiming that we should accept this?
Re #6: No I don't think there is a doc or something we can point to... IIRC we discussed offline and agreed that the additional half-frame latency is unavoidable if we want to align events...
Yup, we've had this discussion as the input team. We want something we can point folks in general to which justifies this regression.
Owner: nzolghadr@chromium.org
High speed camera tests were conducted and recorded here:

https://docs.google.com/spreadsheets/d/1wgN2sbqzefWXRqeIqOHy-xUC6R5ijsLisOgqNduoXzQ/edit#gid=544614617
Status: Fixed (was: Assigned)
Thanks dave for attaching the doc. Looking at the doc and the UMA it doesn't seem to be much of a regression beyond what we expected. Closing this for now but let me know if anyone has any comments and wants further investigation.

Sign in to add a comment