MD Extensions: side nav should look more like history |
|||||
Issue descriptionChrome Version: 64.0.3253.3 (Official Build) dev (64-bit) OS: Linux What steps will reproduce the problem? (1) flip chrome://flags/#enable-md-extensions to enabled (2) visit chrome://extensions, open side nav (3) visit chrome://history, open side nav What is the expected result? The opened side navs look alike. What happens instead? They don't. Please use labels and text to provide additional information. [see screenshots]
,
Nov 10 2017
,
Nov 10 2017
,
Nov 10 2017
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d12f1ff7b61c6cc0f8e07a149fa6ef5a701c4882 commit d12f1ff7b61c6cc0f8e07a149fa6ef5a701c4882 Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Nov 10 23:53:14 2017 [MD extensions] make side nav similar to MD history side nav This CL mimics some of the styling of MD history side nav so that the UI is more consistent between history and extensions. Bug: 780949 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I75665607686daf1618752c7e13c229efde23d93f Reviewed-on: https://chromium-review.googlesource.com/762388 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#515749} [modify] https://crrev.com/d12f1ff7b61c6cc0f8e07a149fa6ef5a701c4882/chrome/browser/resources/md_extensions/sidebar.html
,
Nov 13 2017
dschuyler@ Tested this issue on Windows 7, Ubuntu 14.04 using chrome version 64.0.3267.0 and Mac OS 10.1.26 using 64.0.3265.0 by following the steps mentioned in the original comment. Attached is the screen cast for the same. Can you please check and confirm if the fix is working as intended? Thanks...
,
Nov 13 2017
The bug here, as described in opening comment, is specific to how the content of the sidebar look, which I believe has been addressed. It's not about making extensions' sidebare open by default on wide screens. @dschuyler: Can you verify and close this bug if so?
,
Nov 14 2017
#7 Thanks for the question. Please test with a smaller (more narrow) window. That will cause the slide out side nave to be similar. So the instructions in #0 should have a: (1.5) Make the window narrow enough that History doesn't show the side nav in the window. #8 Yeah, that's right, this wasn't intending to show the side nave in a large window like History does. (We could/may do that sometime, but that's not what this bug/fix is about). |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dschuyler@chromium.org
, Nov 6 2017Status: Assigned (was: Available)