New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780946 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

About removing AutomatedVolumeChangeReason in CrasAudioHandler

Project Member Reported by warx@chromium.org, Nov 2 2017

Issue description

Context:

(1) Initially, Jenny has change for not popping up volume slider during device boot: https://chromium.googlesource.com/chromium/src/+/f615009fa3d171ebc5700b8928e349f83f861841

(2) Later, this change is modified to use
enum AutomatedVolumeChangeReason {
  VOLUME_CHANGE_INITIALIZING_AUDIO_STATE,
  VOLUME_CHANGE_MAXIMIZE_MODE_SCREENSHOT,
}
and deque by me in this CL: https://chromium.googlesource.com/chromium/src/+/fd7c37b98e7c6eca718257916ab65409ee7b2c1a

(3) For improved power button screenshot, we no longer need VOLUME_CHANGE_MAXIMIZE_MODE_SCREENSHOT, so removed in https://chromium.googlesource.com/chromium/src/+/3101a17d52c9efcf6de5a06ab576eb3f5e36711f

(4) thus, it doesn't make sense to keep an enum with just one VOLUME_CHANGE_INITIALIZING_AUDIO_STATE. I tried to restore to the changes in (1), but it has problem in issue 777463.

There must be something changed either in CRAS or CrasAudioHandler. Jenny, are you aware of what might happen here?

The repro steps in issue 777463 is listed in #21

Since the tests in issue 777463 is related to headphone, I suspected it may be related to  issue 746876 .
 

Comment 1 by jen...@chromium.org, Nov 28 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a959a80c53000f0d3e1fb86d48dc2ec38e61336

commit 3a959a80c53000f0d3e1fb86d48dc2ec38e61336
Author: Jenny Zhang <jennyz@chromium.org>
Date: Wed Nov 29 20:25:10 2017

Remove the obsolete logic for handling screenshot volume button down.

Bug:  780946 
Change-Id: If4459c5ce35591b8e3e2a29f5dc856700a464ac7
Reviewed-on: https://chromium-review.googlesource.com/795150
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520223}
[modify] https://crrev.com/3a959a80c53000f0d3e1fb86d48dc2ec38e61336/chromeos/audio/cras_audio_handler.cc
[modify] https://crrev.com/3a959a80c53000f0d3e1fb86d48dc2ec38e61336/chromeos/audio/cras_audio_handler.h

Comment 3 by jen...@chromium.org, Nov 29 2017

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment