Issue metadata
Sign in to add a comment
|
chromite tests fail: gob_util does not have the attribute 'NETRC' |
||||||||||||||||||||
Issue descriptionchromite version: 29f3e3fd7af54a6e9993c8cdda82e70a38b645ad I'm getting test failures from 'python "$chromite/lib/gerrit_unittest" --network GerritHelperTest': Traceback (most recent call last): File "chromite/lib/cros_test_lib.py", line 77, in NetworkWrapper test_item(*args, **kwargs) File "chromite/lib/cros_test_lib.py", line 259, in _stacked_setUp target(obj) File "chromite/lib/cros_test_lib.py", line 1232, in setUp self.PatchObject(gob_util, 'NETRC', netrc.netrc(gi.netrc_file)) File "chromite/lib/cros_test_lib.py", line 1115, in PatchObject return self.StartPatcher(mock.patch.object(*args, **kwargs)) File "chromite/lib/cros_test_lib.py", line 1106, in StartPatcher m = patcher.start() File "chromite/third_party/mock.py", line 1396, in start result = self.__enter__() File "chromite/third_party/mock.py", line 1268, in __enter__ original, local = self.get_original() File "chromite/third_party/mock.py", line 1242, in get_original "%s does not have the attribute %r" % (target, name) AttributeError: <module 'chromite.lib.gob_util' from 'chromite/lib/gob_util.py'> does not have the attribute 'NETRC' Appears to be due to https://chromium-review.googlesource.com/c/chromiumos/chromite/+/744301/
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/b746dd556bf745957b44be29bf3574ebe4173bde commit b746dd556bf745957b44be29bf3574ebe4173bde Author: Paul Hobbs <phobbs@google.com> Date: Fri Nov 03 06:21:52 2017 cros_test_lib: Fix NETRC patcher chromite.lib.gob.NETRC was changed to a singleton function (_GetNetRC), so the code that patches out NETRC needed to be changed too. BUG= chromium:780928 TEST=None Change-Id: I2dc94a509f49d8d91ab236f3587ea49cd1f7d633 Reviewed-on: https://chromium-review.googlesource.com/752568 Commit-Ready: Jonathan Nieder <jrn@google.com> Tested-by: Jonathan Nieder <jrn@google.com> Reviewed-by: Jonathan Nieder <jrn@google.com> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/b746dd556bf745957b44be29bf3574ebe4173bde/lib/cros_test_lib.py
,
Nov 3 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by jrn@google.com
, Nov 2 2017Summary: chromite tests fail: gob_util does not have the attribute 'NETRC' (was: chromite tests fail: gob_util does not h ave the attribute 'NETRC')