New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 780918 link

Starred by 3 users
Status: WontFix
Owner:
inglorion@chromium.org
Closed: Jul 9
Cc:
█ amccarth@chromium.org
█ ruiu@google.com
p...@chromium.org
h...@chromium.org
thakis@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 792131


Sign in to add a comment

Make use_lld=true a viable alternative to is_debug_fastlink=true and the Visual C++ linker

Project Member Reported by r...@chromium.org, Nov 2 2017 
In the long term, we already plan to use LLD in the official build on Windows so that we can benefit from various whole-program optimizations and security mitigations (ThinLTO, CFI). It is already capable of linking full PDBs, and is typically much faster than the Visual C++ linker for non-incremental links. This issue covers fixing the remaining test Chromium test failures with LLD and optimizing linking to the point that we can recommend it for daily development.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e807052c0738957ab9fd02238c16b7fb0b84a365

commit e807052c0738957ab9fd02238c16b7fb0b84a365
Author: Reid Kleckner <rnk@google.com>
Date: Sat Nov 04 00:13:57 2017

Allow use_goma+symbol_level=2 with use_lld=1

In the long run, LLD is intended to be a faster replacement for the
Visual C++ linker. LLD is twice as fast as link.exe when linking clang
with PDBs, and casual usage in Chromium suggests that LLD full links are
faster than VC++ fast links.

I don't yet have a comprehensive performance comparison, but when I put
one together I'd like people to be able to replicate it locally without
having to tweak this assert.

R=brucedawson@chromium.org

Bug:  780918 
Change-Id: I0368cfb3bc8866db6498ec3422e7f77354c39ed8
Reviewed-on: https://chromium-review.googlesource.com/751289
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513981}
[modify] https://crrev.com/e807052c0738957ab9fd02238c16b7fb0b84a365/build/config/compiler/compiler.gni

Comment 2 by h...@chromium.org, Dec 5 2017

Blockedon: 792131

Comment 3 by thakis@chromium.org, Jul 9

Status: WontFix (was: Started)
Given that we've shipped lld, I suppose this is done. There's a separate bug for incremental link support somewhere, but lld is fairly fast without it already.
►

Sign in to add a comment